From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robin Murphy Subject: Re: [PATCH 12/21] dma-iommu: factor atomic pool allocations into helpers Date: Wed, 17 Apr 2019 12:54:01 +0100 Message-ID: References: <20190327080448.5500-1-hch@lst.de> <20190327080448.5500-13-hch@lst.de> <20190410061157.GA5278@lst.de> <20190417063358.GA24139@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190417063358.GA24139@lst.de> Content-Language: en-GB Sender: linux-kernel-owner@vger.kernel.org To: Christoph Hellwig Cc: Joerg Roedel , Catalin Marinas , Will Deacon , Tom Lendacky , iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org List-Id: iommu@lists.linux-foundation.org On 17/04/2019 07:33, Christoph Hellwig wrote: > On Wed, Apr 10, 2019 at 08:11:57AM +0200, Christoph Hellwig wrote: >> On Tue, Apr 09, 2019 at 06:59:32PM +0100, Robin Murphy wrote: >>> On 27/03/2019 08:04, Christoph Hellwig wrote: >>>> This keeps the code together and will simplify compiling the code >>>> out on architectures that are always dma coherent. >>> >>> And this is where things take a turn in the direction I just can't get on >>> with - I'm looking at the final result and the twisty maze of little >>> disjoint helpers all overlapping each other in functionality is really >>> difficult to follow. And I would *much* rather have things rely on >>> compile-time constant optimisation than spend the future having to fix the >>> #ifdefed parts for arm64 whenever x86-centric changes fail to test them. >> >> Can you draft up a patch on top of my series to show me what you >> want? I can take care of finishing it up and moving the changes >> into the right patches in the series. > > Any chance to make some progress on this? Or at least a better > description of what you want? Heh, I did actually start writing a reply last night to apologise for the delay - I've been clearing the decks a bit so that I can sit down and actually concentrate on this (plus the PCI DT mask fix). That's now my plan for the rest of today :) Robin. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6851DC282DA for ; Wed, 17 Apr 2019 11:54:07 +0000 (UTC) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2A90720835 for ; Wed, 17 Apr 2019 11:54:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2A90720835 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id DA07CEEF; Wed, 17 Apr 2019 11:54:06 +0000 (UTC) Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 67CD8E96 for ; Wed, 17 Apr 2019 11:54:05 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from foss.arm.com (foss.arm.com [217.140.101.70]) by smtp1.linuxfoundation.org (Postfix) with ESMTP id 1CDD5F4 for ; Wed, 17 Apr 2019 11:54:05 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AAE0A374; Wed, 17 Apr 2019 04:54:04 -0700 (PDT) Received: from [10.1.196.75] (e110467-lin.cambridge.arm.com [10.1.196.75]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 53A6F3F68F; Wed, 17 Apr 2019 04:54:03 -0700 (PDT) Subject: Re: [PATCH 12/21] dma-iommu: factor atomic pool allocations into helpers To: Christoph Hellwig References: <20190327080448.5500-1-hch@lst.de> <20190327080448.5500-13-hch@lst.de> <20190410061157.GA5278@lst.de> <20190417063358.GA24139@lst.de> From: Robin Murphy Message-ID: Date: Wed, 17 Apr 2019 12:54:01 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190417063358.GA24139@lst.de> Content-Language: en-GB Cc: Tom Lendacky , Catalin Marinas , Will Deacon , linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="UTF-8"; format="flowed" Sender: iommu-bounces@lists.linux-foundation.org Errors-To: iommu-bounces@lists.linux-foundation.org Message-ID: <20190417115401.WWMpao9K--KGOLXM-r-X9qxKNW8lGKeAs9XQEXjJNpI@z> On 17/04/2019 07:33, Christoph Hellwig wrote: > On Wed, Apr 10, 2019 at 08:11:57AM +0200, Christoph Hellwig wrote: >> On Tue, Apr 09, 2019 at 06:59:32PM +0100, Robin Murphy wrote: >>> On 27/03/2019 08:04, Christoph Hellwig wrote: >>>> This keeps the code together and will simplify compiling the code >>>> out on architectures that are always dma coherent. >>> >>> And this is where things take a turn in the direction I just can't get on >>> with - I'm looking at the final result and the twisty maze of little >>> disjoint helpers all overlapping each other in functionality is really >>> difficult to follow. And I would *much* rather have things rely on >>> compile-time constant optimisation than spend the future having to fix the >>> #ifdefed parts for arm64 whenever x86-centric changes fail to test them. >> >> Can you draft up a patch on top of my series to show me what you >> want? I can take care of finishing it up and moving the changes >> into the right patches in the series. > > Any chance to make some progress on this? Or at least a better > description of what you want? Heh, I did actually start writing a reply last night to apologise for the delay - I've been clearing the decks a bit so that I can sit down and actually concentrate on this (plus the PCI DT mask fix). That's now my plan for the rest of today :) Robin. _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu