From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E69423BA240 for ; Mon, 23 Mar 2026 16:24:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774283078; cv=none; b=dqjhKgglKrmavxo8spVDwAICNfR35dMjttLnYHVRJGvb8CBjTwDBPcITxf1ArpUJ+zqEpPrsELke1fi3EoFF5gI5KGqPYYrSW8Vzb+ANnViXJrwesXwT1tSeocZSSPJG1ly2PLqAm2mvSoJyueN+7kk8RsXH0ML45c/sefmZpYA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774283078; c=relaxed/simple; bh=0yKI8vbPNzHoqkTV0yKxdFRxvj0/LpVoQRkkpisgLuY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UNIHkFm3akH403oQr0rMGH08Ki9HXGRqD/OrPpvmG5Pek9k7lAHXsT7jmpXgJqVYJ/GehPYHEuRC6gzN5/uvJc2m91a8BNIdVvIFeE0DMoiZm+gG/l7O1pYXgdaSG+sl0a30kFFb2Ab/FqHPSdJnugkwesrUbTKTX8TnyusfT+Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=E9ZyqsTV; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="E9ZyqsTV" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2b052ec7176so176625ad.1 for ; Mon, 23 Mar 2026 09:24:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1774283076; x=1774887876; darn=lists.linux.dev; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=T3ldqgT6JBnPQmHk8LHvu61BhVbR2PK1lqFwCMwVUO4=; b=E9ZyqsTVuoOpCJc1spy31djC0qQVnpin99bMHO0mhokVWCv9qs2Agp8vRWE0pjgzws jg9GyxwXq6i4FCbrYJOy+W80TVQxT3KKpvBrMCsIFEDbKu1poSEWtOPxfu4hgIgYpjWZ M+VtuJtbL/hHODWfnTVbFGnFNupZ9ljG1GcZOFghqU7Jn4FxmCg0a9lpfVU7nmTjKM9V UN+ZkhygQQYD+bxGqi67nhhUaYATLuf8g+HHK5ZBCIl9bLAQ6RI5lKEtXuC+Qx62NFwp CiBwQHZ5rFNCt1QSCJTrB2fDAx6EvegAWgDzrh2KuOly3q7zyWSzcVeFTFzHwKqdBHvU V2GA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774283076; x=1774887876; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=T3ldqgT6JBnPQmHk8LHvu61BhVbR2PK1lqFwCMwVUO4=; b=E5TXu+7/SFpOFRx7VkE8k9sycpQGO2j83UpsVNgSxAT77i+BfV191BOssI3lmegfzh vzLsz66pigDxhMtkL8+wYvrKQ1cs29omIfqiwvVo+tIUX186LJ6tqo95Ap0mgSbhpYTn qpXUwsNOVpTv2QmzTNR6hTwaD29BToeX31j7Zc39pHxAnLtXUyB+KIbnouga2D0oRkOQ dTlQwCuyAzzVKtyckBCvSOI8x8b5TtZCuUsaL9Eb1C4KPf+QZ0pO9BjDU4ZE2OD95YMi Ib+bjuEnWpCvminn80rk89p2N1zARJ4/7dojle0ekKCB2/ChzVGlhTHVKg7BqFelDlEl ZR6w== X-Forwarded-Encrypted: i=1; AJvYcCVNRyyLxZfqBzJetfQHPeIH5thYjQv1DMD6UW25r97evLo2XetoyQqvcQOZKpT3anuM09VgTw==@lists.linux.dev X-Gm-Message-State: AOJu0Yy+UdMzsaLqCYNJGSZD82kXnZLOw7lRTitzbocencY2J6IPaGTT X+Xb+VEby8RA7Mg663lKBJ9sdP5DiObI1XFo7wd5MYn208KbN7H3wiLGEMc3m/Ppwg== X-Gm-Gg: ATEYQzyXrDytiLUDm/BAq2RSTCYU6bGoSIoCY8lpYysDpI/Os4taMAfXX7bohDfY9GL QMKciZ/OFghZWCxQBKNetL2pir3iuU1kCvqX6TMXG4Q16bo5DZo6I8ovNFplczdMxiUQwcigEm8 8DdgeIJPBft4vFFLSVK/ekbyZEdJjq7CCIwfkhbupEB+kZvw4VZYEj6Tf7Sx1TcpA1PLHfj8TS/ ebsVm2OCkg61RnbmEoIIv6PxMgxUcOm2ztR0hKiFg0kvoYnxNxhyJExgS1/eNwNsT1EYk/lgYH1 EjTl/8yOMKfc2MRn9DFB9jW9YAXPSDc6FC9kL4gJ+dMBdphKlmlhyB27zGCKaCrm1DYEJc0ldMI j89ZTa2AhABCbNXUZNEdhi7xn8Yri5ccHevWg2/tFm+NeqPVSXGwMZOFHyQ/QdM83TeMijR03c8 Yc6KpwHtKp/6SEXj+LuzErRKn2PC97DZwtM+r/cwLyAoCy+LBIh0iUPiB2qUmdLg== X-Received: by 2002:a17:902:fc4b:b0:2ae:4e8e:954e with SMTP id d9443c01a7336-2b08c423bcdmr4886495ad.5.1774283075771; Mon, 23 Mar 2026 09:24:35 -0700 (PDT) Received: from google.com (168.136.83.34.bc.googleusercontent.com. [34.83.136.168]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35bc5ff704bsm13278934a91.2.2026.03.23.09.24.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 09:24:35 -0700 (PDT) Date: Mon, 23 Mar 2026 16:24:30 +0000 From: Samiullah Khawaja To: Vipin Sharma Cc: David Woodhouse , Lu Baolu , Joerg Roedel , Will Deacon , Jason Gunthorpe , YiFei Zhu , Robin Murphy , Kevin Tian , Alex Williamson , Shuah Khan , iommu@lists.linux.dev, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Saeed Mahameed , Adithya Jayachandran , Parav Pandit , Leon Romanovsky , William Tu , Pratyush Yadav , Pasha Tatashin , David Matlack , Andrew Morton , Chris Li , Pranjal Shrivastava Subject: Re: [PATCH 10/14] iommufd-lu: Implement ioctl to let userspace mark an HWPT to be preserved Message-ID: References: <20260203220948.2176157-1-skhawaja@google.com> <20260203220948.2176157-11-skhawaja@google.com> <20260319231331.GB3983821.vipinsh@google.com> <20260320232634.GC659132.vipinsh@google.com> Precedence: bulk X-Mailing-List: iommu@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20260320232634.GC659132.vipinsh@google.com> On Fri, Mar 20, 2026 at 04:34:41PM -0700, Vipin Sharma wrote: >On Fri, Mar 20, 2026 at 12:40:44AM +0000, Samiullah Khawaja wrote: >> On Thu, Mar 19, 2026 at 04:35:32PM -0700, Vipin Sharma wrote: >> > On Tue, Feb 03, 2026 at 10:09:44PM +0000, Samiullah Khawaja wrote: >> > > From: YiFei Zhu >> > > @@ -374,6 +374,10 @@ struct iommufd_hwpt_paging { >> > > bool auto_domain : 1; >> > > bool enforce_cache_coherency : 1; >> > > bool nest_parent : 1; >> > > +#ifdef CONFIG_IOMMU_LIVEUPDATE >> > > + bool lu_preserve : 1; >> > > + u32 lu_token; >> > >> > Should we use full name i.e. liveupdate here and other places in this >> > series? >> >> I think using full name liveupdate would be too long in other places in >> this series. And also there are other examples of "luo" being used as a >> short form. Please see: >> >> https://lore.kernel.org/all/20251125165850.3389713-15-pasha.tatashin@soleen.com/ > >That patch is using "luo" short, which I think is also wrong in saying >memfd_luo, as there is nothing related to orchestrator (O of LUO) in >that patch. It is saving memfd state for liveupdate. But that ship has >sailed. Yes, I think that makes sense. > >In the current patch, I don't think it will be too long, and it also >easier to read code without someone to know what "lu" is. We have worked >on it so we know what "lu" stands for and kind of accepted it but I >agree what Greg k-h was also suggesting. Agreed, in this patch it won't be too long. I think for the public API being used in other subsystems we can use "liveupdate", but internally we can use lu. I will rework this. > >https://lore.kernel.org/all/2025093023-frantic-sediment-9849@gregkh/ > - "You have more letters, please use them. "lu" is too short." > >Not a hard no from me, just a suggestion. Thanks, Sami