From: Nicolin Chen <nicolinc@nvidia.com>
To: <joro@8bytes.org>, <kevin.tian@intel.com>
Cc: <will@kernel.org>, <robin.murphy@arm.com>,
<baolu.lu@linux.intel.com>, <jgg@nvidia.com>,
<iommu@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
<xueshuai@linux.alibaba.com>
Subject: Re: [PATCH rc v3] iommu: Fix nested pci_dev_reset_iommu_prepare/done()
Date: Mon, 23 Mar 2026 13:18:04 -0700 [thread overview]
Message-ID: <acGf/IksLZTTcXqf@Asurada-Nvidia> (raw)
In-Reply-To: <20260321223930.10836-1-nicolinc@nvidia.com>
On Sat, Mar 21, 2026 at 03:39:30PM -0700, Nicolin Chen wrote:
> @@ -61,14 +61,14 @@ struct iommu_group {
> int id;
> struct iommu_domain *default_domain;
> struct iommu_domain *blocking_domain;
> - /*
> - * During a group device reset, @resetting_domain points to the physical
> - * domain, while @domain points to the attached domain before the reset.
> - */
> - struct iommu_domain *resetting_domain;
> struct iommu_domain *domain;
> struct list_head entry;
> unsigned int owner_cnt;
> + /*
> + * During a group device reset, @group is attached to @blocking_domain,
> + * while its @domain points to the attached domain before the reset.
> + */
> + unsigned int reset_cnt;
I found an issue in the sequent gdev-quarantine series. To fix that,
we would end up with two counters in the iommu_group, which could be
merged if it was named properly in the first place.
So, I plan to rename this 'reset_cnt' to:
+ /*
+ * Number of devices in the group undergoing or awaiting recovery.
+ * If non-zero, concurrent domain attachments are rejected.
+ */
+ unsigned int recovery_cnt;
I will respin a v4 shortly with the renaming.
Thanks
Nicolin
prev parent reply other threads:[~2026-03-23 20:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-21 22:39 [PATCH rc v3] iommu: Fix nested pci_dev_reset_iommu_prepare/done() Nicolin Chen
2026-03-23 20:18 ` Nicolin Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acGf/IksLZTTcXqf@Asurada-Nvidia \
--to=nicolinc@nvidia.com \
--cc=baolu.lu@linux.intel.com \
--cc=iommu@lists.linux.dev \
--cc=jgg@nvidia.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
--cc=xueshuai@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox