From: Pranjal Shrivastava <praan@google.com>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: iommu@lists.linux.dev, Will Deacon <will@kernel.org>,
Joerg Roedel <joro@8bytes.org>,
Robin Murphy <robin.murphy@arm.com>,
Kevin Tian <kevin.tian@intel.com>,
Ankit Soni <Ankit.Soni@amd.com>,
Samiullah Khawaja <skhawaja@google.com>,
syzbot+453eb7add07c3767adab@syzkaller.appspotmail.com
Subject: Re: [PATCH] iommufd/selftest: Add missing driver_ops for AMDV1 mock domain
Date: Thu, 26 Mar 2026 12:25:45 +0000 [thread overview]
Message-ID: <acUlyRx-wdw5Av_w@google.com> (raw)
In-Reply-To: <20260326121325.GI8437@ziepe.ca>
On Thu, Mar 26, 2026 at 09:13:25AM -0300, Jason Gunthorpe wrote:
> On Wed, Mar 25, 2026 at 09:46:15AM +0000, Pranjal Shrivastava wrote:
> > syzbot found that allocating a mock domain with AMDV1 format could
> > cause a WARN_ON because the selftest enabled DYNAMIC_TOP without
> > providing the required driver_ops.
> >
> > Initialize a spinlock (top_lock) and dummy callbacks in the mock
> > driver to satisfy the generic PT requirements.
>
> I'm inclined to delete the AMDv1 option entirely, I was thinking about
> extending the sefltest to use it but I don't have time..
>
Ack. so should we entirely remove MOCK_IOMMUPT_AMDV1? as in from the
uAPI header as well?
> Syzkaller is hitting this because it found it can use a parameter that
> the selftest never uses.
>
> Jason
Thanks,
Praan
next prev parent reply other threads:[~2026-03-26 12:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-25 9:46 [PATCH] iommufd/selftest: Add missing driver_ops for AMDV1 mock domain Pranjal Shrivastava
2026-03-26 0:00 ` Samiullah Khawaja
2026-03-26 12:13 ` Jason Gunthorpe
2026-03-26 12:25 ` Pranjal Shrivastava [this message]
2026-03-27 12:08 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acUlyRx-wdw5Av_w@google.com \
--to=praan@google.com \
--cc=Ankit.Soni@amd.com \
--cc=iommu@lists.linux.dev \
--cc=jgg@ziepe.ca \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=robin.murphy@arm.com \
--cc=skhawaja@google.com \
--cc=syzbot+453eb7add07c3767adab@syzkaller.appspotmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox