Re: [PATCH 02/22] iommu/amd: Introduce vIOMMU-specific events and event info

Suthikulpanit, Suravee
2026-04-06T03:26:11Z

Hi

On 3/30/2026 4:34 PM, Nicolin Chen wrote:
> On Mon, Mar 30, 2026 at 08:41:46AM +0000, Suravee Suthikulpanit wrote:
>> @@ -927,29 +927,42 @@ static void iommu_print_event(struct amd_iommu *iommu, void *__evt)
>> }
>>
>> if (type == EVENT_TYPE_IO_FAULT) {
>> - amd_iommu_report_page_fault(iommu, devid, pasid, address, flags);
>> + u8 vflags = (event[0] >> 27) & 0x1F;
>
> Hmm, I don't see this vflags field in the AMD vIOMMU spec
> (48882-PUB—Rev 3.10—Feb 2025).

I have checked with the documentation team, and they are in the process
of publishing the new document, which will have the information.

> Anyway, perhaps define a pair of SHIFT/MASK macros like other
> fields?

Ok

Thanks,
Suravee