From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B9DE017A309 for ; Wed, 6 May 2026 23:41:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778110878; cv=none; b=lzQgqCoiu+7CpBRQWJk3JW4IKh8B9V23Szgzi4p+07hvAmjNa+/dEYeNSuWtmWuUF6DeStuVO3VBdH8IGduSqxV9usZkm1b/kVEHYCSCLKzlOUw/LRI7oQrre9ZRmu5tUSuSPmuSRQbsk0jVErQ/CrYDhM8h0MdPgsCBucFdywM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778110878; c=relaxed/simple; bh=o0Srmy8jgIvvOfgyisrTtf/fJrmdBVr4h8Ys4jXIB1k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cN7GtD97OKUDU6xTT1EsXMWahQMLfXu3HTiblWJZTZaSyxtA0wtQ0L9LHR038RwNVdx+prn4r78BuN3NnmlxEulz23sIkbZh7JErMUT10KFb1m5JAH3L5pgJVTODM+CBQrwkHke/LQaP2P7oGLzp3DE9c4WgCs+3zjaxb0EmMDg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=hPFQ0fqY; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="hPFQ0fqY" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-2b2e8b95bdbso23375ad.0 for ; Wed, 06 May 2026 16:41:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1778110876; x=1778715676; darn=lists.linux.dev; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=o0Srmy8jgIvvOfgyisrTtf/fJrmdBVr4h8Ys4jXIB1k=; b=hPFQ0fqYsby1yyCiJ/ZLLYYlVDwOo80bOoC7ssfQNs3PLpq+UnsppLgwu3BUV1A2B0 KbWaxUL5W2pwfFF7tzUu0jvpSYTvJJho38XNQ5znSKiMqq/NKjJrA8DkVG1YB2t5xQOu wFUvGNtL/AYYzmhV3t+bRhX/cAnZjrdsYDeiPcyzt050Xy2x1F52P2r5gtFqoHWmh4hh aLlo78fUScAsrdIgl2wtth48spQ1XtZL16Cs5OBuIeRGp4cNuVGPMKb9DbI1UR7RBSa5 bqJr8tJfXoOVsoIBJx3WzprDswNGVDaqIn1NBqmEa70ShnhzyhYClLvnFjqC9EqZvard 0ZUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778110876; x=1778715676; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=o0Srmy8jgIvvOfgyisrTtf/fJrmdBVr4h8Ys4jXIB1k=; b=sh/EItxRvcWVx0y+Z9BPvGC3kaMPle/mSZOpoYK9qQRFGxJMEGLfnoNLFUO+Uhpujr VtAXwUdHParXiY8Bm0UZ2lR3i9KniDRoQyxex6Ik14eNSO/U1//58/Z65HozWAUTGrV0 N7Id4EGPtQ1at44kITagwUbGzkoEl/imSWIwsbjcRCfoxSjM/fgqcczj14ZN0Pa0YHiO pl/+82NHesox7g3T6xXRnBBpMKoyP1sS4wv3GMyew6JmCXYPT1NHy4+fkMZPVtXGXqcS MLBZdZflDIqUHXiBOe53YHypWUUMXoXL/BYxLE4W0ve9gngY+yfTYppKnCdrIw1hyh2L tdIg== X-Gm-Message-State: AOJu0YyPAo8dsz25bUDGorwz98BPpfz+5V5Djr6R87gCwv6fONthgN8n rBDn3KB/QLzlZhbj+0da0ziNuJi5Gz4VLA15PtbMVgZN6VZcaRjIwlT6EXz1G7X72Q== X-Gm-Gg: AeBDievdbLRZEr3K5R7TXNLpRimB7gCGixk/PilmkdSkKiip9o7modUk3TmqYx78m/X 20mN797c8JGM+wWe7VbADE6C3TxwNoys9MZiEALk+rYMSbh6irsH3IqCej6viPwDaoQtBhUHNaH 98EvnZUgLgA6i41ib903DrFq9ptY2pm1iYRBY/qqb/2h/aNlz+G3ifIl4E1xuEfND96rHIWsCZp a9Oi1bqtiJveiC7AzhKXjjyxy6gsPwqABlpYekxzFm0agvgjlqUSAVFUfWokc3aA122fxnVmPCx +k6A6Oj7l3gII/TeJhzxSTIeT52Su3JzUtWFlRRfOFwcT6+2j9rgSr3uD62KzGlA8DnQBQ9s8mX 7OOdGDFkBl29WR4861auxidJSrYHfPhFs09ZI0FADPToIZaNtfGDO1Q13Rq2OkCUwZEE0nPPTHY 2o9hXoTjQoUvH2Q9g8nUgFBpr72vZAhpec6fHzvMtNxJ8gHDPMUmcZLhSXE8SK6kRh3FsYna7Pb jX7Vil4 X-Received: by 2002:a17:902:d414:b0:2b4:60e6:44bc with SMTP id d9443c01a7336-2bab641edaemr956085ad.13.1778110875628; Wed, 06 May 2026 16:41:15 -0700 (PDT) Received: from google.com (153.46.83.34.bc.googleusercontent.com. [34.83.46.153]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-365b08cc8c9sm1629410a91.6.2026.05.06.16.41.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 May 2026 16:41:15 -0700 (PDT) Date: Wed, 6 May 2026 23:41:11 +0000 From: Samiullah Khawaja To: Jason Gunthorpe Cc: iommu@lists.linux.dev, Jonathan Hunter , Joerg Roedel , linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org, Robin Murphy , Thierry Reding , Krishna Reddy , Will Deacon , David Matlack , Pasha Tatashin , patches@lists.linux.dev, Mostafa Saleh Subject: Re: [PATCH 1/9] iommu/arm-smmu-v3: Add struct arm_smmu_cmd to represent the HW format command Message-ID: References: <0-v1-b7dc0a0d4aa0+3723d-smmu_no_cmdq_ent_jgg@nvidia.com> <1-v1-b7dc0a0d4aa0+3723d-smmu_no_cmdq_ent_jgg@nvidia.com> Precedence: bulk X-Mailing-List: iommu@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <1-v1-b7dc0a0d4aa0+3723d-smmu_no_cmdq_ent_jgg@nvidia.com> On Fri, May 01, 2026 at 11:29:10AM -0300, Jason Gunthorpe wrote: >Like STE/CD, add a wrapper struct around the u64 array to represent the >already FIELD_PREP'd command data. Unlike the STE/CD this is a u64 >because the command submission path will have the swap to le64. > >This makes the API clearer when a u64 is referring to a formatted >command and makes the following changes easier to follow. > >Move the command constants out of the struct and into an enum alongside >the rest of the constants defining the HW format so the entire HW format >is self contained and independent of struct arm_smmu_cmdq_ent. > >Signed-off-by: Jason Gunthorpe >--- > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h | 48 ++++++++++++--------- > 1 file changed, 28 insertions(+), 20 deletions(-) > Reviewed-by: Samiullah Khawaja