From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E26A84DA533 for ; Wed, 13 May 2026 17:42:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778694153; cv=none; b=IQyOQTU9w39slPoyEBGa2/n7lj3yQoDKV2vVz/Q+4pnMQLsFrFJPKyQWsqOZN9KQ+7ELia8klCa5CGfbvrht7vEHjeHkEGTxslZhsuSjyn3hG3kgeox9me9tP3doO7V2RGmbL3M68dYLf2xKlSrOBJ4Fefrmg5Bjojg5HiDSj3s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778694153; c=relaxed/simple; bh=Z4DQx2lSeg373FycVPY8LgB/ufohedZhPA83y4EaBOQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pVSV3OdAE9XF2Bq/K+y2xSaO89KYkO/LEU6KJg7nNVA98SvkNLWAaBKmP7xys3OgRiwY7qoUidKXdIQFcME8WdD81UMjiDu24L2MRQ9yGijF6v1OuUA4SQNmMPXXRh4/ZWxYUyAiO8AneQ3ex6stBudxGpmuWNl3eiND+I0gwR0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=nBqZDYlF; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="nBqZDYlF" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2b46da8c48eso2665ad.1 for ; Wed, 13 May 2026 10:42:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1778694151; x=1779298951; darn=lists.linux.dev; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=pcBA9DAGtJkPWnf5c2GL3hdpA6y9KY9keSOmEQ3FPfc=; b=nBqZDYlFyDJm8tYq2bqX75tLDhhGXjV1WgZeIzqbjFRm/Mu3oGZjiKvstoMN7bjHwe OS21eYMi6Bg9NmE6cLKXADxY8DloBfgQq19EKy5BhszyeiT5kAoo86OLRsEafoqDaxpF RB6C1X379BHZVnrRdx3HLUzaCR23zTQSYab+nLu5S5xzxkopecqEkuOOH5JTt2XdREdl 8oz0MJAa8+mxU3UiBjcWdhpqmUDNg/TCGoaL8y0NHgRZV4BNniAUgkoKHTyIWTHMz5UX IBh8JNvAmK3amwZPW9Qhkdwksyz9ifdAwSK99aOZggl9MwZHk1IJc066S94D79RBLd59 8mfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778694151; x=1779298951; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pcBA9DAGtJkPWnf5c2GL3hdpA6y9KY9keSOmEQ3FPfc=; b=aBZawYLQuPSdbLYf8NigD9hrQ6cNcDlTVYxBASrCz3nJjVGbRatPHYLZTXVQvp2XdW A7ymXNCPJZl3IRX+0CjRmpA7fXmvxXrnIjJaTmq5Q8vsulXB2UbXhDn7y9M87AAf9X/Z 08gnHRpl4JUz/5CTdTj7ad5BqDRgBDvbewS9BnYLSQLYElUrJmHHivlrfKzXtfqBAl3a ncXzOK8wBplJ8f1NII4rmOgoLqJdJkCnaUbGPO/Y0By/Xy2hbDl1UF2XC3bML45ByevY WgudQ5jDNVz90lkKrCcW9njZyFyqTp+7f6TjxK+eHSNCoNFGUxjy9pAT1w3G+XqDT3XT TghA== X-Gm-Message-State: AOJu0YyChSJbUZtFhTaU8ylP6hXaA3HzthLWxlU9by83jy5WH8kLmnGP l0lXo1HjAPazB2syFamcFXixzXbqj82YzeEgG+3v5ulGLNjcHatV7HjReMrlp5PneQ== X-Gm-Gg: Acq92OFp6GlWxUWsnJK+Es1hN7Fe/+ks7Ra8RfR5AATJqDSB3GuP46zkkea61VOnVSP 5me+2q9Ey59dh3f8MFkKahbVwzZTJAuBreX2APneQtwrGMmZg2xvk4RsA6MjW7rtFpwFhisyc98 yV39cq+MWCl+JI/PVmp9RKMUx2dof7bAaxiKih9TqqZbKQxqSzNxRLSuDZjykZll0KZBNe+fe+E E0RGCq/qCL7nvso7HSaK6jSt/VSdkazP+ZKnCpNj7DcZhBLJpAjPyM1qF2boHltFcPGWpGWwI60 03A+ugsNAULqP7ivYooBiX/VQJQ9Q99uYAWqxMEUY+5TYsEhtPSRIKwcQb5Gdg2vbsKxHP7XjaE hWXhR4ZbHtEOwYcGXQMj0RZA92puzJqPJ4tPSUpvK3A4czkH7T5zPj9+LzmK3WiRD2l5cEQR3Fb KGvAqEJtd4nN8XUy51xIOna+VY7Oy8vl2tNfWJHlQA/NY6HZk3YB0ep3G4yRhKBcUyy1iE X-Received: by 2002:a17:903:3c2e:b0:2ba:3b89:c3a5 with SMTP id d9443c01a7336-2bd55e46765mr226415ad.12.1778694150405; Wed, 13 May 2026 10:42:30 -0700 (PDT) Received: from google.com (44.234.124.34.bc.googleusercontent.com. [34.124.234.44]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-369224d2f4csm151787a91.0.2026.05.13.10.42.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 May 2026 10:42:29 -0700 (PDT) Date: Wed, 13 May 2026 17:42:22 +0000 From: Pranjal Shrivastava To: Jason Gunthorpe Cc: iommu@lists.linux.dev, Joerg Roedel , Robin Murphy , Will Deacon , Alejandro Jimenez , Lu Baolu , Joerg Roedel , Josua Mayer , Kevin Tian , Pasha Tatashin , patches@lists.linux.dev, Samiullah Khawaja , Mostafa Saleh , stable@vger.kernel.org Subject: Re: [PATCH rc 1/5] iommu: Fix loss of errno on map failure for classic ops Message-ID: References: <0-v1-44b2fef88b25+d3-iommupt_map_rc_jgg@nvidia.com> <1-v1-44b2fef88b25+d3-iommupt_map_rc_jgg@nvidia.com> Precedence: bulk X-Mailing-List: iommu@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1-v1-44b2fef88b25+d3-iommupt_map_rc_jgg@nvidia.com> On Tue, May 12, 2026 at 01:46:13PM -0300, Jason Gunthorpe wrote: > A typo, likely from a rebase, inverted the condition and caused > errors to be lost. Fix it to be "if (ret)". > > This was breaking iommu_create_device_direct_mappings() on drivers > that don't use iommupt and don't fully set up their domain in > alloc_pages() (i.e., SMMUv2). In this case the first call of > iommu_create_device_direct_mappings() should fail due to the > incompletely initialized domain. Since it wrongly returns success, > the second call to iommu_create_device_direct_mappings() doesn't > happen and IOMMU_RESV_DIRECT is never set up. > > Cc: stable@vger.kernel.org > Fixes: d6c65b0fd621 ("iommupt: Avoid rewalking during map") > Reported-by: Josua Mayer > Closes: https://lore.kernel.org/all/321c2e57-6a17-4aef-ba42-d2ebd577e472@solid-run.com/ > Signed-off-by: Jason Gunthorpe Reviewed-by: Pranjal Shrivastava Thanks, Praan