From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43F45384CEC for ; Mon, 18 May 2026 18:55:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779130556; cv=none; b=dQXUQgPsNHyBksHjanRRZicxJrO53aWVLTJjanICjRVOYJDEpNGowyCQo0QRF2robnvVXVYgtG+hxpSu7+WHv2Y6gxOUrciKtTo/p0tNoY77VfFI7FdwDRIp8BwTshNSILmtKMKtrydxBaxBsNLDWfNCDqvl0ylJ8DGsnosebOQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779130556; c=relaxed/simple; bh=haAsUB2P2dMZXBWY/VxFwqzdDlbH/EE+xsFbEoz18JY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=P4COhwav4ieTGSVItgdX7iGqhAFFmgH963a2Ynj8MlyL5UDu6Vhy6afTW02TaGUHs0Oq9vuBePn9sby7WLT4emaCg+OzZ4aQSlEyEg69a5PM2w//ItDc+wCjbM7jQIK5smqxSo207vTI5V7dyh7JDDjwq0E5JmclU1pL7NrODok= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=XZ5qvCiu; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="XZ5qvCiu" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-2b46da8c48eso605ad.1 for ; Mon, 18 May 2026 11:55:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1779130555; x=1779735355; darn=lists.linux.dev; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=N8E7VNGYLDNKxW/Ot3tdafHEntRbQFW1KJ60umQhURs=; b=XZ5qvCiuDpYMrx8Ha+DH3S+NnZnoM0zF4yZU7wghZqrSQj0thNR/zF5DsF93AiBysu 5geCyNGyBkt6BxMst01yskwv3OBkgODnCdpiDOxIjeZZDgsbxIb+ChVp0atFSJuFa9Ue 6Tq88ITt593BKiZRDKj0Q7wuUyH8RQMXIGNfxAc0071z3yLOhBGOWf6GYsE51NiDsfvS z1XAVYN/qQ59dEPcq9Q58Sh0B1nLQyP9kSlDLLzx8MlhUuDZb+Wq+s7Gv4y/G7ZE1xTO KQCjIME+d4SgWtNHzdkXbaqTfubK4/kFykkQVPk50A4Yjug9s/9tSvAjgTeUR0gSx3Wd Urfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779130555; x=1779735355; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=N8E7VNGYLDNKxW/Ot3tdafHEntRbQFW1KJ60umQhURs=; b=BpB2F3CEyApTEcm/2rgX8EFGpTkwC9HLs9njHezewN/WyBru/6txE3R/WVwkSbv11R /oItxACG95pUB2zh2VJtxbd1d1Cj/gAlOGQbxP4Q+OB+TC4nG30sjHyH1a6Nx3a4urHT EcmBs1k5fSm5oUumcZGbTFwkW5HVfTbGpBAf53ot6IGqDE7xZMNmIJ3pwszJgQcNS6Ot WJ1+0RuaSjxFkJ8ewK7RtKGEEef38WbCKc3AtGejfpqHd57fUvkrdTdCh6Iw+HDuIAgw B4tUonG6wNLv+auF29hnWjkqcpXx5WvWX/8uQUaY/1ouC3PLEgkYJkBl0Yfqvug5svB9 cHFQ== X-Forwarded-Encrypted: i=1; AFNElJ+GfZolTZBvtH2QSLGh7uBp0uWw9VKXtrBMJF48DyAxb+HBn4dr7gz1IcdjRlP/quGK2ZJZeA==@lists.linux.dev X-Gm-Message-State: AOJu0Yz8PPhuCUqxcjCUu1XXCyxSpJfm1903qG552uqF1peVDd7IckSJ Dm0QB4e+38uiTa5zeJ4IUMsyjY5frlBtHB6oMqnnTl0lTp27mHF+ITuWs9kZmikVAA== X-Gm-Gg: Acq92OFdsHN+s7Duwxu4QNrsUFeIfMZrL52ySJpb/y/NqHPSR9iO47og1VzA7q0eu8g otGoCSH+m4j1Ru/xzFdv1lBevigmz4RAnp9R2sOWejg2N3qAsp6CA+4nsXHzTeSxYDxOR/WT5pv 61pwN9bvcUypUuPwmlTScWHxqekXZu/qQVHx8YnTfuvfVhgqxh9a8AL28L8hFs9akaO6/cJUvdn /yULVj5eN08L1+9p1y0r7uNHTGCDwas6gmXKzXZ9Q0aBwF1C6DBKvvxjkCbcnU6AnDWNOuy1Ysb ups/Td7l6IJ4lsSxJG9UVdWMMJmaWgdewaco7OkUvgOWfAamQL4tnAlk41TdvVAq+60mJZsYGZW errLTNs0uwxBQOpsXjJVj4pJrDZTdKU5YOhLRpvXQpkXFN89MsATNijTmm+d6nLUZFiBN8JdfBM gWg43LcBIlJaVGJQltJOhc2evBIIDIckM39S1FFrvYKIpEXKXxpvX92z/DF9afi6MoXLA5rg== X-Received: by 2002:a17:902:d512:b0:2bc:dc0b:ab29 with SMTP id d9443c01a7336-2bdb0109472mr3404845ad.0.1779130553814; Mon, 18 May 2026 11:55:53 -0700 (PDT) Received: from google.com (153.46.83.34.bc.googleusercontent.com. [34.83.46.153]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bd5d11c7f3sm154208605ad.70.2026.05.18.11.55.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2026 11:55:53 -0700 (PDT) Date: Mon, 18 May 2026 18:55:50 +0000 From: Samiullah Khawaja To: Pranjal Shrivastava Cc: David Woodhouse , Lu Baolu , Joerg Roedel , Will Deacon , Jason Gunthorpe , Robin Murphy , Kevin Tian , Alex Williamson , Shuah Khan , iommu@lists.linux.dev, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Saeed Mahameed , Adithya Jayachandran , Parav Pandit , Leon Romanovsky , William Tu , Pratyush Yadav , Pasha Tatashin , David Matlack , Andrew Morton , Chris Li , Vipin Sharma , YiFei Zhu Subject: Re: [PATCH v2 03/16] iommu: Implement IOMMU domain preservation Message-ID: References: <20260427175633.1978233-1-skhawaja@google.com> <20260427175633.1978233-4-skhawaja@google.com> Precedence: bulk X-Mailing-List: iommu@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: On Mon, May 18, 2026 at 01:13:49PM +0000, Pranjal Shrivastava wrote: >On Mon, Apr 27, 2026 at 05:56:20PM +0000, Samiullah Khawaja wrote: >> Add IOMMU domain ops that can be implemented by the IOMMU drivers if >> they support IOMMU domain preservation across liveupdate. The new IOMMU >> domain preserve, unpreserve and restore APIs call these ops to perform >> respective live update operations. >> >> Signed-off-by: Samiullah Khawaja >> --- >> drivers/iommu/liveupdate.c | 97 ++++++++++++++++++++++++++++++++ >> include/linux/iommu-liveupdate.h | 14 +++++ >> include/linux/iommu.h | 13 +++++ >> 3 files changed, 124 insertions(+) >> >> diff --git a/drivers/iommu/liveupdate.c b/drivers/iommu/liveupdate.c >> index a26099b145c3..f71f14518248 100644 >> --- a/drivers/iommu/liveupdate.c >> +++ b/drivers/iommu/liveupdate.c >> @@ -13,6 +13,9 @@ >> #include >> #include >> >> +#define iommu_max_objs_per_page(_array) \ >> + ((PAGE_SIZE - sizeof(struct iommu_array_hdr_ser)) / sizeof((_array)->objects[0])) >> + >> static void *iommu_liveupdate_restore_array(u64 array_phys) >> { >> struct iommu_array_hdr_ser *array_hdr; >> @@ -196,3 +199,97 @@ void iommu_liveupdate_unregister_flb(struct liveupdate_file_handler *handler) >> liveupdate_unregister_flb(handler, &iommu_flb); >> } >> EXPORT_SYMBOL(iommu_liveupdate_unregister_flb); >> + >> +static int alloc_object_ser(struct iommu_array_hdr_ser **curr_array_ptr, u64 max_objs) >> +{ >> + struct iommu_array_hdr_ser *curr_array = *curr_array_ptr; >> + struct iommu_array_hdr_ser *next_array; >> + >> + if (curr_array->nr_objects >= max_objs) { >> + next_array = kho_alloc_preserve(PAGE_SIZE); >> + if (IS_ERR(next_array)) >> + return PTR_ERR(next_array); >> + >> + curr_array->next_array_phys = virt_to_phys(next_array); >> + *curr_array_ptr = next_array; >> + curr_array = next_array; >> + } >> + >> + return curr_array->nr_objects++; >> +} >> + >> +static struct iommu_domain_ser *alloc_iommu_domain_ser(struct iommu_flb_obj *flb) >> +{ >> + int idx; >> + >> + idx = alloc_object_ser((struct iommu_array_hdr_ser **)&flb->curr_domain_array, > >Nit: Such type-casts could be brittle and risk strict-aliasing warnings >based on the compiler. > >Since alloc_object_ser only updates the top-level tracking pointer, we >can make this much cleaner by changing alloc_object_ser to take a >void curr_array_ptr. That way, we can pass (void )&flb->curr_domain_array >cleanly without the double-pointer type-punning. Something like: > >static int alloc_object_ser(void **curr_array_ptr, u64 max_objs) >{ > struct iommu_array_hdr_ser *curr_array = *curr_array_ptr; > struct iommu_array_hdr_ser *next_array; > > ... >} > >and we can pass it as: > >idx = alloc_object_ser((void **)&flb->curr_domain_array, > iommu_max_objs_per_page(flb->curr_domain_array)); > Agreed. I will update this (including other places). >> + iommu_max_objs_per_page(flb->curr_domain_array)); >> + if (idx < 0) >> + return ERR_PTR(idx); >> + >> + flb->curr_domain_array->objects[idx].hdr.ref_count = 1; >> + return &flb->curr_domain_array->objects[idx]; >> +} >> + >> +int iommu_domain_preserve(struct iommu_domain *domain, struct iommu_domain_ser **ser) >> +{ >> + struct iommu_domain_ser *domain_ser; >> + struct iommu_flb_obj *flb_obj; >> + int ret; >> + >> + if (!domain->ops->preserve) >> + return -EOPNOTSUPP; >> + >> + ret = liveupdate_flb_get_outgoing(&iommu_flb, (void **)&flb_obj); >> + if (ret) >> + return ret; >> + >> + guard(mutex)(&flb_obj->lock); >> + domain_ser = alloc_iommu_domain_ser(flb_obj); >> + if (IS_ERR(domain_ser)) >> + return PTR_ERR(domain_ser); >> + >> + ret = domain->ops->preserve(domain, domain_ser); >> + if (ret) { >> + domain_ser->hdr.deleted = true; > >Nit: This will become domain_ser->hdr.flags |= IOMMU_SER_FLAG_DELETED; >once we convert the bitfields in PATCH 2 to flags. Agreed. I think it is being discussed that bitfields are fine in the other thread, but I will switch it to flags for readibility anyway. > >> + return ret; >> + } >> + >> + domain->preserved_state = domain_ser; >> + *ser = domain_ser; >> + return 0; >> +} >> +EXPORT_SYMBOL_GPL(iommu_domain_preserve); >> + > >[...] > >> static inline bool iommu_is_dma_domain(struct iommu_domain *domain) >> @@ -752,6 +757,11 @@ struct iommu_ops { >> * specific mechanisms. >> * @set_pgtable_quirks: Set io page table quirks (IO_PGTABLE_QUIRK_*) >> * @free: Release the domain after use. >> + * @preserve: Preserve the iommu domain for liveupdate. >> + * Returns 0 on success, a negative errno on failure. >> + * @unpreserve: Unpreserve the iommu domain that was preserved earlier. >> + * @restore: Restore the iommu domain after liveupdate. >> + * Returns 0 on success, a negative errno on failure. >> */ >> struct iommu_domain_ops { >> int (*attach_dev)(struct iommu_domain *domain, struct device *dev, >> @@ -782,6 +792,9 @@ struct iommu_domain_ops { >> unsigned long quirks); >> >> void (*free)(struct iommu_domain *domain); >> + int (*preserve)(struct iommu_domain *domain, struct iommu_domain_ser *ser); >> + void (*unpreserve)(struct iommu_domain *domain, struct iommu_domain_ser *ser); >> + int (*restore)(struct iommu_domain *domain, struct iommu_domain_ser *ser); > >Nit: Should we add restore in the patch we implement it? The ops are implemented in iommupt (separate scope) and it is done after the iommu pages patch as that is also required for it. > >> }; > >With the above nits, > >Reviewed-by: Pranjal Shrivastava Thanks Pranjal. > >Thanks, >Praan Sami