From: Pranjal Shrivastava <praan@google.com>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: Jacob Pan <jacob.pan@linux.microsoft.com>,
linux-kernel@vger.kernel.org,
"iommu@lists.linux.dev" <iommu@lists.linux.dev>,
Alex Williamson <alex@shazbot.org>,
Joerg Roedel <joro@8bytes.org>,
Mostafa Saleh <smostafa@google.com>,
David Matlack <dmatlack@google.com>,
Robin Murphy <robin.murphy@arm.com>,
Nicolin Chen <nicolinc@nvidia.com>,
"Tian, Kevin" <kevin.tian@intel.com>, Yi Liu <yi.l.liu@intel.com>,
Baolu Lu <baolu.lu@linux.intel.com>,
Saurabh Sengar <ssengar@linux.microsoft.com>,
skhawaja@google.com, pasha.tatashin@soleen.com,
Will Deacon <will@kernel.org>
Subject: Re: [PATCH v9 1/6] iommufd: Support a HWPT without an iommu driver for noiommu
Date: Wed, 17 Jun 2026 10:59:14 +0000 [thread overview]
Message-ID: <ajJ-Ai1ruFINPMah@google.com> (raw)
In-Reply-To: <20260617000948.GA3577711@nvidia.com>
On Tue, Jun 16, 2026 at 09:09:48PM -0300, Jason Gunthorpe wrote:
> On Tue, Jun 16, 2026 at 08:18:06PM +0000, Pranjal Shrivastava wrote:
> > > diff --git a/drivers/iommu/iommufd/Kconfig b/drivers/iommu/iommufd/Kconfig
> > > index 455bac0351f2..6c3bea83631b 100644
> > > --- a/drivers/iommu/iommufd/Kconfig
> > > +++ b/drivers/iommu/iommufd/Kconfig
> > > @@ -16,6 +16,18 @@ config IOMMUFD
> > > If you don't know what to do here, say N.
> > >
> > > if IOMMUFD
> > > +config IOMMUFD_NOIOMMU
> > > + bool
> > > + depends on !GENERIC_ATOMIC64 # IOMMU_PT_AMDV1 requires cmpxchg64
> >
> > Nit: Should we explicitly depend on 64BIT here?
> > I see further in the patch we assume 64-bit addresses:
> >
> > + cfg.common.hw_max_vasz_lg2 = 64;
> > + cfg.common.hw_max_oasz_lg2 = 52;
>
> That will work fine on 32 bit, it is how all the drivers are being setup.
Ah my bad, I misundersood the GENERIC_ATOMIC64 config. I agree.
Thanks,
Praan
next prev parent reply other threads:[~2026-06-17 10:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-11 17:26 [PATCH v9 0/6] iommufd: Enable noiommu mode for cdev Jacob Pan
2026-06-11 17:26 ` [PATCH v9 1/6] iommufd: Support a HWPT without an iommu driver for noiommu Jacob Pan
2026-06-16 6:00 ` Yi Liu
2026-06-16 20:18 ` Pranjal Shrivastava
2026-06-17 0:09 ` Jason Gunthorpe
2026-06-17 10:59 ` Pranjal Shrivastava [this message]
2026-06-11 17:26 ` [PATCH v9 2/6] iommufd: Move igroup allocation to a function Jacob Pan
2026-06-16 20:23 ` Pranjal Shrivastava
2026-06-11 17:26 ` [PATCH v9 3/6] iommufd: Allow binding to a noiommu device Jacob Pan
2026-06-16 20:38 ` Pranjal Shrivastava
2026-06-11 17:26 ` [PATCH v9 4/6] iommufd: Add an ioctl to query PA from IOVA for noiommu mode Jacob Pan
2026-06-16 6:00 ` Yi Liu
2026-06-16 21:40 ` Pranjal Shrivastava
2026-06-11 17:26 ` [PATCH v9 5/6] vfio: Enable cdev noiommu mode under iommufd Jacob Pan
2026-06-11 23:14 ` Alex Williamson
2026-06-16 6:00 ` Yi Liu
2026-06-16 22:03 ` Pranjal Shrivastava
2026-06-11 17:26 ` [PATCH v9 6/6] Documentation: Update VFIO NOIOMMU mode Jacob Pan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ajJ-Ai1ruFINPMah@google.com \
--to=praan@google.com \
--cc=alex@shazbot.org \
--cc=baolu.lu@linux.intel.com \
--cc=dmatlack@google.com \
--cc=iommu@lists.linux.dev \
--cc=jacob.pan@linux.microsoft.com \
--cc=jgg@nvidia.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolinc@nvidia.com \
--cc=pasha.tatashin@soleen.com \
--cc=robin.murphy@arm.com \
--cc=skhawaja@google.com \
--cc=smostafa@google.com \
--cc=ssengar@linux.microsoft.com \
--cc=will@kernel.org \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox