From: Markus Elfring <Markus.Elfring@web.de>
To: "Tang Bin" <tangbin@cmss.chinamobile.com>,
iommu@lists.linux-foundation.org, linux-arm-msm@vger.kernel.org,
"Andy Gross" <agross@kernel.org>,
"Bjorn Andersson" <bjorn.andersson@linaro.org>,
"Jörg Rödel" <joro@8bytes.org>, "Rob Clark" <robdclark@gmail.com>
Cc: Dejin Zheng <zhengdejin5@gmail.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] iommu/qcom: Fix local_base status check
Date: Sun, 19 Apr 2020 15:10:33 +0200 [thread overview]
Message-ID: <b07d3b02-bf96-fd73-8333-a1104da9ae47@web.de> (raw)
In-Reply-To: <73736017-cae3-1c2a-dcf4-d771d0f3bbbf@web.de>
> …
>> +++ b/drivers/iommu/qcom_iommu.c
>> @@ -813,8 +813,11 @@ static int qcom_iommu_device_probe(struct platform_device *pdev)
>> qcom_iommu->dev = dev;
>>
>> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
…
>> qcom_iommu->local_base = devm_ioremap_resource(dev, res);
…
> Please take another look at a corresponding usage example.
I would like to point another possibility out for desirable software evolution.
How do you think about to call a “known” wrapper function instead?
devm_platform_get_and_ioremap_resource
https://elixir.bootlin.com/linux/v5.7-rc1/source/drivers/base/platform.c#L66
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/log/drivers/base/platform.c
Regards,
Markus
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2020-04-19 13:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-19 12:32 [PATCH v2] iommu/qcom: Fix local_base status check Markus Elfring
2020-04-19 13:10 ` Markus Elfring [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-04-18 13:47 [PATCH v2]iommu/qcom:fix " Tang Bin
2020-04-20 4:52 ` Bjorn Andersson
2020-05-01 11:37 ` Joerg Roedel
2020-05-01 13:54 ` Tang Bin
2020-04-03 17:20 [PATCH v2] iommu/qcom: Fix " Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b07d3b02-bf96-fd73-8333-a1104da9ae47@web.de \
--to=markus.elfring@web.de \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robdclark@gmail.com \
--cc=tangbin@cmss.chinamobile.com \
--cc=zhengdejin5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox