From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 13DC77F for ; Thu, 4 Aug 2022 02:06:05 +0000 (UTC) X-UUID: aeed8feef5b84462b46d81377d88269b-20220804 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=cYdEvNcIoNtrzK+qZCUsxemvvUjcF/0Vx9OtE4IjY94=; b=nei6QIdysYvtxyJj88Dr1HZCf6DUyV/6Bst9/M8vYjgh2YdUIakdnjTAzMjNpVHFZ0DY/KDo7OfPO3xRj/mxsZKpKnQdRF49Jc5cHTLK2ebOJS/u08G19SUArqRPEXmYRSgAO9qM1n7iFj0/Evd1wV9kLwtaOvM5Y8FByvds0BI=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.8,REQID:e11df82c-604d-4cbe-b247-8fa79a126bcd,OB:0,LO B:0,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,RULE:Release_Ham,ACTI ON:release,TS:0 X-CID-META: VersionHash:0f94e32,CLOUDID:20e62bd1-841b-4e95-ad42-8f86e18f54fc,C OID:IGNORED,Recheck:0,SF:nil,TC:nil,Content:0,EDM:-3,IP:nil,URL:0,File:nil ,QS:nil,BEC:nil,COL:0 X-UUID: aeed8feef5b84462b46d81377d88269b-20220804 Received: from mtkexhb02.mediatek.inc [(172.21.101.103)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1062994188; Thu, 04 Aug 2022 10:05:54 +0800 Received: from mtkmbs11n1.mediatek.inc (172.21.101.186) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.3; Thu, 4 Aug 2022 10:05:52 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkmbs11n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.15 via Frontend Transport; Thu, 4 Aug 2022 10:05:52 +0800 Message-ID: Subject: Re: [PATCH v4 06/20] dt-bindings: power: mediatek: Add bindings for MediaTek SCPSYS From: Tinghan Shen To: Krzysztof Kozlowski , Yong Wu , Joerg Roedel , Will Deacon , Robin Murphy , Rob Herring , Krzysztof Kozlowski , Lee Jones , "Matthias Brugger" , AngeloGioacchino Del Regno , MandyJH Liu CC: , , , , , Date: Thu, 4 Aug 2022 10:05:52 +0800 In-Reply-To: References: <20220729063208.16799-1-tinghan.shen@mediatek.com> <20220729063208.16799-7-tinghan.shen@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 Precedence: bulk X-Mailing-List: iommu@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N On Tue, 2022-08-02 at 10:58 +0200, Krzysztof Kozlowski wrote: > On 29/07/2022 08:31, Tinghan Shen wrote: > > The System Control Processor System (SCPSYS) has several power > > management related tasks in the system. Add the bindings for it. > > > > Signed-off-by: Tinghan Shen > > Thank you for your patch. There is something to discuss/improve. > > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + #include > > + #include > > + > > + syscon@10006000 { > > + compatible = "mediatek,mt8195-scpsys", "syscon", "simple-mfd"; > > + reg = <0x10006000 0x100>; > > + > > + spm: power-controller { > > + compatible = "mediatek,mt8195-power-controller"; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + #power-domain-cells = <1>; > > + > > + /* sample of power domain nodes */ > > + power-domain@MT8195_POWER_DOMAIN_PCIE_PHY { > > + reg = ; > > Wrong indentation. I missed these lines... I'll update in the next version. Best regards, TingHna