From: John Garry <john.garry@huawei.com>
To: Lu Baolu <baolu.lu@linux.intel.com>,
Russell King <rmk+kernel@armlinux.org.uk>,
Joerg Roedel <joro@8bytes.org>
Cc: iommu@lists.linux-foundation.org
Subject: Re: [PATCH] iommu: silence iommu group prints
Date: Fri, 28 Feb 2020 09:33:40 +0000 [thread overview]
Message-ID: <b4029a97-ac80-484f-9d01-d7f4eb174cdd@huawei.com> (raw)
In-Reply-To: <f0fc4c8c-4475-e77f-da6d-e068e7993568@linux.intel.com>
On 28/02/2020 02:16, Lu Baolu wrote:
> Hi,
>
> On 2020/2/27 19:57, Russell King wrote:
>> On the LX2160A, there are lots (about 160) of IOMMU messages produced
>> during boot; this is excessive. Reduce the severity of these messages
>> to debug level.
>>
>> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
>> ---
>> drivers/iommu/iommu.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
>> index 3ead597e1c57..304281ec623b 100644
>> --- a/drivers/iommu/iommu.c
>> +++ b/drivers/iommu/iommu.c
>> @@ -741,7 +741,7 @@ int iommu_group_add_device(struct iommu_group
>> *group, struct device *dev)
>> trace_add_device_to_group(group->id, dev);
>> - dev_info(dev, "Adding to iommu group %d\n", group->id);
>> + dev_dbg(dev, "Adding to iommu group %d\n", group->id);
>
> I'm not strongly against this. But to me this message seems to be a good
> indicator that a device was probed successfully by the iommu subsystem.
> Keeping it in the default kernel message always helps to the kernel
> debugging.
>
I would tend to agree.
> Best regards,
> baolu
> _______________________________________________
> iommu mailing list
> iommu@lists.linux-foundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/iommu
> .
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2020-02-28 9:33 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 11:57 [PATCH] iommu: silence iommu group prints Russell King
2020-02-27 13:44 ` Robin Murphy
2020-02-27 13:48 ` Russell King - ARM Linux admin
2020-02-27 18:19 ` Robin Murphy
2020-02-27 19:00 ` Russell King - ARM Linux admin
2020-02-28 2:16 ` Lu Baolu
2020-02-28 9:33 ` John Garry [this message]
2020-02-28 10:06 ` Russell King - ARM Linux admin
2020-02-28 18:32 ` Robin Murphy
2020-03-02 11:48 ` Laurentiu Tudor
2020-03-03 14:18 ` Laurentiu Tudor
2020-03-03 15:49 ` Russell King - ARM Linux admin
2020-03-03 15:55 ` Laurentiu Tudor
2020-03-03 22:17 ` Russell King - ARM Linux admin
2020-03-04 8:56 ` Laurentiu Tudor
2020-03-04 9:33 ` Russell King - ARM Linux admin
2020-03-04 9:42 ` Laurentiu Tudor
2020-03-04 9:51 ` Russell King - ARM Linux admin
2020-03-04 9:56 ` Laurentiu Tudor
2020-03-04 10:07 ` Russell King - ARM Linux admin
2020-03-04 10:33 ` Laurentiu Tudor
2020-03-04 10:52 ` Russell King - ARM Linux admin
2020-03-04 11:26 ` Laurentiu Tudor
2020-03-02 15:44 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4029a97-ac80-484f-9d01-d7f4eb174cdd@huawei.com \
--to=john.garry@huawei.com \
--cc=baolu.lu@linux.intel.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox