From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5722C63777 for ; Tue, 1 Dec 2020 01:21:24 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 728B9206ED for ; Tue, 1 Dec 2020 01:21:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 728B9206ED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 281AA8665E; Tue, 1 Dec 2020 01:21:24 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aBdo0UrmBtjA; Tue, 1 Dec 2020 01:21:23 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by fraxinus.osuosl.org (Postfix) with ESMTP id 6DEEA86644; Tue, 1 Dec 2020 01:21:23 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 621CDC0859; Tue, 1 Dec 2020 01:21:23 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 94B08C0052 for ; Tue, 1 Dec 2020 01:21:21 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 8AF28869FE for ; Tue, 1 Dec 2020 01:21:21 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8oRYG6AWXV+S for ; Tue, 1 Dec 2020 01:21:20 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by hemlock.osuosl.org (Postfix) with ESMTPS id B416B86747 for ; Tue, 1 Dec 2020 01:21:20 +0000 (UTC) IronPort-SDR: jRqcAtRNrfFX0TnkII6hll56x9Ka4qrprfxrJ8I0vcJj6jBuEOF3USJEWsDxnx0vERQarXbS5Q JauGz4n15DQw== X-IronPort-AV: E=McAfee;i="6000,8403,9821"; a="257452523" X-IronPort-AV: E=Sophos;i="5.78,382,1599548400"; d="scan'208";a="257452523" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2020 17:21:20 -0800 IronPort-SDR: ASvIKUZncV5eu+9IUkqE2q2lrUVQ+fmHbeDeeZI8EOZ7C/yMzaYkawLxgFpLRTvdXYqVt1pw22 5bmXeasEoD8Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,382,1599548400"; d="scan'208";a="434475417" Received: from allen-box.sh.intel.com (HELO [10.239.159.28]) ([10.239.159.28]) by fmsmga001.fm.intel.com with ESMTP; 30 Nov 2020 17:21:16 -0800 Subject: Re: [PATCH v2 1/1] vfio/type1: Add vfio_group_domain() To: Alex Williamson References: <20201126012726.1185171-1-baolu.lu@linux.intel.com> <20201130135725.70fdf17f@w520.home> From: Lu Baolu Message-ID: Date: Tue, 1 Dec 2020 09:13:54 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201130135725.70fdf17f@w520.home> Content-Language: en-US Cc: Jean-Philippe Brucker , Kevin Tian , Dave Jiang , Ashok Raj , kvm@vger.kernel.org, Will Deacon , Cornelia Huck , linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, Robin Murphy X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" Hi Alex, Thanks a lot for your review comments. On 12/1/20 4:57 AM, Alex Williamson wrote: > On Thu, 26 Nov 2020 09:27:26 +0800 > Lu Baolu wrote: > >> Add the API for getting the domain from a vfio group. This could be used >> by the physical device drivers which rely on the vfio/mdev framework for >> mediated device user level access. The typical use case like below: >> >> unsigned int pasid; >> struct vfio_group *vfio_group; >> struct iommu_domain *iommu_domain; >> struct device *dev = mdev_dev(mdev); >> struct device *iommu_device = mdev_get_iommu_device(dev); >> >> if (!iommu_device || >> !iommu_dev_feature_enabled(iommu_device, IOMMU_DEV_FEAT_AUX)) >> return -EINVAL; >> >> vfio_group = vfio_group_get_external_user_from_dev(dev);(dev); >> if (IS_ERR_OR_NULL(vfio_group)) >> return -EFAULT; >> >> iommu_domain = vfio_group_domain(vfio_group); >> if (IS_ERR_OR_NULL(iommu_domain)) { >> vfio_group_put_external_user(vfio_group); >> return -EFAULT; >> } >> >> pasid = iommu_aux_get_pasid(iommu_domain, iommu_device); >> if (pasid < 0) { >> vfio_group_put_external_user(vfio_group); >> return -EFAULT; >> } >> >> /* Program device context with pasid value. */ >> ... >> >> Signed-off-by: Lu Baolu >> --- >> drivers/vfio/vfio.c | 18 ++++++++++++++++++ >> drivers/vfio/vfio_iommu_type1.c | 23 +++++++++++++++++++++++ >> include/linux/vfio.h | 3 +++ >> 3 files changed, 44 insertions(+) >> >> Change log: >> - v1: https://lore.kernel.org/linux-iommu/20201112022407.2063896-1-baolu.lu@linux.intel.com/ >> - Changed according to comments @ https://lore.kernel.org/linux-iommu/20201116125631.2d043fcd@w520.home/ >> >> diff --git a/drivers/vfio/vfio.c b/drivers/vfio/vfio.c >> index 2151bc7f87ab..62c652111c88 100644 >> --- a/drivers/vfio/vfio.c >> +++ b/drivers/vfio/vfio.c >> @@ -2331,6 +2331,24 @@ int vfio_unregister_notifier(struct device *dev, enum vfio_notify_type type, >> } >> EXPORT_SYMBOL(vfio_unregister_notifier); >> >> +struct iommu_domain *vfio_group_domain(struct vfio_group *group) >> +{ >> + struct vfio_container *container; >> + struct vfio_iommu_driver *driver; >> + >> + if (!group) >> + return ERR_PTR(-EINVAL); >> + >> + container = group->container; >> + driver = container->iommu_driver; >> + if (likely(driver && driver->ops->group_domain)) >> + return driver->ops->group_domain(container->iommu_data, >> + group->iommu_group); >> + else >> + return ERR_PTR(-ENOTTY); >> +} >> +EXPORT_SYMBOL(vfio_group_domain); > > > _GPL? I don't see that there's a way for a driver to get the > vfio_group pointer that's not already _GPL. > It should be _GPL. Will fix it. > >> + >> /** >> * Module/class support >> */ >> diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu_type1.c >> index 67e827638995..783f18f21b95 100644 >> --- a/drivers/vfio/vfio_iommu_type1.c >> +++ b/drivers/vfio/vfio_iommu_type1.c >> @@ -2980,6 +2980,28 @@ static int vfio_iommu_type1_dma_rw(void *iommu_data, dma_addr_t user_iova, >> return ret; >> } >> >> +static void *vfio_iommu_type1_group_domain(void *iommu_data, >> + struct iommu_group *iommu_group) >> +{ >> + struct vfio_iommu *iommu = iommu_data; >> + struct iommu_domain *domain = NULL; >> + struct vfio_domain *d; >> + >> + if (!iommu || !iommu_group) >> + return ERR_PTR(-EINVAL); >> + >> + mutex_lock(&iommu->lock); >> + list_for_each_entry(d, &iommu->domain_list, next) { >> + if (find_iommu_group(d, iommu_group)) { >> + domain = d->domain; >> + break; >> + } >> + } >> + mutex_unlock(&iommu->lock); >> + >> + return domain; >> +} > > > Why does this return void* rather than struct iommu_domain*, and why > does the error case return an ERR_PTR but the not-found case returns > NULL? I will change it to return iommu_domain* and return an error number for the not-found case. Best regards, baolu > Thanks, > > Alex > > >> + >> static const struct vfio_iommu_driver_ops vfio_iommu_driver_ops_type1 = { >> .name = "vfio-iommu-type1", >> .owner = THIS_MODULE, >> @@ -2993,6 +3015,7 @@ static const struct vfio_iommu_driver_ops vfio_iommu_driver_ops_type1 = { >> .register_notifier = vfio_iommu_type1_register_notifier, >> .unregister_notifier = vfio_iommu_type1_unregister_notifier, >> .dma_rw = vfio_iommu_type1_dma_rw, >> + .group_domain = vfio_iommu_type1_group_domain, >> }; >> >> static int __init vfio_iommu_type1_init(void) >> diff --git a/include/linux/vfio.h b/include/linux/vfio.h >> index 38d3c6a8dc7e..a0613a6f21cc 100644 >> --- a/include/linux/vfio.h >> +++ b/include/linux/vfio.h >> @@ -90,6 +90,7 @@ struct vfio_iommu_driver_ops { >> struct notifier_block *nb); >> int (*dma_rw)(void *iommu_data, dma_addr_t user_iova, >> void *data, size_t count, bool write); >> + void *(*group_domain)(void *iommu_data, struct iommu_group *group); >> }; >> >> extern int vfio_register_iommu_driver(const struct vfio_iommu_driver_ops *ops); >> @@ -126,6 +127,8 @@ extern int vfio_group_unpin_pages(struct vfio_group *group, >> extern int vfio_dma_rw(struct vfio_group *group, dma_addr_t user_iova, >> void *data, size_t len, bool write); >> >> +extern struct iommu_domain *vfio_group_domain(struct vfio_group *group); >> + >> /* each type has independent events */ >> enum vfio_notify_type { >> VFIO_IOMMU_NOTIFY = 0, > _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu