From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6E7CFC433FE for ; Tue, 7 Dec 2021 02:34:22 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 2290B41C6C; Tue, 7 Dec 2021 02:34:22 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id w7VcyHNXZzzi; Tue, 7 Dec 2021 02:34:21 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp4.osuosl.org (Postfix) with ESMTPS id 2C4AD41C14; Tue, 7 Dec 2021 02:34:21 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 094C3C001E; Tue, 7 Dec 2021 02:34:21 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 0E9A3C0012 for ; Tue, 7 Dec 2021 02:34:20 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id EE13441C16 for ; Tue, 7 Dec 2021 02:34:19 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vr3NLkCUmduT for ; Tue, 7 Dec 2021 02:34:19 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by smtp4.osuosl.org (Postfix) with ESMTPS id 6099E41C14 for ; Tue, 7 Dec 2021 02:34:19 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10190"; a="218160237" X-IronPort-AV: E=Sophos;i="5.87,293,1631602800"; d="scan'208";a="218160237" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Dec 2021 18:34:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,293,1631602800"; d="scan'208";a="515056584" Received: from allen-box.sh.intel.com (HELO [10.239.159.118]) ([10.239.159.118]) by orsmga008.jf.intel.com with ESMTP; 06 Dec 2021 18:34:11 -0800 Subject: Re: [PATCH v3 18/18] drm/tegra: Use the iommu dma_owner mechanism To: Jason Gunthorpe References: <20211206015903.88687-1-baolu.lu@linux.intel.com> <20211206015903.88687-19-baolu.lu@linux.intel.com> <20211206124033.GY4670@nvidia.com> From: Lu Baolu Message-ID: Date: Tue, 7 Dec 2021 10:34:04 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211206124033.GY4670@nvidia.com> Content-Language: en-US Cc: Stuart Yoder , rafael@kernel.org, David Airlie , linux-pci@vger.kernel.org, Thierry Reding , Diana Craciun , Dmitry Osipenko , Will Deacon , Ashok Raj , Jonathan Hunter , Christoph Hellwig , Kevin Tian , Chaitanya Kulkarni , Alex Williamson , kvm@vger.kernel.org, Bjorn Helgaas , Dan Williams , Greg Kroah-Hartman , Cornelia Huck , linux-kernel@vger.kernel.org, Li Yang , iommu@lists.linux-foundation.org, Jacob jun Pan , Daniel Vetter , Robin Murphy X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On 12/6/21 8:40 PM, Jason Gunthorpe wrote: > On Mon, Dec 06, 2021 at 09:59:03AM +0800, Lu Baolu wrote: > >> @@ -941,48 +944,44 @@ int host1x_client_iommu_attach(struct host1x_client *client) >> * not the shared IOMMU domain, don't try to attach it to a different >> * domain. This allows using the IOMMU-backed DMA API. >> */ >> - if (domain && domain != tegra->domain) >> + client->group = NULL; >> + if (!client->dev->iommu_group || (domain && domain != tegra->domain)) >> + return iommu_device_set_dma_owner(client->dev, >> + DMA_OWNER_DMA_API, NULL); >> + >> + if (!tegra->domain) >> return 0; > > This if should be removed completely now > > Jason > Sure. Best regards, baolu _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu