From: Lu Baolu <baolu.lu@linux.intel.com>
To: Adam Zerella <adam.zerella@gmail.com>
Cc: iommu@lists.linux-foundation.org, dwmw2@infradead.org
Subject: Re: [PATCH] iommu/vt-d: Make function signatures static
Date: Sat, 7 Sep 2019 20:10:14 +0800 [thread overview]
Message-ID: <ba8d4792-3b62-98a8-31d8-74a08be2f983@linux.intel.com> (raw)
In-Reply-To: <20190907064933.15277-1-adam.zerella@gmail.com>
Hi,
On 9/7/19 2:49 PM, Adam Zerella wrote:
> warning: symbol 'intel_iommu_gfx_mapped' was not declared. Should it be static?
> warning: symbol 'intel_iommu_ops' was not declared. Should it be static?
>
> Squash a couple of Sparse warnings by making these symbols static.
>
> Signed-off-by: Adam Zerella <adam.zerella@gmail.com>
> ---
> drivers/iommu/intel-iommu.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c
> index 12d094d08c0a..28134891fa9c 100644
> --- a/drivers/iommu/intel-iommu.c
> +++ b/drivers/iommu/intel-iommu.c
> @@ -365,7 +365,7 @@ static int iommu_identity_mapping;
> #define IDENTMAP_GFX 2
> #define IDENTMAP_AZALIA 4
>
> -int intel_iommu_gfx_mapped;
> +static int intel_iommu_gfx_mapped;
> EXPORT_SYMBOL_GPL(intel_iommu_gfx_mapped);
It's hard to understand this. This symbol is exported and used in the
graphic driver. How could it be static?
>
> #define DUMMY_DEVICE_DOMAIN_INFO ((struct device_domain_info *)(-1))
> @@ -397,7 +397,7 @@ int for_each_device_domain(int (*fn)(struct device_domain_info *info,
> return 0;
> }
>
> -const struct iommu_ops intel_iommu_ops;
> +static const struct iommu_ops intel_iommu_ops;
Ditto. This is used in dmar.c.
Best regards,
Baolu
>
> static bool translation_pre_enabled(struct intel_iommu *iommu)
> {
> @@ -5613,7 +5613,7 @@ static bool intel_iommu_is_attach_deferred(struct iommu_domain *domain,
> return dev->archdata.iommu == DEFER_DEVICE_DOMAIN_INFO;
> }
>
> -const struct iommu_ops intel_iommu_ops = {
> +static const struct iommu_ops intel_iommu_ops = {
> .capable = intel_iommu_capable,
> .domain_alloc = intel_iommu_domain_alloc,
> .domain_free = intel_iommu_domain_free,
>
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2019-09-07 12:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-07 6:49 [PATCH] iommu/vt-d: Make function signatures static Adam Zerella
2019-09-07 12:10 ` Lu Baolu [this message]
2019-09-10 8:15 ` Joerg Roedel
2019-09-10 13:06 ` Qian Cai
2019-09-10 14:44 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba8d4792-3b62-98a8-31d8-74a08be2f983@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=adam.zerella@gmail.com \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox