Linux IOMMU Development
 help / color / mirror / Atom feed
From: Sven Peter <sven@kernel.org>
To: Janne Grunau <j@jannau.net>,
	Alyssa Rosenzweig <alyssa@rosenzweig.io>,
	Neal Gompa <neal@gompa.dev>, Joerg Roedel <joro@8bytes.org>,
	Will Deacon <will@kernel.org>,
	Robin Murphy <robin.murphy@arm.com>
Cc: asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
	iommu@lists.linux.dev, linux-kernel@vger.kernel.org,
	Hector Martin <marcan@marcan.st>
Subject: Re: [PATCH 1/3] iommu: apple-dart: Make the hw register fields u32s
Date: Sat, 16 Aug 2025 15:51:39 +0200	[thread overview]
Message-ID: <bbfe3c37-db5d-4860-b3ec-546975304426@kernel.org> (raw)
In-Reply-To: <20250814-apple-dart-4levels-v1-1-db2214a78c08@jannau.net>

On 14.08.25 10:40, Janne Grunau wrote:
> From: Hector Martin <marcan@marcan.st>
> 
> The registers are 32-bit and the offsets definitely don't need 64 bits
> either, these should've been u32s.
> 
> Signed-off-by: Hector Martin <marcan@marcan.st>
> Signed-off-by: Janne Grunau <j@jannau.net>
> ---

The commit description should start with iommu/apple-dart to keep 
consistent with the subsystem style. With that:

Reviewed-by: Sven Peter <sven@kernel.org>



Thanks,

Sven


  reply	other threads:[~2025-08-16 13:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-14  8:40 [PATCH 0/3] iommu: apple-dart: Four level page table support Janne Grunau
2025-08-14  8:40 ` [PATCH 1/3] iommu: apple-dart: Make the hw register fields u32s Janne Grunau
2025-08-16 13:51   ` Sven Peter [this message]
2025-08-14  8:40 ` [PATCH 2/3] iommu: io-pgtable: Add 4-level page table support Janne Grunau
2025-08-16 14:02   ` Sven Peter
2025-08-14  8:40 ` [PATCH 3/3] iommu: apple-dart: " Janne Grunau
2025-08-16 13:50   ` Sven Peter
2025-08-16 14:19     ` Janne Grunau
2025-08-16 15:26       ` Sven Peter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bbfe3c37-db5d-4860-b3ec-546975304426@kernel.org \
    --to=sven@kernel.org \
    --cc=alyssa@rosenzweig.io \
    --cc=asahi@lists.linux.dev \
    --cc=iommu@lists.linux.dev \
    --cc=j@jannau.net \
    --cc=joro@8bytes.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcan@marcan.st \
    --cc=neal@gompa.dev \
    --cc=robin.murphy@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox