Re: [PATCH 1/3] dt-bindings: mediatek: mt8188: Add binding for MM & INFRA IOMMU

[Chengci.Xu <chengci.xu@mediatek.com>]

On Thu, 2022-08-18 at 10:42 +0300, Krzysztof Kozlowski wrote:
> On 18/08/2022 10:26, Chengci.Xu wrote:
> > > >      then:
> > > >        required:
> > > > diff --git a/include/dt-bindings/memory/mt8188-memory-port.h
> > > >  b/include/dt-bindings/memory/mt8188-memory-port.h
> > > > new file mode 100644
> > > > index 000000000000..612fd366c3a7
> > > > --- /dev/null
> > > > +++ b/include/dt-bindings/memory/mt8188-memory-port.h
> > > 
> > > Use vendor prefix in filename, so mediatek,mt8188-memory-port.h
> > 
> > Is this a new mandatory rules to add a vendor prefix in dt-bindings
> > file name? we have never add a vendor prefix before.
> > 
> > If possible, we'd like not to use vendor prefix for the consistency
> > of
> > fliename's format(mtxxxx-memory-port.h).
> > Such as "mt8195-memory-port.h" and "mt8186-memory-port.h".
> 
> That's a generic rule, although loosely applied. The consistency is
> rather to have a vendor prefix everywhere. Why Mediatek should have
> an
> exception?
> 

Thank you for sharing that generic rule and we will rename the file to 
"mediatek,mt8188-memory-port.h" in th coming next version.

> Best regards,
> Krzysztof
> 

Best regards,
Chengci Xu