From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 18F871E51FB for ; Mon, 14 Apr 2025 20:45:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744663509; cv=none; b=KpFHi5BXokAYZorg3A2soGvpY8ob3X9MIAhJy7yu0uUVjETsog0rdAozPgQemANn438KWGtv+HpI3p8EyqlpIzi9AmbmA8F1IfCu/sLE5kX9k0Kcn8neIRNJlHFHy+AHQPFUzVL+1PC6eJV1s+/27NcUcaJ35NQz5sqbyvx/d+8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744663509; c=relaxed/simple; bh=zWsdiw+TnJkpRWJoGIEhDbM9jVc3PLjahi1iBg9BPKo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=iM+UjD9NrqnGxK9YEz468daLsfeeNvMX2kBUNvNJQ92gjODn/B/lBRlqXQrFeAIOy6V3ShbbxspvNLQnHdYqpMAD1EDSrITaUtjyfUY8yvVZ4pQ7ncafYT6sKfY/OZ/067wkWxNQjcO9tCYmfcoLdlXgadUlsAhWQLFROjytEsQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=KBxCIJWE; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="KBxCIJWE" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 53EKeZWf009493 for ; Mon, 14 Apr 2025 20:45:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 8GpvC2xMf26mIWpkQqHlnNwAhWALEdfs8GLwqb4OfI8=; b=KBxCIJWEzDpTzj4J XjyWl8fUJsYhEsbotApe19vWNG1m0Yvs7M1ROZt8nJk3KhDcHY42mF/oxvQ1UPZ9 YqAZf1nQ3GWl0r26lWtz8/zsBZqO7tSbFiRyV5KHmpdZOXJGzNkGfypP4TA2Hehy dND01cfjyEO5NGuwOieSKvNsS1KpqPE/ZuBpZiRTXKquifUmwGsMUheDJ8wyc8g0 4g9BEWhO4vSGavr7e/V24EUFWGPKyJSGiclYyx1iUY4aIfC0MNUnRjEHm70jFM8L EjpHugjS/PPy3aPlKeHuaEW+RLdkCOVYAOvZ+y5KTAMCOwgQ5HFjYQwNJjIKwn2m qzQqFw== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 45ygd6ds4c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 14 Apr 2025 20:45:07 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-7c547ab8273so53787785a.3 for ; Mon, 14 Apr 2025 13:45:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744663506; x=1745268306; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8GpvC2xMf26mIWpkQqHlnNwAhWALEdfs8GLwqb4OfI8=; b=t3YaKh0nECp/tllhV/yq6w21875UUYG2ypskkxQoxEpYCsEDZI5lyJKTsjUcpLU4L9 /LXCMcX5xP5Tn0+AROl+QOaOETtL4ej3F7Dl07BfOxgYmDLnNQ65W+jGZQRrRHO9L5Jm HlScZqyfoZrR76v6fH4s4zrTu+fOceIWSCHY0L9JCTI6dcvTUUELb/gFgFbrIFmObVBS 4ZBCl000uV3ZL632vZl5Cgx/r6bxPYVd/eV+lDP165/49wFiYEKB14kQTgbJKX68bZxj +wghMPVhcyo47b6PWs6sxJxt4Aw6MvC8ff7sUZOa1lYgmpR0jZqzSFYtBWt/iTlAsOSs lIXg== X-Forwarded-Encrypted: i=1; AJvYcCX9Y9y7KIYG8ZrEJG6NArGTZP2xQVJftNwj31uYKV7v3MnDLgB3IgOFng9N3iwMJPAAAOLBwQ==@lists.linux.dev X-Gm-Message-State: AOJu0YzATCcK8Wdh1DIncS3N2hybdAOJ9jfrPyCumLK3nUc+PSB1EJNM z04jrEFfd4FltmA7/a34BWbjvG4lUchJRKZO1AYtnVSs27fRg94BHjzV6Fg4wxj5OqowEdYiV/2 fjcawUZC+l+yUq0Q8ac7TTicZzdroZLSKjpMBn5uAMbagCqotDzH39Q== X-Gm-Gg: ASbGncvDGQ39gXvlxZuDLQ9mh172xCcFnfRH7EQ2+V9dkg8osv93bsLVKs2j1cyFtwP KIk+6SQv7H3EGMxwqEted+oKijgiApzJt3P0aNwgkgU9uXBQRfl2zd3Rc0q1/aWOWdNZ8nvgC7L CAWbb0cqqSzrfYuxab4E0oAyyV2HARJJffIiLElN02GEprqWVylnN/r+LVM7HGUmgpxIJlzAaHN iBb+DpWNQ0dnjMf+E/vb7ad6E2/qk09ulHaM9rG5hubRajwccujlVu+fdQg57prZiQwFg0DyWUd SV/UwYMJ0ICLGgbUrnhttDpfKtaG+MzpMPcO322pgxcPBG8RRPP4E22Jmo9GlocnGw== X-Received: by 2002:a05:620a:c4e:b0:7c0:bb63:5375 with SMTP id af79cd13be357-7c7af0d639amr601362485a.4.1744663505698; Mon, 14 Apr 2025 13:45:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHLBb2WpVtzoAT+y2FmV5MGo40yUFAbGagDmJALFL0LsA+GecCl49y7VoJexczSZFb7o/nmpw== X-Received: by 2002:a05:620a:c4e:b0:7c0:bb63:5375 with SMTP id af79cd13be357-7c7af0d639amr601360185a.4.1744663505264; Mon, 14 Apr 2025 13:45:05 -0700 (PDT) Received: from [192.168.65.90] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-acaa1ce7fdcsm982525066b.176.2025.04.14.13.45.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Apr 2025 13:45:04 -0700 (PDT) Message-ID: Date: Mon, 14 Apr 2025 22:45:01 +0200 Precedence: bulk X-Mailing-List: iommu@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 6/6] arm64: dts: qcom: Add Xiaomi Redmi 3S To: =?UTF-8?B?QmFybmFiw6FzIEN6w6ltw6Fu?= , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Stephan Gerhold , =?UTF-8?Q?Otto_Pfl=C3=BCger?= , Linus Walleij , Lee Jones , Srinivas Kandagatla , Joerg Roedel , Will Deacon , Robin Murphy , Konrad Dybcio , Rob Clark , Sean Paul , Abhinav Kumar , Marijn Suijten , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Dmitry Baryshkov Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, iommu@lists.linux.dev, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, linux@mainlining.org References: <20250315-msm8937-v4-0-1f132e870a49@mainlining.org> <20250315-msm8937-v4-6-1f132e870a49@mainlining.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20250315-msm8937-v4-6-1f132e870a49@mainlining.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: xOeQGnIVT66fW7xFFRb5AE9Wap5kWKUN X-Proofpoint-GUID: xOeQGnIVT66fW7xFFRb5AE9Wap5kWKUN X-Authority-Analysis: v=2.4 cv=ANaQCy7k c=1 sm=1 tr=0 ts=67fd73d3 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=XR8D0OoHHMoA:10 a=VwQbUJbxAAAA:8 a=KKAkSRfTAAAA:8 a=OuZLqq7tAAAA:8 a=JKK38O5rW3uoAxCGYa0A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 a=cvBusfyB2V15izCimMoJ:22 a=AKGiAy9iJ-JzxKVHQNES:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-04-14_07,2025-04-10_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 adultscore=0 mlxlogscore=885 suspectscore=0 clxscore=1015 lowpriorityscore=0 phishscore=0 impostorscore=0 spamscore=0 priorityscore=1501 malwarescore=0 bulkscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2504140151 On 3/15/25 3:57 PM, Barnabás Czémán wrote: > Add initial support for Xiaomi Redmi 3S (land). > > Signed-off-by: Barnabás Czémán > --- [...] > + headphones_switch: audio-switch { > + compatible = "simple-audio-amplifier"; > + enable-gpios = <&tlmm 129 GPIO_ACTIVE_HIGH>; > + sound-name-prefix = "Headphones Switch"; > + pinctrl-0 = <&headphones_switch_default>; > + pinctrl-names = "default"; > + }; We've had a similar change lately https://lore.kernel.org/linux-arm-msm/20250327100633.11530-1-srinivas.kandagatla@linaro.org/ I think this could be some sort of a drivers/mux/... [...] > +&pm8937_resin { > + linux,code = ; > + status = "okay"; > +}; Please also unify the style such that there's a newline before status Looks good otherwise Konrad