From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 247A0C433B4 for ; Wed, 19 May 2021 10:01:45 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A8AB060698 for ; Wed, 19 May 2021 10:01:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A8AB060698 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 5EF0F40652; Wed, 19 May 2021 10:01:44 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OHFH3Jm9QYAi; Wed, 19 May 2021 10:01:43 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp4.osuosl.org (Postfix) with ESMTP id E8AC34064F; Wed, 19 May 2021 10:01:42 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id C26EEC000E; Wed, 19 May 2021 10:01:42 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 52B18C0001 for ; Wed, 19 May 2021 10:01:41 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 4191083F7B for ; Wed, 19 May 2021 10:01:41 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JxFsH1OCBGb3 for ; Wed, 19 May 2021 10:01:40 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp1.osuosl.org (Postfix) with ESMTP id 8200383D59 for ; Wed, 19 May 2021 10:01:40 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B74F3101E; Wed, 19 May 2021 03:01:39 -0700 (PDT) Received: from [10.57.66.179] (unknown [10.57.66.179]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8E03A3F719; Wed, 19 May 2021 03:01:38 -0700 (PDT) Subject: Re: [RFC PATCH v1 0/2] iommu/arm-smmu-v3: Add some parameter check in __arm_smmu_tlb_inv_range() To: Kunkun Jiang , Will Deacon , Eric Auger , "moderated list:ARM SMMU DRIVERS" , "open list:IOMMU DRIVERS" , open list References: <20210519094307.3275-1-jiangkunkun@huawei.com> From: Robin Murphy Message-ID: Date: Wed, 19 May 2021 11:01:33 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210519094307.3275-1-jiangkunkun@huawei.com> Content-Language: en-GB Cc: wanghaibin.wang@huawei.com X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On 2021-05-19 10:43, Kunkun Jiang wrote: > Hi all, > > This set of patches solves some errors when I tested the SMMU nested mode. > > Test scenario description: > guest kernel: 4KB translation granule > host kernel: 16KB translation granule > > errors: > 1. encountered an endless loop in __arm_smmu_tlb_inv_range because > num_pages is 0 > 2. encountered CERROR_ILL because the fields of TLB invalidation > command are as follow: TG = 2, NUM = 0, SCALE = 0, TTL = 0. The > combination is exactly the kind of reserved combination pointed > out in the SMMUv3 spec(page 143-144, version D.a) > > In my opinion, it is more appropriate to add parameter check in > __arm_smmu_tlb_inv_range(), although these problems only appeared > when I tested the SMMU nested mode. What do you think? FWIW I think it would be better to fix the caller to not issue broken commands in the first place. The kernel shouldn't do so for itself (and definitely needs fixing if it ever does), so it sounds like the nesting implementation needs to do a bit more validation of what it's passing through. Robin. > This series include patches as below: > Patch 1: > - align the invalid range with leaf page size upwards when smmu > supports RIL > > Patch 2: > - add a check to standardize granule size when smmu supports RIL > > Kunkun Jiang (2): > iommu/arm-smmu-v3: Align invalid range with leaf page size upwards > when support RIL > iommu/arm-smmu-v3: Standardize granule size when support RIL > > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu