From: Markus Elfring <Markus.Elfring@web.de>
To: Yu Kuai <yukuai3@huawei.com>,
iommu@lists.linux-foundation.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org
Cc: Yi Zhang <yi.zhang@huawei.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Will Deacon <will@kernel.org>
Subject: Re: [PATCH] iommu/qcom: add missing put_device() call in qcom_iommu_of_xlate()
Date: Fri, 18 Sep 2020 17:17:09 +0200 [thread overview]
Message-ID: <c68bed0d-3ddc-c8d4-2345-9edff917522b@web.de> (raw)
…
> +++ b/drivers/iommu/arm/arm-smmu/qcom_iommu.c
…
> @@ -595,6 +597,7 @@ static int qcom_iommu_of_xlate(struct device *dev, struct of_phandle_args *args)
> * banks are ok, but multiple devices are not:
> */
> if (WARN_ON(qcom_iommu != dev_iommu_priv_get(dev)))
> + put_device(&iommu_pdev->dev);
> return -EINVAL;
> }
* Would there be a need to use curly brackets for such an if branch?
* I suggest to add a jump target so that a bit of common exception handling code
can be better reused for this function implementation.
Regards,
Markus
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next reply other threads:[~2020-09-18 15:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-18 15:17 Markus Elfring [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-09-18 1:13 [PATCH] iommu/qcom: add missing put_device() call in qcom_iommu_of_xlate() Yu Kuai
2020-09-21 17:50 ` Will Deacon
2020-09-21 18:27 ` Rob Clark
2020-09-21 18:33 ` Rob Clark
2020-09-21 19:13 ` kernel test robot
2020-09-21 20:45 ` Will Deacon
2020-09-28 23:08 ` Will Deacon
2020-09-29 1:37 ` yukuai (C)
2020-09-23 4:32 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c68bed0d-3ddc-c8d4-2345-9edff917522b@web.de \
--to=markus.elfring@web.de \
--cc=iommu@lists.linux-foundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=will@kernel.org \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox