From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B8C1C433EF for ; Wed, 10 Nov 2021 07:50:43 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E1AFD61130 for ; Wed, 10 Nov 2021 07:50:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E1AFD61130 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id A8F1640468; Wed, 10 Nov 2021 07:50:42 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dPDQUjzeyGIK; Wed, 10 Nov 2021 07:50:40 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp4.osuosl.org (Postfix) with ESMTPS id 709B54042D; Wed, 10 Nov 2021 07:50:40 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 4647BC0012; Wed, 10 Nov 2021 07:50:40 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 1C65AC000E for ; Wed, 10 Nov 2021 07:50:38 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 1090D608FA for ; Wed, 10 Nov 2021 07:50:38 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp3.osuosl.org (amavisd-new); dkim=pass (1024-bit key) header.d=mediatek.com Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id w0wOIdue2IsD for ; Wed, 10 Nov 2021 07:50:32 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) by smtp3.osuosl.org (Postfix) with ESMTPS id 4780F60771 for ; Wed, 10 Nov 2021 07:50:31 +0000 (UTC) X-UUID: 2a6d5582c55c432cad6101895ba9a270-20211110 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=/1TqjzBPrVnDfHluNmOR1PKD5KL7XLPSyUrvjjeeBGU=; b=raoSaaXfYpHdufSaRygm0z2rFU90ys0L4RxA9R1VrYpg2fPg2eNVAJXQqSyuYFdz+KSBp0QDJZMMKFDvHetc6j/tAFwvjlkcFX/L3jAPp8uTUuhY2O9B3/i2+Bihe8qguNiVnVe5QE56EHF4asUK/IWZAktYmuiJ9k3i1rp7j6U=; X-UUID: 2a6d5582c55c432cad6101895ba9a270-20211110 Received: from mtkexhb02.mediatek.inc [(172.21.101.103)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1229391542; Wed, 10 Nov 2021 15:50:27 +0800 Received: from mtkmbs10n1.mediatek.inc (172.21.101.34) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.3; Wed, 10 Nov 2021 15:50:26 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkmbs10n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.15 via Frontend Transport; Wed, 10 Nov 2021 15:50:25 +0800 Message-ID: Subject: Re: [PATCH v3 12/33] iommu/mediatek: Always tlb_flush_all when each PM resume From: Yong Wu To: Dafna Hirschfeld Date: Wed, 10 Nov 2021 15:50:25 +0800 In-Reply-To: <4dd4cf8d-0f52-afae-f7d9-8e3cfdf3b729@collabora.com> References: <20210923115840.17813-1-yong.wu@mediatek.com> <20210923115840.17813-13-yong.wu@mediatek.com> <5c4dd67ae7c81721d8cfd2c3b23b7c6df493cb5a.camel@mediatek.com> <4dd4cf8d-0f52-afae-f7d9-8e3cfdf3b729@collabora.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N Cc: youlin.pei@mediatek.com, anan.sun@mediatek.com, srv_heupstream@mediatek.com, Krzysztof Kozlowski , Robin Murphy , sebastian.reichel@collabora.com, yen-chang.chen@mediatek.com, Fabien Parent , iommu@lists.linux-foundation.org, Rob Herring , linux-mediatek@lists.infradead.org, yf.wang@mediatek.com, Hsin-Yi Wang , Matthias Brugger , Collabora Kernel ML , Will Deacon , mingyuan.ma@mediatek.com, linux-arm-kernel@lists.infradead.org, AngeloGioacchino Del Regno X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Wed, 2021-11-10 at 07:29 +0200, Dafna Hirschfeld wrote: > > On 10.11.21 04:20, Yong Wu wrote: > > On Tue, 2021-11-09 at 14:21 +0200, Dafna Hirschfeld wrote: > > > Hi > > > This patch is needed in order to update the tlb when a device is > > > powered on. > > > Could you send this patch alone without the whole series so it > > > get > > > accepted easier? > > > > Which SoC are you testing on? In previous SoC, the IOMMU HW don't > > have > > power-domain, and we have a "has_pm"[1] in the tlb function for > > that > > case. The "has_pm" should be always 0 for the previous SoC like > > mt8173, > > it should always tlb synchronize. > > > > thus, Could you help share more about your issue? In which case it > > lack > > the necessary tlb operation. At least, We need confirm if it needs > > a > > "Fixes" tags if sending this patch alone. > > Hi, > I work with the mtk-vcodec driver on mt8173. As you wrote, the iommu > doesn't > have a power-domain and so when allocating buffers before the device > is powered > on, there is the warning > "Partial TLB flush timed out, falling back to full flush" > flooding the log buf. oh. Thanks very much for your information. Get it now. This issue should be introduced by the: b34ea31fe013 ("iommu/mediatek: Always enable the clk on resume") tlb failed due to the bclk is not enabled. Could you help try that after reverting this? > > Sebastian Reichel suggested to remove the 'if(has_pm)' check to avoid > this warning, > and avoid flushing the tlb if the device is off: > > [1] http://ix.io/3Eyr > > This fixes the warning, but then the tlb is not flushed in sync, > Therefore the tlb should be flushed when the device is resumed. > > So the two patches (the one suggested in the link [1] and this patch) > should be sent together as a 2-patch series. then this is reasonable. You could help this into a new patchset if you are free(add Fixes tag). Thanks. > > Thanks, > Dafna > > > > > Thanks. > > > > [1] > > https://elixir.bootlin.com/linux/v5.15/source/drivers/iommu/mtk_iommu.c#L236 > > > > > I can resend the patch on your behalf if you want. > > > > > > Thanks, > > > Dafna > > > > > > On 23.09.21 14:58, Yong Wu wrote: > > > > Prepare for 2 HWs that sharing pgtable in different power- > > > > domains. > > > > > > > > When there are 2 M4U HWs, it may has problem in the flush_range > > > > in > > > > which > > > > we get the pm_status via the m4u dev, BUT that function don't > > > > reflect the > > > > real power-domain status of the HW since there may be other HW > > > > also > > > > use > > > > that power-domain. > > > > > > > > The function dma_alloc_attrs help allocate the iommu buffer > > > > which > > > > need the corresponding power domain since tlb flush is needed > > > > when > > > > preparing iova. BUT this function only is for allocating > > > > buffer, > > > > we have no good reason to request the user always call > > > > pm_runtime_get > > > > before calling dma_alloc_xxx. Therefore, we add a tlb_flush_all > > > > in the pm_runtime_resume to make sure the tlb always is clean. > > > > > > > > Another solution is always call pm_runtime_get in the > > > > tlb_flush_range. > > > > This will trigger pm runtime resume/backup so often when the > > > > iommu > > > > power is not active at some time(means user don't call > > > > pm_runtime_get > > > > before calling dma_alloc_xxx), This may cause the performance > > > > drop. > > > > thus we don't use this. > > > > > > > > In other case, the iommu's power should always be active via > > > > device > > > > link with smi. > > > > > > > > The previous SoC don't have PM except mt8192. the mt8192 IOMMU > > > > is > > > > display's > > > > power-domain which nearly always is enabled. thus no need fix > > > > tags > > > > here. > > > > Prepare for mt8195. > > > > > > > > Signed-off-by: Yong Wu > > > > --- > > > > drivers/iommu/mtk_iommu.c | 11 +++++++++++ > > > > 1 file changed, 11 insertions(+) > > > > > > > > diff --git a/drivers/iommu/mtk_iommu.c > > > > b/drivers/iommu/mtk_iommu.c > > > > index 44cf5547d084..e9e94944ed91 100644 > > > > --- a/drivers/iommu/mtk_iommu.c > > > > +++ b/drivers/iommu/mtk_iommu.c > > > > @@ -984,6 +984,17 @@ static int __maybe_unused > > > > mtk_iommu_runtime_resume(struct device *dev) > > > > return ret; > > > > } > > > > > > > > + /* > > > > + * Users may allocate dma buffer before they call > > > > pm_runtime_get, then > > > > + * it will lack the necessary tlb flush. > > > > + * > > > > + * We have no good reason to request the users always > > > > call > > > > dma_alloc_xx > > > > + * after pm_runtime_get_sync. > > > > + * > > > > + * Thus, Make sure the tlb always is clean after each > > > > PM > > > > resume. > > > > + */ > > > > + mtk_iommu_tlb_do_flush_all(data); > > > > + > > > > /* > > > > * Uppon first resume, only enable the clk and return, > > > > since > > > > the values of the > > > > * registers are not yet set. > > > > _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu