From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E3151FA0 for ; Thu, 21 Jul 2022 02:35:18 +0000 (UTC) X-UUID: a87ce954c5df4c359b7262e0bc1b48bc-20220721 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.8,REQID:fcf65bc8-e657-4b99-8b3a-bfd6bc1b7cea,OB:0,LO B:0,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,RULE:Release_Ham,ACTI ON:release,TS:0 X-CID-META: VersionHash:0f94e32,CLOUDID:6574d964-0b3f-4b2c-b3a6-ed5c044366a0,C OID:IGNORED,Recheck:0,SF:nil,TC:nil,Content:0,EDM:-3,IP:nil,URL:1,File:nil ,QS:nil,BEC:nil,COL:0 X-UUID: a87ce954c5df4c359b7262e0bc1b48bc-20220721 Received: from mtkexhb01.mediatek.inc [(172.21.101.102)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1845675534; Thu, 21 Jul 2022 10:35:14 +0800 Received: from mtkmbs11n2.mediatek.inc (172.21.101.187) by mtkmbs11n2.mediatek.inc (172.21.101.187) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.3; Thu, 21 Jul 2022 10:35:13 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkmbs11n2.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.3 via Frontend Transport; Thu, 21 Jul 2022 10:35:13 +0800 Message-ID: Subject: Re: [PATCH v3 06/21] dt-bindings: power: mediatek: Add bindings for MediaTek SCPSYS From: Tinghan Shen To: Krzysztof Kozlowski , Lee Jones CC: Yong Wu , Joerg Roedel , "Will Deacon" , Robin Murphy , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , AngeloGioacchino Del Regno , MandyJH Liu , , , , , , Date: Thu, 21 Jul 2022 10:35:13 +0800 In-Reply-To: <68a30bbd-5f9d-17d2-59fa-7b0da06ee877@linaro.org> References: <20220720123023.13500-1-tinghan.shen@mediatek.com> <20220720123023.13500-7-tinghan.shen@mediatek.com> <68a30bbd-5f9d-17d2-59fa-7b0da06ee877@linaro.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 Precedence: bulk X-Mailing-List: iommu@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N On Wed, 2022-07-20 at 19:37 +0200, Krzysztof Kozlowski wrote: > On 20/07/2022 15:31, Lee Jones wrote: > > On Wed, 20 Jul 2022, Tinghan Shen wrote: > > > > > The System Control Processor System (SCPSYS) has several power > > > management related tasks in the system. Add the bindings for it. > > > > > > Signed-off-by: Tinghan Shen > > > > Why have you ignored my review comments from v2? > > If you refer whether the binding is needed at all, then the answer is > yes, because this is not simple syscons but a device with children, > which we want to parse/match. > > Anyway Tinghan should respond to you about way how he proceeds... > > Best regards, > Krzysztof Hi Lee, I'm so sorry for not answering your feedback. I misunderstood it that you're waiting the review result of DT maintainers. This binding is added because of the discussion of the scpsys node[1]. I first looked at mfd/syscon.yaml to see if I could use it. I found that it doesn't have the 'simple-mfd' compatible, so I decide to add a new one. It's because I need the 'simple-mfd' compatible to parse child nodes. [1] https://lore.kernel.org/all/f7eee4e8-05fa-4c83-9168-64e5ea4c510f@linaro.org/ Best regards, TingHan