From: Markus Elfring <Markus.Elfring@web.de>
To: "Thierry Reding" <thierry.reding@gmail.com>,
"Minjie Du" <duminjie@vivo.com>,
linux-tegra@vger.kernel.org, kernel-janitors@vger.kernel.org,
iommu@lists.linux.dev, "Jörg Rödel" <joro@8bytes.org>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
"Krishna Reddy" <vdumpa@nvidia.com>,
"Robin Murphy" <robin.murphy@arm.com>,
"Will Deacon" <will@kernel.org>
Cc: opensource.kernel@vivo.com, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] iommu: remove redundant parameter check in tegra_smmu_debugfs_init()
Date: Thu, 13 Jul 2023 11:20:15 +0200 [thread overview]
Message-ID: <c7c718e4-b583-cc0a-cd84-305d0fc0b66d@web.de> (raw)
In-Reply-To: <ZK-fD7inmxjwPyL5@orome>
> debugfs_create_file() will return early if smmu->debugfs is an error
> pointer, so an extra error check is not needed.
>
> With that fixed:
>
> Acked-by: Thierry Reding <treding@nvidia.com>
Are there any risks to consider with your presentation of this tag “in advance”?
I would also appreciate another improved imperative change description.
See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.5-rc1#n94
Would a subject like “[PATCH v3] iommu: Remove redundant error check in tegra_smmu_debugfs_init()”
be more appropriate?
Regards,
Markus
prev parent reply other threads:[~2023-07-13 9:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-13 2:56 [PATCH v2] iommu: remove redundant parameter check in tegra_smmu_debugfs_init() Minjie Du
2023-07-13 6:51 ` Thierry Reding
2023-07-13 9:20 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7c718e4-b583-cc0a-cd84-305d0fc0b66d@web.de \
--to=markus.elfring@web.de \
--cc=duminjie@vivo.com \
--cc=iommu@lists.linux.dev \
--cc=jonathanh@nvidia.com \
--cc=joro@8bytes.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=opensource.kernel@vivo.com \
--cc=robin.murphy@arm.com \
--cc=thierry.reding@gmail.com \
--cc=vdumpa@nvidia.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox