From: Robin Murphy <robin.murphy@arm.com>
To: John Garry <john.garry@huawei.com>, Will Deacon <will@kernel.org>
Cc: mst@redhat.com, linuxarm@huawei.com,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
xieyongji@bytedance.com, iommu@lists.linux-foundation.org,
jasowang@redhat.com
Subject: Re: [PATCH 0/5] iommu: Some IOVA code reorganisation
Date: Tue, 16 Nov 2021 14:25:50 +0000 [thread overview]
Message-ID: <cf539ded-5c9b-38b9-ad8f-a2ea4b28ec37@arm.com> (raw)
In-Reply-To: <cdb502c5-4896-385b-8872-f4f20e9c7e34@huawei.com>
On 2021-11-16 14:21, John Garry wrote:
> On 04/10/2021 12:44, Will Deacon wrote:
>> On Fri, Sep 24, 2021 at 06:01:52PM +0800, John Garry wrote:
>>> The IOVA domain structure is a bit overloaded, holding:
>>> - IOVA tree management
>>> - FQ control
>>> - IOVA rcache memories
>>>
>>> Indeed only a couple of IOVA users use the rcache, and only dma-iommu.c
>>> uses the FQ feature.
>>>
>>> This series separates out that structure. In addition, it moves the FQ
>>> code into dma-iommu.c . This is not strictly necessary, but it does make
>>> it easier for the FQ domain lookup the rcache domain.
>>>
>>> The rcache code stays where it is, as it may be reworked in future, so
>>> there is not much point in relocating and then discarding.
>>>
>>> This topic was initially discussed and suggested (I think) by Robin
>>> here:
>>> https://lore.kernel.org/linux-iommu/1d06eda1-9961-d023-f5e7-fe87e768f067@arm.com/
>>>
>> It would be useful to have Robin's Ack on patches 2-4. The implementation
>> looks straightforward to me, but the thread above isn't very clear about
>> what is being suggested.
>
> Hi Robin,
>
> Just wondering if you had made any progress on your FQ code rework or
> your own re-org?
Hey John - as it happens I started hacking on that in earnest about half
an hour ago, aiming to get something out later this week.
Cheers,
Robin.
> I wasn't planning on progressing
> https://lore.kernel.org/linux-iommu/1626259003-201303-1-git-send-email-john.garry@huawei.com/
> until this is done first (and that is still a big issue), even though
> not strictly necessary.
>
> Thanks,
> John
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
prev parent reply other threads:[~2021-11-16 14:26 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-24 10:01 [PATCH 0/5] iommu: Some IOVA code reorganisation John Garry
2021-09-24 10:01 ` [PATCH 1/5] iova: Move fast alloc size roundup into alloc_iova_fast() John Garry
2021-10-04 11:31 ` Will Deacon
2021-10-08 16:20 ` John Garry
2021-10-09 3:12 ` Yongji Xie
2021-10-11 2:06 ` Jason Wang
2021-10-27 9:25 ` John Garry
2021-10-18 15:42 ` Michael S. Tsirkin
2021-09-24 10:01 ` [PATCH 2/5] iommu: Separate flush queue memories from IOVA domain structure John Garry
2021-09-24 10:01 ` [PATCH 3/5] iommu: Move IOVA flush queue code to dma-iommu John Garry
2021-09-24 10:01 ` [PATCH 4/5] iommu: Separate IOVA rcache memories from iova_domain structure John Garry
2021-12-20 8:49 ` John Garry via iommu
2021-12-20 13:57 ` Robin Murphy
2021-12-22 11:53 ` John Garry via iommu
2021-09-24 10:01 ` [PATCH 5/5] iommu/iova: Avoid double-negatives in magazine helpers John Garry
2021-10-04 11:38 ` Will Deacon
2021-10-04 13:33 ` John Garry
2021-10-04 11:44 ` [PATCH 0/5] iommu: Some IOVA code reorganisation Will Deacon
2021-10-04 13:56 ` John Garry
2021-10-04 14:48 ` Robin Murphy
2021-11-16 14:21 ` John Garry
2021-11-16 14:25 ` Robin Murphy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf539ded-5c9b-38b9-ad8f-a2ea4b28ec37@arm.com \
--to=robin.murphy@arm.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jasowang@redhat.com \
--cc=john.garry@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=will@kernel.org \
--cc=xieyongji@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox