From: Yicong Yang via iommu <iommu@lists.linux-foundation.org>
To: Will Deacon <will@kernel.org>
Cc: mark.rutland@arm.com, prime.zeng@huawei.com,
alexander.shishkin@linux.intel.com, linux-pci@vger.kernel.org,
linuxarm@huawei.com, daniel.thompson@linaro.org,
peterz@infradead.org, mingo@redhat.com, helgaas@kernel.org,
liuqi115@huawei.com, mike.leach@linaro.org,
suzuki.poulose@arm.com, coresight@lists.linaro.org,
acme@kernel.org, zhangshaokun@hisilicon.com,
linux-arm-kernel@lists.infradead.org, mathieu.poirier@linaro.org,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
linux-perf-users@vger.kernel.org,
iommu@lists.linux-foundation.org, leo.yan@linaro.org,
robin.murphy@arm.com
Subject: Re: [PATCH v7 1/7] iommu/arm-smmu-v3: Make default domain type of HiSilicon PTT device to identity
Date: Tue, 10 May 2022 20:43:13 +0800 [thread overview]
Message-ID: <cfde7d29-bf1b-35c4-92d8-6cd1faabc4c7@huawei.com> (raw)
In-Reply-To: <20220510112326.GA27790@willie-the-truck>
On 2022/5/10 19:23, Will Deacon wrote:
> On Thu, Apr 07, 2022 at 08:58:35PM +0800, Yicong Yang wrote:
>> The DMA operations of HiSilicon PTT device can only work properly with
>> identical mappings. So add a quirk for the device to force the domain
>> as passthrough.
>>
>> Signed-off-by: Yicong Yang <yangyicong@hisilicon.com>
>> ---
>> drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 16 ++++++++++++++++
>> 1 file changed, 16 insertions(+)
>
> I still don't like this being part of the SMMU driver, but given that
> (a) Robin doesn't seem to agree with the objection and (b) you've been
> refreshing the patch series:
>
> Acked-by: Will Deacon <will@kernel.org>
>
> If you do respin, then:
>
>> diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
>> index 627a3ed5ee8f..5ec15ae2a9b1 100644
>> --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
>> +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
>> @@ -2839,6 +2839,21 @@ static int arm_smmu_dev_disable_feature(struct device *dev,
>> }
>> }
>
> It might be worth adding a brief comment here to explain what this device is
> and why it needs an identity mapping.
>
>> +#define IS_HISI_PTT_DEVICE(pdev) ((pdev)->vendor == PCI_VENDOR_ID_HUAWEI && \
>> + (pdev)->device == 0xa12e)
>
Will add a brief comment here in next version.
Thanks,
Yicong
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2022-05-10 12:43 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-07 12:58 [PATCH v7 0/7] Add support for HiSilicon PCIe Tune and Trace device Yicong Yang via iommu
2022-04-07 12:58 ` [PATCH v7 1/7] iommu/arm-smmu-v3: Make default domain type of HiSilicon PTT device to identity Yicong Yang via iommu
2022-05-10 11:23 ` Will Deacon
2022-05-10 12:43 ` Yicong Yang via iommu [this message]
2022-05-11 11:42 ` John Garry via iommu
2022-04-07 12:58 ` [PATCH v7 2/7] hwtracing: Add trace function support for HiSilicon PCIe Tune and Trace device Yicong Yang via iommu
2022-04-11 17:02 ` John Garry via iommu
2022-04-12 7:36 ` Yicong Yang via iommu
2022-04-12 8:39 ` John Garry via iommu
2022-04-12 12:52 ` Yicong Yang via iommu
2022-04-29 16:00 ` Leo Yan
2022-05-05 12:13 ` Yicong Yang via iommu
2022-05-10 9:46 ` James Clark
2022-05-10 11:18 ` Yicong Yang via iommu
2022-05-10 12:54 ` James Clark
2022-05-10 13:17 ` Yicong Yang via iommu
2022-04-07 12:58 ` [PATCH v7 3/7] hisi_ptt: Add support for dynamically updating the filter list Yicong Yang via iommu
2022-04-07 12:58 ` [PATCH v7 4/7] hisi_ptt: Add tune function support for HiSilicon PCIe Tune and Trace device Yicong Yang via iommu
2022-04-07 12:58 ` [PATCH v7 5/7] perf tool: Add support for HiSilicon PCIe Tune and Trace device driver Yicong Yang via iommu
2022-04-11 17:19 ` John Garry via iommu
2022-04-12 7:41 ` Yicong Yang via iommu
2022-04-14 13:00 ` John Garry via iommu
2022-04-30 7:35 ` Leo Yan
2022-05-05 11:30 ` liuqi (BA) via iommu
2022-05-10 10:14 ` James Clark
2022-05-11 2:02 ` liuqi (BA) via iommu
2022-05-11 9:18 ` James Clark
2022-04-07 12:58 ` [PATCH v7 6/7] docs: Add HiSilicon PTT device driver documentation Yicong Yang via iommu
2022-04-07 12:58 ` [PATCH v7 7/7] MAINTAINERS: Add maintainer for HiSilicon PTT driver Yicong Yang via iommu
2022-04-14 13:20 ` [PATCH v7 0/7] Add support for HiSilicon PCIe Tune and Trace device Yicong Yang via iommu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cfde7d29-bf1b-35c4-92d8-6cd1faabc4c7@huawei.com \
--to=iommu@lists.linux-foundation.org \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=coresight@lists.linaro.org \
--cc=daniel.thompson@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=helgaas@kernel.org \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=liuqi115@huawei.com \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=prime.zeng@huawei.com \
--cc=robin.murphy@arm.com \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
--cc=yangyicong@huawei.com \
--cc=zhangshaokun@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox