Re: [PATCH 5/6] spacemit/t100: Add global filter support for RISC-V IOMMU HPM

Krzysztof Kozlowski
2026-01-28T07:46:58Z

On 28/01/2026 03:25, Lv Zheng wrote:
> This patch introduces global filter support for RISC-V IOMMU HPM. The

Please do not use "This commit/patch/change", but imperative mood. See
longer explanation here:
https://elixir.bootlin.com/linux/v6.16/source/Documentation/process/submitting-patches.rst#L94

> global filter can be seen in SpacemiT T100 which only supports single
> filter to be applied to all event counters. This silicon design can save
> the number of the event bus signals.
>
> Signed-off-by: Lv Zheng <lv.zheng@spacemit.com>
> Signed-off-by: Jingyu Li <joey.li@spacemit.com>
> ---
> .../bindings/iommu/riscv,iommu.yaml | 2 +
> drivers/iommu/riscv/iommu-hpm.c | 93 +++++++++++++++++--
> drivers/iommu/riscv/iommu.h | 1 +
> 3 files changed, 89 insertions(+), 7 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/iommu/riscv,iommu.yaml b/Documentation/devicetree/bindings/iommu/riscv,iommu.yaml
> index b69109362b20..ec5b84ff5afb 100644
> --- a/Documentation/devicetree/bindings/iommu/riscv,iommu.yaml
> +++ b/Documentation/devicetree/bindings/iommu/riscv,iommu.yaml
> @@ -72,6 +72,8 @@ properties:
> minItems: 1
> maxItems: 120
>
> + global-filter: true

NAK, absolutely pointless and wrong code. I am not providing you full
review because you did not bother to follow basic steps required from
you, so essentially you waste our time.

Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC (and consider --no-git-fallback argument, so you will
not CC people just because they made one commit years ago). It might
happen, that command when run on an older kernel, gives you outdated
entries. Therefore please be sure you base your patches on recent Linux
kernel.

Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline) or work on fork of kernel
(don't, instead use mainline). Just use b4 and everything should be
fine, although remember about `b4 prep --auto-to-cc` if you added new
patches to the patchset.

Best regards,
Krzysztof