Re: [PATCH 4/6] spacemit/t100: Add vendor event support for RISC-V IOMMU HPM

郑律
2026-01-28T08:25:09Z

Hi,

> From: "Krzysztof Kozlowski"<krzk@kernel.org>
> Date:  Wed, Jan 28, 2026, 15:46
> Subject:  Re: [PATCH 4/6] spacemit/t100: Add vendor event support for RISC-V IOMMU HPM
> To: "Lv Zheng"<lv.zheng@spacemit.com>, "Robin Murphy"<robin.murphy@arm.com>, "Tomasz Jeznach"<tjeznach@rivosinc.com>
> Cc: "Jingyu Li"<joey.li@spacemit.com>, "Zhijian Chen"<zhijian@spacemit.com>, <iommu@lists.linux.dev>
> On 28/01/2026 03:24, Lv Zheng wrote:
> > This patch adds mechanism to allow vendor events to be registered via
> > device tree. This is useful to support SpacemiT T100 IOMMU where the
> > maximum 128 event IDs should be supported by T100 IOATS.
> >
> > Signed-off-by: Lv Zheng <lv.zheng@spacemit.com>
> > Signed-off-by: Jingyu Li <joey.li@spacemit.com>
> > ---
> >  .../bindings/iommu/riscv,iommu.yaml           |  4 +
>
> Please run scripts/checkpatch.pl on the patches and fix reported
> warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
> patches and (probably) fix more warnings. Some warnings can be ignored,
> especially from --strict run, but the code here looks like it needs a
> fix. Feel free to get in touch if the warning is not clear.
>
> Please use scripts/get_maintainers.pl to get a list of necessary people
> and lists to CC (and consider --no-git-fallback argument, so you will
> not CC people just because they made one commit years ago). It might
> happen, that command when run on an older kernel, gives you outdated
> entries. Therefore please be sure you base your patches on recent Linux
> kernel.
>
> Tools like b4 or scripts/get_maintainer.pl provide you proper list of
> people, so fix your workflow. Tools might also fail if you work on some
> ancient tree (don't, instead use mainline) or work on fork of kernel
> (don't, instead use mainline). Just use b4 and everything should be
> fine, although remember about `b4 prep --auto-to-cc` if you added new
> patches to the patchset.
>
> Anyway, the property is NAK - does not follow any standard rules. Read
> docs in kernel about bindings and some DTS beginners talks/slides.

Sure, thanks for the kind reply. Will rework and submit again.

Best regards
Lv

> Best regards,
> Krzysztof
>

This message and any attachment are confidential and may be privileged or otherwise protected from disclosure. If you are not an intended recipient of this message, please delete it and any attachment from your system and notify the sender immediately by reply e-mail. Unintended recipients should not use, copy, disclose or take any action based on this message or any information contained in this message. Emails cannot be guaranteed to be secure or error free as they can be intercepted, amended, lost or destroyed, and you should take full responsibility for security checking.

本邮件及其任何附件具有保密性质，并可能受其他保护或不允许被披露给第三方。如阁下误收到本邮件，敬请立即以回复电子邮件的方式通知发件人，并将本邮件及其任何附件从阁下系统中予以删除。如阁下并非本邮件写明之收件人，敬请切勿使用、复制、披露本邮件或其任何内容，亦请切勿依本邮件或其任何内容而采取任何行动。电子邮件无法保证是一种安全和不会出现任何差错的通信方式，可能会被拦截、修改、丢失或损坏，收件人需自行负责做好安全检查。