Re: [PATCH 4/6] spacemit/t100: Add vendor event support for RISC-V IOMMU HPM

Krzysztof Kozlowski
2026-01-28T07:45:43Z

On 28/01/2026 03:24, Lv Zheng wrote:
> This patch adds mechanism to allow vendor events to be registered via
> device tree. This is useful to support SpacemiT T100 IOMMU where the
> maximum 128 event IDs should be supported by T100 IOATS.
>
> Signed-off-by: Lv Zheng <lv.zheng@spacemit.com>
> Signed-off-by: Jingyu Li <joey.li@spacemit.com>
> ---
> .../bindings/iommu/riscv,iommu.yaml | 4 +

Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC (and consider --no-git-fallback argument, so you will
not CC people just because they made one commit years ago). It might
happen, that command when run on an older kernel, gives you outdated
entries. Therefore please be sure you base your patches on recent Linux
kernel.

Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline) or work on fork of kernel
(don't, instead use mainline). Just use b4 and everything should be
fine, although remember about `b4 prep --auto-to-cc` if you added new
patches to the patchset.

Anyway, the property is NAK - does not follow any standard rules. Read
docs in kernel about bindings and some DTS beginners talks/slides.

Best regards,
Krzysztof