From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40D17C28CBC for ; Wed, 6 May 2020 17:54:27 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 13F3F206D5 for ; Wed, 6 May 2020 17:54:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 13F3F206D5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 1D5E68968F; Wed, 6 May 2020 17:50:58 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nNViNlqVvvXY; Wed, 6 May 2020 17:50:57 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by hemlock.osuosl.org (Postfix) with ESMTP id 7BB788966C; Wed, 6 May 2020 17:50:57 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 6D6E1C088B; Wed, 6 May 2020 17:50:57 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 52914C0859 for ; Wed, 6 May 2020 17:50:55 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 41EBE2011B for ; Wed, 6 May 2020 17:50:55 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gB5U65GFLOo5 for ; Wed, 6 May 2020 17:50:54 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by silver.osuosl.org (Postfix) with ESMTPS id 732641FD16 for ; Wed, 6 May 2020 17:50:53 +0000 (UTC) IronPort-SDR: YOarMGLeU+et6e7sz08LIyIjeiTRx05QhOIrijmuxneq69FIhoGYP9+ABmkBC+qFcGI+TLCJPc 3s7Hpa6EUuiA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 May 2020 10:50:52 -0700 IronPort-SDR: xm8tvqQxOE1rPKi9rbOCo7TO3uBzKdp1kfpW8KZL0EdRthEnS3SB3m0Ijjh17ghi7cG2E/af2F YVm1NUd2QXMA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,360,1583222400"; d="scan'208";a="461518608" Received: from orsmsx102.amr.corp.intel.com ([10.22.225.129]) by fmsmga005.fm.intel.com with ESMTP; 06 May 2020 10:50:51 -0700 Received: from orsmsx158.amr.corp.intel.com (10.22.240.20) by ORSMSX102.amr.corp.intel.com (10.22.225.129) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 6 May 2020 10:50:50 -0700 Received: from orsmsx101.amr.corp.intel.com ([169.254.8.204]) by ORSMSX158.amr.corp.intel.com ([169.254.10.56]) with mapi id 14.03.0439.000; Wed, 6 May 2020 10:50:49 -0700 From: "Derrick, Jonathan" To: "baolu.lu@linux.intel.com" , "drake@endlessm.com" Subject: Re: [PATCH v4 0/3] Replace private domain with per-group default domain Thread-Topic: [PATCH v4 0/3] Replace private domain with per-group default domain Thread-Index: AQHWI0qLt8RTAcgRzUWht5gocxEdBqiaxYyAgAEGfQA= Date: Wed, 6 May 2020 17:50:48 +0000 Message-ID: References: <20200506015947.28662-1-baolu.lu@linux.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.179.93] Content-ID: <07B3CD54AE2C8B4387A28686CBB77ED0@intel.com> MIME-Version: 1.0 Cc: "Tian, Kevin" , "Raj, Ashok" , "linux-kernel@vger.kernel.org" , "iommu@lists.linux-foundation.org" , "robin.murphy@arm.com" , "hch@lst.de" X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Wed, 2020-05-06 at 10:09 +0800, Daniel Drake wrote: > On Wed, May 6, 2020 at 10:03 AM Lu Baolu wrote: > > https://lkml.org/lkml/2020/4/14/616 > > [This has been applied in iommu/next.] > > > > Hence, there is no need to keep the private domain implementation > > in the Intel IOMMU driver. This patch series aims to remove it. > > I applied these patches on top of Joerg's branch and confirmed that > they fix the issue discussed in the thread: > > [PATCH v2] iommu/vt-d: consider real PCI device when checking if > mapping is needed > (the patch there is no longer needed) > > Tested-by: Daniel Drake > > Thanks! Looks like the key to the real DMA dev fix was removing identity_mapping() paths that led to dev->archdata.iommu == NULL -> DMA domain Works great for me as well Reviewed-by: Jon Derrick _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu