Re: [PATCH 1/2] iommu/amd: Use BIT/BIT_ULL macro to define bit fields

[Vasant Hegde <vasant.hegde@amd.com>]

Jerry,


On 6/13/2023 12:25 AM, Jerry Snitselaar wrote:
> On Fri, Jun 09, 2023 at 09:06:30AM +0000, Vasant Hegde wrote:
>> Make use of BIT macro when defining bitfields which makes it easy to read.
>>
>> No functional change intended.
>>
>> Suggested-by: Yazen Ghannam <yazen.ghannam@amd.com>
>> Signed-off-by: Vasant Hegde <vasant.hegde@amd.com>
>> ---
>>  drivers/iommu/amd/amd_iommu_types.h | 76 ++++++++++++++---------------
>>  1 file changed, 38 insertions(+), 38 deletions(-)
>>
>> diff --git a/drivers/iommu/amd/amd_iommu_types.h b/drivers/iommu/amd/amd_iommu_types.h
>> index ae0edeb379d4..a49cc2258a76 100644
>> --- a/drivers/iommu/amd/amd_iommu_types.h
>> +++ b/drivers/iommu/amd/amd_iommu_types.h
>> @@ -84,21 +84,21 @@
>>  


.../...

>>  /*
>>   * Bit value definition for DTE fields
>>   */
>> -#define DTE_FLAG_V  (1ULL << 0)
>> -#define DTE_FLAG_TV (1ULL << 1)
>> -#define DTE_FLAG_IR (1ULL << 61)
>> -#define DTE_FLAG_IW (1ULL << 62)
>> -
>> -#define DTE_FLAG_IOTLB	(1ULL << 32)
>> -#define DTE_FLAG_GIOV	(1ULL << 54)
>> -#define DTE_FLAG_GV	(1ULL << 55)
>> +#define DTE_FLAG_V	BIT_ULL(0)
>> +#define DTE_FLAG_TV	BIT_ULL(1)
>> +#define DTE_FLAG_IR	BIT_ULL(61)
>> +#define DTE_FLAG_IW	BIT_ULL(62)
>> +
>> +#define DTE_FLAG_IOTLB	BIT_ULL(32)
>> +#define DTE_FLAG_GIOV	BIT_ULL(54)
>> +#define DTE_FLAG_GV	BIT_ULL(55)
> 
> Minor thing, but would it make sense to group these according
> to which 64-bit word they are in? DTE_FLAG_IOTLB is in the
> second 64-bit word of the DTE, and the rest are in the first.

Sure. I will fix it in next version.

-Vasant