From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1271962E for ; Tue, 30 Aug 2022 07:47:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1661845622; x=1693381622; h=message-id:date:mime-version:cc:subject:to:references: from:in-reply-to:content-transfer-encoding; bh=yBpwSdK8tn25JNz7gtB+fP1W3XIksw4isildm6byryI=; b=bHb38RJ/wFqeKiInEI08V8sOi6euV5FPLBSJdvRxTv7t6nw+sSzwJIm9 uY1DIlLR4PGOC1ByymM1/5qPfNS5CJyDETfuapa3aTr5+AuQywZj6lYT9 dBy56RkLbQP04ifCds5Oa114kIKRJqTjD0xo+rqwbJ2Q6Ia7qtIZtunr0 +36DG01z0f0VakuGE0g/JiOsw0U+Z1jHcQXCP3TgaY4Yt/xrtVWKGg/Su jzixSAQ96UcRiQNBoSEQhJzpqrpsZ+jm2744KKHkC39No5zSmdJGaLXHu Zr8mC52QZzOJSZGkRLXGNrHcKO/YfBRweqNAmBcploMEKsKlSxE8pbf5m w==; X-IronPort-AV: E=McAfee;i="6500,9779,10454"; a="274857939" X-IronPort-AV: E=Sophos;i="5.93,274,1654585200"; d="scan'208";a="274857939" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Aug 2022 00:47:01 -0700 X-IronPort-AV: E=Sophos;i="5.93,274,1654585200"; d="scan'208";a="672737784" Received: from hhuan14-mobl1.ccr.corp.intel.com (HELO [10.254.215.208]) ([10.254.215.208]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Aug 2022 00:46:56 -0700 Message-ID: Date: Tue, 30 Aug 2022 15:46:55 +0800 Precedence: bulk X-Mailing-List: iommu@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Cc: baolu.lu@linux.intel.com, Eric Auger , Liu Yi L , Jacob jun Pan , Zhangfei Gao , Zhu Tony , iommu@lists.linux.dev, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Jean-Philippe Brucker Subject: Re: [PATCH v12 13/17] iommu/sva: Refactoring iommu_sva_bind/unbind_device() Content-Language: en-US To: Yuan Can , Joerg Roedel , Jason Gunthorpe , Christoph Hellwig , Bjorn Helgaas , Kevin Tian , Ashok Raj , Will Deacon , Robin Murphy , Jean-Philippe Brucker , Dave Jiang , Fenghua Yu , Vinod Koul References: <20220826121141.50743-1-baolu.lu@linux.intel.com> <20220826121141.50743-14-baolu.lu@linux.intel.com> <47879368-fb4e-79aa-35f9-018d871f013c@huawei.com> <96ac1693-d87f-250d-c897-c79f13ed4c0a@linux.intel.com> From: Baolu Lu In-Reply-To: <96ac1693-d87f-250d-c897-c79f13ed4c0a@linux.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2022/8/30 15:45, Baolu Lu wrote: > On 2022/8/30 15:30, Yuan Can wrote: >> >> 在 2022/8/26 20:11, Lu Baolu 写道: >>> The existing iommu SVA interfaces are implemented by calling the SVA >>> specific iommu ops provided by the IOMMU drivers. There's no need for >>> any SVA specific ops in iommu_ops vector anymore as we can achieve >>> this through the generic attach/detach_dev_pasid domain ops. >>> >>> This refactors the IOMMU SVA interfaces implementation by using the >>> iommu_detach/detach_device_pasid interfaces and align them with the >> >> Did you mean using the iommu_attach/detach_device_pasid interfaces here? > > The device driver oriented SVA interfaces keep consistent as before. > Here we only refactor the IOMMU internal implementation. Oh! A typo in the commit message, right? Thanks and I will fix it. Best regards, baolu