From: Gary R Hook <gary.hook-5C7GfCeVMHo@public.gmane.org>
To: Andy Shevchenko
<andy.shevchenko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
Linux Kernel Mailing List
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH v2 1/5] iommu/amd - Add debugfs support
Date: Wed, 14 Mar 2018 17:23:40 -0500 [thread overview]
Message-ID: <e43c5e45-77e8-df20-ee90-1ac5cc3ad288@amd.com> (raw)
In-Reply-To: <CAHp75VeEUCVSKLH0aobk=+GjVHWgO_OAKZRCx8gqDc9tWvESMw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On 03/14/2018 10:29 AM, Andy Shevchenko wrote:
> On Wed, Mar 14, 2018 at 5:24 PM, Gary R Hook <gary.hook-5C7GfCeVMHo@public.gmane.org> wrote:
>> On 03/13/2018 03:23 PM, Andy Shevchenko wrote:
>
>>>>>> +#include <linux/pci.h>
>>>>>> +#include <linux/iommu.h>
>>>>>> +#include <linux/debugfs.h>
>
>>>>> Keep in order?
>
>>>> What order would that be? These few needed files are listed in the same
>>>> order as which they appear in amd_iommu.c. I'm gonna need a preference
>>>> spelled out, please (and a rationale, so I may better understand).
>
>>> To increase readability and avoid potential header duplication (here
>>> is can bus protocol implementation where the problem exists for real,
>>> even in new code!)
>
>> With all due respect, I don't find that you clearly answered my question.
>
> Alphabetical order I meant.
Thank you very much.
Gary
next prev parent reply other threads:[~2018-03-14 22:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-09 0:50 [PATCH v2 0/5] Add debugfs info for the AMD IOMMU Gary R Hook
[not found] ` <152055660594.63229.5131049527614494130.stgit-tq90VzyE+wXkLsZ8J5Uweg@public.gmane.org>
2018-03-09 0:50 ` [PATCH v2 1/5] iommu/amd - Add debugfs support Gary R Hook
[not found] ` <152055664720.63229.16209149030018336339.stgit-tq90VzyE+wXkLsZ8J5Uweg@public.gmane.org>
2018-03-13 17:16 ` Andy Shevchenko
[not found] ` <CAHp75VdK6qFopBE4rD4yNO5GHccxyte=GhYU7YGcWOEYSCyX8Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-03-13 18:54 ` Gary R Hook
[not found] ` <30bd9559-0e44-bd18-6b9a-ec35bc8276f3-5C7GfCeVMHo@public.gmane.org>
2018-03-13 20:23 ` Andy Shevchenko
[not found] ` <CAHp75VeySPBEeJKRXzmqfPey56J3rwr2-dPRzSYx+7a7TAC5rw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-03-14 15:24 ` Gary R Hook
[not found] ` <08d19301-7e8e-7586-8ffb-91823af0d31b-5C7GfCeVMHo@public.gmane.org>
2018-03-14 15:29 ` Andy Shevchenko
[not found] ` <CAHp75VeEUCVSKLH0aobk=+GjVHWgO_OAKZRCx8gqDc9tWvESMw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-03-14 22:23 ` Gary R Hook [this message]
2018-03-09 0:50 ` [PATCH v2 2/5] iommu/amd - Add a 'verbose' switch for IOMMU debugfs Gary R Hook
2018-03-09 0:51 ` [PATCH v2 3/5] iommu/amd - Add a README variable for the " Gary R Hook
2018-03-09 0:51 ` [PATCH v2 4/5] iommu/amd - Expose the active IOMMU device table entries Gary R Hook
2018-03-09 0:51 ` [PATCH v2 5/5] iommu/amd - Add a debugfs entry to specify a IOMMU device table entry Gary R Hook
[not found] ` <152055669123.63229.1692099069085978884.stgit-tq90VzyE+wXkLsZ8J5Uweg@public.gmane.org>
2018-03-13 17:20 ` Andy Shevchenko
[not found] ` <CAHp75Vfc+JTjU2P0GCedVFcHYniXoVcmRC3n4cFsLMr9sx6eyA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-03-13 18:54 ` Gary R Hook
[not found] ` <3969f155-c3bf-44c5-d056-825e71d42152-5C7GfCeVMHo@public.gmane.org>
2018-03-13 20:56 ` Andy Shevchenko
[not found] ` <CAHp75VcuYamhrEu=B1zeFpz6s1vGfZaMyonYK6p_Y_EJF4=4Ng-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-03-14 15:24 ` Gary R Hook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e43c5e45-77e8-df20-ee90-1ac5cc3ad288@amd.com \
--to=gary.hook-5c7gfcevmho@public.gmane.org \
--cc=andy.shevchenko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).