From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lu Baolu Subject: Re: [PATCH v4 11/12] iommu/vt-d: Shared virtual address in scalable mode Date: Mon, 5 Nov 2018 15:17:12 +0800 Message-ID: References: <20181105053151.7173-1-baolu.lu@linux.intel.com> <20181105053151.7173-12-baolu.lu@linux.intel.com> <20181105071505.GA13230@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20181105071505.GA13230@infradead.org> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Christoph Hellwig Cc: baolu.lu@linux.intel.com, Joerg Roedel , David Woodhouse , kevin.tian@intel.com, ashok.raj@intel.com, Jean-Philippe Brucker , sanjay.k.kumar@intel.com, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, yi.y.sun@intel.com, jacob.jun.pan@intel.com List-Id: iommu@lists.linux-foundation.org Hi, On 11/5/18 3:15 PM, Christoph Hellwig wrote: >> --- a/include/linux/dma_remapping.h >> +++ b/include/linux/dma_remapping.h > > FYI, this file seems to be entirely VT-D specific, but has an awfully > generic name. It should be renamed to something more suitable (or maybe > just merged into intel-iommu.h?) and also grow some comments describing > the contents. > Yes, good catch. I will do this in a separated patch. Best regards, Lu Baolu