From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robin Murphy Subject: Re: [PATCH 07/21] dma-iommu: move the arm64 wrappers to common code Date: Tue, 9 Apr 2019 18:33:30 +0100 Message-ID: References: <20190327080448.5500-1-hch@lst.de> <20190327080448.5500-8-hch@lst.de> <67573dd3-72c7-692d-bc1a-7edb49ff9551@arm.com> <20190409172309.GD14679@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190409172309.GD14679@lst.de> Content-Language: en-GB Sender: linux-kernel-owner@vger.kernel.org To: Christoph Hellwig Cc: Joerg Roedel , Catalin Marinas , Will Deacon , Tom Lendacky , iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org List-Id: iommu@lists.linux-foundation.org On 09/04/2019 18:23, Christoph Hellwig wrote: > On Tue, Apr 09, 2019 at 04:07:02PM +0100, Robin Murphy wrote: >>> -static inline int iommu_dma_init(void) >>> +static inline void iommu_setup_dma_ops(struct device *dev, u64 dma_base, >>> + u64 size, const struct iommu_ops *ops) >>> { >>> - return 0; >>> } >> >> I don't think it makes sense to have a stub for that - AFAICS it should >> only ever be called form arch code with an inherent "select IOMMU_DMA" >> (much like the stuff which isn't stubbed currently). >> >> Otherwise, I'm about 97% sure the rest of the move looks OK - thanks for >> splitting things up. > > arm64 only selects IOMMU_DMA if IOMMU_SUPPORT is selected, which can > be disabled. So to keep some (unusual) arm64 configs compiling we'll need > the stub.. Urgh, right, it worked out before because arm64 stubbed its own caller of iommu_dma_init_domain() internally... Oh well - I guess there's no nicer alternative, and we have always treated arch_setup_dma_ops() that way. Robin. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FDE8C282CE for ; Tue, 9 Apr 2019 17:33:35 +0000 (UTC) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 259A52133D for ; Tue, 9 Apr 2019 17:33:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 259A52133D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id D045DDD9; Tue, 9 Apr 2019 17:33:34 +0000 (UTC) Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 9D677DD1 for ; Tue, 9 Apr 2019 17:33:33 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from foss.arm.com (foss.arm.com [217.140.101.70]) by smtp1.linuxfoundation.org (Postfix) with ESMTP id 37F1C76D for ; Tue, 9 Apr 2019 17:33:33 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F164215BE; Tue, 9 Apr 2019 10:33:32 -0700 (PDT) Received: from [10.1.196.75] (e110467-lin.cambridge.arm.com [10.1.196.75]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 98C3F3F59C; Tue, 9 Apr 2019 10:33:31 -0700 (PDT) Subject: Re: [PATCH 07/21] dma-iommu: move the arm64 wrappers to common code To: Christoph Hellwig References: <20190327080448.5500-1-hch@lst.de> <20190327080448.5500-8-hch@lst.de> <67573dd3-72c7-692d-bc1a-7edb49ff9551@arm.com> <20190409172309.GD14679@lst.de> From: Robin Murphy Message-ID: Date: Tue, 9 Apr 2019 18:33:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190409172309.GD14679@lst.de> Content-Language: en-GB Cc: Tom Lendacky , Catalin Marinas , Will Deacon , linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="UTF-8"; format="flowed" Sender: iommu-bounces@lists.linux-foundation.org Errors-To: iommu-bounces@lists.linux-foundation.org Message-ID: <20190409173330.Jo7a3877HXNfUlKNEt2RX3ffqFqpzQpsithQw5DMG5M@z> On 09/04/2019 18:23, Christoph Hellwig wrote: > On Tue, Apr 09, 2019 at 04:07:02PM +0100, Robin Murphy wrote: >>> -static inline int iommu_dma_init(void) >>> +static inline void iommu_setup_dma_ops(struct device *dev, u64 dma_base, >>> + u64 size, const struct iommu_ops *ops) >>> { >>> - return 0; >>> } >> >> I don't think it makes sense to have a stub for that - AFAICS it should >> only ever be called form arch code with an inherent "select IOMMU_DMA" >> (much like the stuff which isn't stubbed currently). >> >> Otherwise, I'm about 97% sure the rest of the move looks OK - thanks for >> splitting things up. > > arm64 only selects IOMMU_DMA if IOMMU_SUPPORT is selected, which can > be disabled. So to keep some (unusual) arm64 configs compiling we'll need > the stub.. Urgh, right, it worked out before because arm64 stubbed its own caller of iommu_dma_init_domain() internally... Oh well - I guess there's no nicer alternative, and we have always treated arch_setup_dma_ops() that way. Robin. _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu