Re: [PATCH 08/11] iommu/vt-d: Add domain_type_is_sva helper function

[Baolu Lu <baolu.lu@linux.intel.com>]

On 2024/1/16 9:11, Tina Zhang wrote:
> Introduce a helper function to tell if the type of a dmar_domain is sva
> or not. In general, comparing with normal iommu_domain, a sva domain
> shouldn't be special other than having a different source for the page
> table. Thus, this helper function should be used as little as possible
> (i.e. only in the cases related to handling page table source).
> 
> Signed-off-by: Tina Zhang <tina.zhang@intel.com>
> ---
>   drivers/iommu/intel/iommu.c | 7 ++++++-
>   1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c
> index 0eec5d971315..af466ba301b7 100644
> --- a/drivers/iommu/intel/iommu.c
> +++ b/drivers/iommu/intel/iommu.c
> @@ -244,6 +244,11 @@ static int domain_type_is_si(struct dmar_domain *domain)
>   	return domain->domain.type == IOMMU_DOMAIN_IDENTITY;
>   }
>   
> +static inline bool domain_type_is_sva(struct dmar_domain *domain)
> +{
> +	return domain->domain.type == IOMMU_DOMAIN_SVA;
> +}

Move the helper into the header file and put appropriate comments around
it.

Best regards,
baolu