From: Jacob Keller <jacob.e.keller@intel.com>
To: Mirsad Goran Todorovac <mirsad.todorovac@alu.unizg.hr>,
Jason Gunthorpe <jgg@ziepe.ca>, Joerg Roedel <jroedel@suse.de>,
Lu Baolu <baolu.lu@linux.intel.com>, <iommu@lists.linux.dev>,
<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>
Cc: Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
"Robin Murphy" <robin.murphy@arm.com>,
Heiner Kallweit <hkallweit1@gmail.com>, <nic_swsd@realtek.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Marco Elver <elver@google.com>
Subject: Re: [PATCH v4 3/5] r8169: Coalesce mac ocp write and modify for 8168H start to reduce spinlocks
Date: Mon, 30 Oct 2023 14:53:06 -0700 [thread overview]
Message-ID: <ef101904-a615-4527-8d8f-1f43b3d997f6@intel.com> (raw)
In-Reply-To: <20231029110442.347448-3-mirsad.todorovac@alu.unizg.hr>
On 10/29/2023 4:04 AM, Mirsad Goran Todorovac wrote:
> Repeated calls to r8168_mac_ocp_write() and r8168_mac_ocp_modify() in
> the startup of 8168H involve implicit spin_lock_irqsave() and spin_unlock_irqrestore()
> on each invocation.
>
> Coalesced with the corresponding helpers, r8168_mac_ocp_write_seq() and
> r8168_mac_ocp_modify_seq() with a sinqle lock/unlock, these calls reduce overall
> lock contention.
>
> Fixes: ef712ede3541d ("r8169: add helper r8168_mac_ocp_modify")
> Fixes: 6e1d0b8988188 ("r8169:add support for RTL8168H and RTL8107E")
> Cc: Heiner Kallweit <hkallweit1@gmail.com>
> Cc: Marco Elver <elver@google.com>
> Cc: nic_swsd@realtek.com
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Eric Dumazet <edumazet@google.com>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Paolo Abeni <pabeni@redhat.com>
> Cc: netdev@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Link: https://lore.kernel.org/lkml/20231028005153.2180411-1-mirsad.todorovac@alu.unizg.hr/
> Link: https://lore.kernel.org/lkml/20231028110459.2644926-1-mirsad.todorovac@alu.unizg.hr/
> Signed-off-by: Mirsad Goran Todorovac <mirsad.todorovac@alu.unizg.hr>
> ---
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
next prev parent reply other threads:[~2023-10-30 21:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-29 11:04 [PATCH v4 1/5] r8169: Coalesce r8169_mac_ocp_write/modify calls to reduce spinlock stalls Mirsad Goran Todorovac
2023-10-29 11:04 ` [PATCH v4 2/5] r8169: Coalesce RTL8411b PHY power-down recovery " Mirsad Goran Todorovac
2023-10-30 21:52 ` Jacob Keller
2023-10-29 11:04 ` [PATCH v4 3/5] r8169: Coalesce mac ocp write and modify for 8168H start to reduce spinlocks Mirsad Goran Todorovac
2023-10-30 21:53 ` Jacob Keller [this message]
2023-10-29 11:04 ` [PATCH v4 4/5] r8169: Coalesce mac ocp commands for 8125 and 8125B start to reduce spinlock contention Mirsad Goran Todorovac
2023-10-30 21:53 ` Jacob Keller
2023-10-29 11:04 ` [PATCH v4 5/5] r8169: Coalesce mac ocp commands for rtl_hw_init_8125 to reduce spinlocks Mirsad Goran Todorovac
2023-10-30 21:54 ` Jacob Keller
2023-10-30 21:50 ` [PATCH v4 1/5] r8169: Coalesce r8169_mac_ocp_write/modify calls to reduce spinlock stalls Jacob Keller
2023-10-30 22:08 ` Heiner Kallweit
2023-10-30 23:14 ` Jacob Keller
2023-10-31 3:51 ` Mirsad Todorovac
2023-10-31 19:46 ` Jacob Keller
2023-11-01 0:35 ` Mirsad Todorovac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef101904-a615-4527-8d8f-1f43b3d997f6@intel.com \
--to=jacob.e.keller@intel.com \
--cc=baolu.lu@linux.intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=elver@google.com \
--cc=hkallweit1@gmail.com \
--cc=iommu@lists.linux.dev \
--cc=jgg@ziepe.ca \
--cc=joro@8bytes.org \
--cc=jroedel@suse.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mirsad.todorovac@alu.unizg.hr \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=pabeni@redhat.com \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox