From: Lu Baolu <baolu.lu@linux.intel.com>
To: John Garry <john.garry@huawei.com>,
dwmw2@infradead.org, joro@8bytes.org, will@kernel.org
Cc: robin.murphy@arm.com, iommu@lists.linux-foundation.org,
linuxarm@huawei.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] iommu/vt-d: Remove IOVA domain rcache flushing for CPU offlining
Date: Tue, 23 Mar 2021 09:57:13 +0800 [thread overview]
Message-ID: <f1743fc8-3968-2977-27fe-19b4a3babef9@linux.intel.com> (raw)
In-Reply-To: <1614600741-15696-3-git-send-email-john.garry@huawei.com>
On 3/1/21 8:12 PM, John Garry wrote:
> Now that the core code handles flushing per-IOVA domain CPU rcaches,
> remove the handling here.
>
> Signed-off-by: John Garry <john.garry@huawei.com>
> ---
> drivers/iommu/intel/iommu.c | 31 -------------------------------
> include/linux/cpuhotplug.h | 1 -
> 2 files changed, 32 deletions(-)
>
> diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c
> index ee0932307d64..d1e66e1b07b8 100644
> --- a/drivers/iommu/intel/iommu.c
> +++ b/drivers/iommu/intel/iommu.c
> @@ -4065,35 +4065,6 @@ static struct notifier_block intel_iommu_memory_nb = {
> .priority = 0
> };
>
> -static void free_all_cpu_cached_iovas(unsigned int cpu)
> -{
> - int i;
> -
> - for (i = 0; i < g_num_of_iommus; i++) {
> - struct intel_iommu *iommu = g_iommus[i];
> - struct dmar_domain *domain;
> - int did;
> -
> - if (!iommu)
> - continue;
> -
> - for (did = 0; did < cap_ndoms(iommu->cap); did++) {
> - domain = get_iommu_domain(iommu, (u16)did);
> -
> - if (!domain || domain->domain.type != IOMMU_DOMAIN_DMA)
> - continue;
> -
> - iommu_dma_free_cpu_cached_iovas(cpu, &domain->domain);
> - }
> - }
> -}
> -
> -static int intel_iommu_cpu_dead(unsigned int cpu)
> -{
> - free_all_cpu_cached_iovas(cpu);
> - return 0;
> -}
> -
> static void intel_disable_iommus(void)
> {
> struct intel_iommu *iommu = NULL;
> @@ -4388,8 +4359,6 @@ int __init intel_iommu_init(void)
> bus_set_iommu(&pci_bus_type, &intel_iommu_ops);
> if (si_domain && !hw_pass_through)
> register_memory_notifier(&intel_iommu_memory_nb);
> - cpuhp_setup_state(CPUHP_IOMMU_INTEL_DEAD, "iommu/intel:dead", NULL,
> - intel_iommu_cpu_dead);
>
> down_read(&dmar_global_lock);
> if (probe_acpi_namespace_devices())
> diff --git a/include/linux/cpuhotplug.h b/include/linux/cpuhotplug.h
> index cedac9986557..85996494bec1 100644
> --- a/include/linux/cpuhotplug.h
> +++ b/include/linux/cpuhotplug.h
> @@ -57,7 +57,6 @@ enum cpuhp_state {
> CPUHP_PAGE_ALLOC_DEAD,
> CPUHP_NET_DEV_DEAD,
> CPUHP_PCI_XGENE_DEAD,
> - CPUHP_IOMMU_INTEL_DEAD,
> CPUHP_IOMMU_IOVA_DEAD,
> CPUHP_LUSTRE_CFS_DEAD,
> CPUHP_AP_ARM_CACHE_B15_RAC_DEAD,
>
Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com>
Best regards,
baolu
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2021-03-23 2:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-01 12:12 [PATCH 0/3] iommu/iova: Add CPU hotplug handler to flush rcaches to core code John Garry
2021-03-01 12:12 ` [PATCH 1/3] iova: Add CPU hotplug handler to flush rcaches John Garry
2021-03-23 12:45 ` Robin Murphy
2021-03-01 12:12 ` [PATCH 2/3] iommu/vt-d: Remove IOVA domain rcache flushing for CPU offlining John Garry
2021-03-23 1:57 ` Lu Baolu [this message]
2021-03-01 12:12 ` [PATCH 3/3] iova: Correct comment for free_cpu_cached_iovas() John Garry
2021-03-23 13:05 ` Robin Murphy
2021-03-23 13:56 ` John Garry
2021-03-22 17:55 ` [PATCH 0/3] iommu/iova: Add CPU hotplug handler to flush rcaches to core code John Garry
2021-04-07 8:04 ` Joerg Roedel
2021-04-07 8:08 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1743fc8-3968-2977-27fe-19b4a3babef9@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=john.garry@huawei.com \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox