From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE1CCC55ABD for ; Wed, 11 Nov 2020 02:25:07 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E5D3B221F7 for ; Wed, 11 Nov 2020 02:25:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E5D3B221F7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id CE135275A5; Wed, 11 Nov 2020 02:25:04 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id V406tU8vbL2f; Wed, 11 Nov 2020 02:25:03 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by silver.osuosl.org (Postfix) with ESMTP id DD69A273E3; Wed, 11 Nov 2020 02:25:02 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 9D9B6C0889; Wed, 11 Nov 2020 02:25:02 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 30B67C016F for ; Wed, 11 Nov 2020 02:25:01 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 1A2C8874E7 for ; Wed, 11 Nov 2020 02:25:01 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RpNRrKoz99ij for ; Wed, 11 Nov 2020 02:25:00 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by hemlock.osuosl.org (Postfix) with ESMTPS id DC4C5874CE for ; Wed, 11 Nov 2020 02:24:59 +0000 (UTC) IronPort-SDR: STVWXYqSfRsiTR47yK6pLLvJJ9U9sh/s36BJCy9HFApVl8jFntcO0B9SIRK0myJ11ug4in8807 7JhdQdEVb/6g== X-IronPort-AV: E=McAfee;i="6000,8403,9801"; a="157090911" X-IronPort-AV: E=Sophos;i="5.77,468,1596524400"; d="scan'208";a="157090911" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2020 18:24:58 -0800 IronPort-SDR: 8rD9KYDd9c9o09kFAFh7gnes01OWReGVvpAsRgAj2qvld/255rxlpJb7v6lemXrgQ/N5Mjtw+n gQJt8W2it05g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,468,1596524400"; d="scan'208";a="365763534" Received: from allen-box.sh.intel.com (HELO [10.239.159.28]) ([10.239.159.28]) by FMSMGA003.fm.intel.com with ESMTP; 10 Nov 2020 18:24:55 -0800 Subject: Re: [PATCH v2] iommu/vt-d: avoid unnecessory panic if iommu init fail in tboot system To: Zhenzhong Duan , linux-kernel@vger.kernel.org References: <20201110071908.3133-1-zhenzhong.duan@gmail.com> From: Lu Baolu Message-ID: Date: Wed, 11 Nov 2020 10:17:56 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201110071908.3133-1-zhenzhong.duan@gmail.com> Content-Language: en-US Cc: x86@kernel.org, tboot-devel@lists.sourceforge.net, ning.sun@intel.com, iommu@lists.linux-foundation.org, mingo@redhat.com, bp@alien8.de, tglx@linutronix.de, dwmw2@infradead.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" Hi Zhenzhong, On 11/10/20 3:19 PM, Zhenzhong Duan wrote: > "intel_iommu=off" command line is used to disable iommu but iommu is force > enabled in a tboot system for security reason. > > However for better performance on high speed network device, a new option > "intel_iommu=tboot_noforce" is introduced to disable the force on. > > By default kernel should panic if iommu init fail in tboot for security > reason, but it's unnecessory if we use "intel_iommu=tboot_noforce,off". > > Fix the code setting force_on and move intel_iommu_tboot_noforce > from tboot code to intel iommu code. > > Fixes: 7304e8f28bb2 ("iommu/vt-d: Correctly disable Intel IOMMU force on") > Signed-off-by: Zhenzhong Duan Thanks for the patch. Acked-by: Lu Baolu Best regards, baolu > --- > v2: move ckeck of intel_iommu_tboot_noforce into iommu code per Baolu. > > arch/x86/kernel/tboot.c | 3 --- > drivers/iommu/intel/iommu.c | 5 +++-- > include/linux/intel-iommu.h | 1 - > 3 files changed, 3 insertions(+), 6 deletions(-) > > diff --git a/arch/x86/kernel/tboot.c b/arch/x86/kernel/tboot.c > index 992fb14..420be87 100644 > --- a/arch/x86/kernel/tboot.c > +++ b/arch/x86/kernel/tboot.c > @@ -514,9 +514,6 @@ int tboot_force_iommu(void) > if (!tboot_enabled()) > return 0; > > - if (intel_iommu_tboot_noforce) > - return 1; > - > if (no_iommu || swiotlb || dmar_disabled) > pr_warn("Forcing Intel-IOMMU to enabled\n"); > > diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c > index 1b1ca63..4d9b298 100644 > --- a/drivers/iommu/intel/iommu.c > +++ b/drivers/iommu/intel/iommu.c > @@ -179,7 +179,7 @@ static inline unsigned long virt_to_dma_pfn(void *p) > * (used when kernel is launched w/ TXT) > */ > static int force_on = 0; > -int intel_iommu_tboot_noforce; > +static int intel_iommu_tboot_noforce; > static int no_platform_optin; > > #define ROOT_ENTRY_NR (VTD_PAGE_SIZE/sizeof(struct root_entry)) > @@ -4885,7 +4885,8 @@ int __init intel_iommu_init(void) > * Intel IOMMU is required for a TXT/tboot launch or platform > * opt in, so enforce that. > */ > - force_on = tboot_force_iommu() || platform_optin_force_iommu(); > + force_on = (!intel_iommu_tboot_noforce && tboot_force_iommu()) || > + platform_optin_force_iommu(); > > if (iommu_init_mempool()) { > if (force_on) > diff --git a/include/linux/intel-iommu.h b/include/linux/intel-iommu.h > index fbf5b3e..d956987 100644 > --- a/include/linux/intel-iommu.h > +++ b/include/linux/intel-iommu.h > @@ -798,7 +798,6 @@ struct context_entry *iommu_context_addr(struct intel_iommu *iommu, u8 bus, > extern int iommu_calculate_max_sagaw(struct intel_iommu *iommu); > extern int dmar_disabled; > extern int intel_iommu_enabled; > -extern int intel_iommu_tboot_noforce; > extern int intel_iommu_gfx_mapped; > #else > static inline int iommu_calculate_agaw(struct intel_iommu *iommu) > _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu