From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2081.outbound.protection.outlook.com [40.107.244.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B11747DA90 for ; Fri, 16 Aug 2024 05:20:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.244.81 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723785605; cv=fail; b=reDE/djwfqJJ2eqTVakhNtSfVf1pZcyeulVEx2QQI1Iv7R/YGu8KY6Gq6tpxpFo+Ag6Y9NPG5jz+ff6LYQBNpNDi/ovJTOc+7cKyGzf6Wxp3APIyHeDn73+AHi/H/C8b4PMRbaRxaxvxvwInoI+z/q+N5BotVxaLearUf+EH+Cw= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723785605; c=relaxed/simple; bh=lVmQlPLnxCBP556MGSGALRialpvDjeG6el61j+2DdRY=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=tpX2HMPk2djD3TgIHGVeSpMztueNrMlltLkc1GNmvifqVqKV6xuLEGG5+YpI3K52EHnBHzhtPquzZarhSt75iUQreVvPyjihjMFdEZp5enxHim24OMjuaBdBQ782neyuSWWpmiEJIA8I4iSc/bRPHgSPowq0VsL39v3mjN6/wdA= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=0MRMAgLJ; arc=fail smtp.client-ip=40.107.244.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="0MRMAgLJ" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=MLaMWqUEdzpCXZL9s0T71dpqhlhp6bbHziq+Lplnox7h9pyXi7T4OHLwPllQXAOCISjfs21t5KADWt+W6wgGZIeHAd5io4EPxoBMhcVYgTtiYyu124K31xuIxh7Jng2hetPttsjsmmbY0deJ6yiHnE42FKQFHHg26/HC8ONo2lNrO0ul9ayRdhPBwP870bXYbws7Zbnv3Ar+AJkvTUyhWio2H4C9/Xi5qwr1N2pNi+fQIpxM0bcqfBRyQT0B0kcUg7Zh0j+T2jcXGbtageVDoXn0HJRlk4pkqE/UfkPGXDH5mwFmH0ibl44WKBXoqLWyRJSbaL65I394iJyMC+5j5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RsJIqVGB1vZV0+yEiAr38gVxJJeFEcIN8ti5Uy7xGcg=; b=pYGnu/+j/UntifyTi27u50cmm7UdLgLj3FezoP5Yumfdt6oZyx4fPPcFtMCODssnXe9zoxs7C619uMI1Dszy+j9o2Fg6iP+MzSoRN+AmqlYoUSdtAP1Y41nQKd3gG4gr4dCVBO0B8SsBOiL4ALiLGPzUBlh2WdALE93J7LUZu2DkLDg/iWzIFgZ2Qqlt+/D+TLbCG1V/5HLzeCvhIoVUVbpok9pJ0BgsAO/ghiZY5MKdMnY9K8JC1yz7JHpoGU98+s8Co0NHIuqdlIkaYXVDXI3Aocbl6RUAbmLo9YEvV4rpi9fZvcg0XdAfqAwHlbzWeg2Lm/PnAUnRrStQIjL7cA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RsJIqVGB1vZV0+yEiAr38gVxJJeFEcIN8ti5Uy7xGcg=; b=0MRMAgLJVL4k1kR94L+A7rbAfThtwn4NrdAuRqSZ2nDlQuUFYlkPLQKI/8Mah6PIeY6aDKBRIfmKh1U+24IEeUECR4Sl63O12l12bZsZGoOhLU1klSK2pUwnW8oRb2R8W+iFiMgzNMNi4nL8mdkU5KJuQbfWduimfH/OAMEyKZc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DS7PR12MB6048.namprd12.prod.outlook.com (2603:10b6:8:9f::5) by DS0PR12MB6413.namprd12.prod.outlook.com (2603:10b6:8:ce::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7875.19; Fri, 16 Aug 2024 05:20:01 +0000 Received: from DS7PR12MB6048.namprd12.prod.outlook.com ([fe80::6318:26e5:357a:74a5]) by DS7PR12MB6048.namprd12.prod.outlook.com ([fe80::6318:26e5:357a:74a5%5]) with mapi id 15.20.7875.016; Fri, 16 Aug 2024 05:20:01 +0000 Message-ID: Date: Fri, 16 Aug 2024 10:49:52 +0530 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/6] Make set_dev_pasid op supportting domain replacement To: Yi Liu , joro@8bytes.org, jgg@nvidia.com, kevin.tian@intel.com, baolu.lu@linux.intel.com Cc: alex.williamson@redhat.com, robin.murphy@arm.com, eric.auger@redhat.com, nicolinc@nvidia.com, kvm@vger.kernel.org, chao.p.peng@linux.intel.com, iommu@lists.linux.dev References: <20240628085538.47049-1-yi.l.liu@intel.com> <99f66c8d-57cf-4f0d-8545-b019dcf78a94@amd.com> <06f5fc87-b414-4266-a17a-cb2b86111e7a@intel.com> Content-Language: en-US From: Vasant Hegde In-Reply-To: <06f5fc87-b414-4266-a17a-cb2b86111e7a@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MA1PR01CA0152.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:71::22) To DS7PR12MB6048.namprd12.prod.outlook.com (2603:10b6:8:9f::5) Precedence: bulk X-Mailing-List: iommu@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB6048:EE_|DS0PR12MB6413:EE_ X-MS-Office365-Filtering-Correlation-Id: 2dff1644-d9e9-4dad-7fdc-08dcbdb31403 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|7416014|376014|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?emt4Qnc3bk5HelRVTi9KQ1E0ZE1UVkhlOEs3NDlhd1owdVN2aFJLRm5odSsy?= =?utf-8?B?TDZQNk9yZ3FISmI3bUxvWEttQTRqTE9QeTFIMVBkMnl0WDhhNitnMU54bjFZ?= =?utf-8?B?SSt3cit0ZjJMZENkYjFlOTluMks0Y2NtdmJmbXFsRnpNbXhPYW9oaHFEVUly?= =?utf-8?B?blQwenFJazRSRzVEdUJhRnpzeDk0aE5FbGNzVzdoS1ZpYUJGRk9oNGFXOTRl?= =?utf-8?B?M2piT2pPZnhuM2t4a2txSi85U1FzQmljWDlLY2RFb3E2QkE2RC9sRmRWbzZR?= =?utf-8?B?b2liNkpUVDdGVWVKaG5vMlZLOFB2VDhQRWVCSG84T0FSdnl1ZFBpaWFyRTk0?= =?utf-8?B?MUZXYnpDVkkrT3Rha2xPSmV2NXorcnJ1aFlncjd0cGZqeDdSWDJxbGpuaGhT?= =?utf-8?B?ZktjdXA5aXcvNkEveXdubVFoNDVYRkJxRk9RR0MzWEhreXpIRmtPTytyakhC?= =?utf-8?B?N29sZGJDTjFML1l0aUtNS0RDdEdkSzRjTFlMbUJIYmlOaG5hUDNDS3k2NnZK?= =?utf-8?B?c2Z0cDNSeGNQQ3czQlJycGttRm5zMmUyZ21PSlA3K3VOUzkrM0FRNTA3WVpy?= =?utf-8?B?KzJGYUJNbjVObm1MdzJVMjRDd01CcjRxMnRkdWlmT0l5bm9mVm1aRGp0eHRE?= =?utf-8?B?R21QMFVFa1RWMm5UOGlJaldFbzIyMy96SzdLWUtacjVYVzVkeU11d2tiREVW?= =?utf-8?B?emtMWkdPSTllNG5tNFpuY01zNTg2Z1E5UlhUL1lJbzlGYkJkZ3JqRjJtZXpR?= =?utf-8?B?RlgreE9tRG13aGNjc01rSE5TdkRxb3FaaFNobWtKaDhidW4yL2U2TDNSQWhE?= =?utf-8?B?cHhvdG5VcEhPL0dXN0swV2Z0dVV4ZEVIcTV0L0xNdEZyb2xzSFBFeU8yajd0?= =?utf-8?B?U3BlNm1DNWFGVFc5UWhUbG9mTnRFMGovSVpMYk1YSzM3OEJ0c1dBYk8zcG9s?= =?utf-8?B?TTNWcEs5NHUvWGhZVEZrWEh4RFlKa0dEM3hzK0RsVVg2cU9rbG80UmQrOC94?= =?utf-8?B?bG15N0Zkbk9XU3dkY1lUU3Y4UU1ITk4rcytxeDlJemE2TmlJM3FWWkIwTTEw?= =?utf-8?B?NnJFUGhvWUpIbGRxUXRwd3Q0ZCtiYWcxYVg3V3hVUXZ4WVlINUtmNHUxK2V4?= =?utf-8?B?UUl4ajV4RmhRTzFtUDR5TlpyUUhIc1loaUdVRWQ2Yk00SmdpeEQ5VkNaWHI0?= =?utf-8?B?QzF2Rm5IT0hIdTlPazRabTRoS3hlMU9TS2hWdDBmdklWa3E2cGk0RVF4ZURO?= =?utf-8?B?RTd1MVIxd2tFcExiZHBVM21POGxveXhaZFZ1NDRxOXlZRVVxWGVpSDNoMnQ1?= =?utf-8?B?bC9CM01OaFA2MDlxVnYxUnJjYkhSb3RtS3F6TWpOalJlMDlUQ0dkTC9jdHQw?= =?utf-8?B?QlN5aVZKdXB1Z3M0K0VGZ0Zxajkxd2gxQXQxdTJyY3lvVXE0N1BEQjFxWGhs?= =?utf-8?B?QUdXeXArUEkwRm9wdmpINFVDdS9oTlMyL0tzZERhK2QxSzN5RHptLzB6Rzcr?= =?utf-8?B?M2xFZktDYWk1a2Y2MVlZQTJFQTllVTJhOHRqNGY3dWo4c1VhU0FWRGoraklr?= =?utf-8?B?QitmZVhlMTNwaGhMdlRocE5JYmFYS2haVGRCV0NRSUFCOHhBS0ZlMVNZWGJK?= =?utf-8?B?SDR6Z3BoNVhrd01RTWwwY0loS055Z1krbzBjWlhxUzN4NEltVzFkc1dqNmY4?= =?utf-8?B?L2JUZk85b1ZySm5mTTdNVUFrSXNEYzgyU01YaGxSU3ZWZWlic1YrQzZPTDAr?= =?utf-8?B?WGl1bVp3VFZMYTdFaEw4b1g4T0dBelVhZ3RFbDF2NEZOVHRHN2xaNnRRT0Vu?= =?utf-8?B?WTBXQ3JFUEZlYW5xeDNTUT09?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR12MB6048.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(7416014)(376014)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UzM4bDNSN1d3eHJJVk1jMXA5SkRqeCttenZ3QzAyZFNoNEhveGVvMXR3ZEFT?= =?utf-8?B?MGhjdU90S3U5STlXOUxhcFJIK2Q0cjFZWUNXa0M3RUNuckkveldmVFFlVUpk?= =?utf-8?B?RVF2THVOZ3JjUWtuMzlRazV6WUhJK0ZEY1JRM3YyTER3ckNzdDQzeC8yQThp?= =?utf-8?B?TS9OZ2hkTE9MclcycWwzZGlHVXh2TEdJeWxlODl4MVFWVWdHb1Y2R3I4RkZR?= =?utf-8?B?TGhuTGtHTUdNTkpDNXhmaW9PckJ5L2ZCaXE3QWEzZ2dqVXZ5S1RkVVZOdEJR?= =?utf-8?B?blZZQVA0ak5YYXp0M3RiMUc1RlhpQ2thN0d3Mko2bVNkcGdxd2sveVY5OURa?= =?utf-8?B?V0NUaWd3MXBrSk93RktKT1hMcUxXVkNPUFJaNUNja0s2U1BLQ0R6YlQvR1ZW?= =?utf-8?B?b1MwY3FJSFlBeHNlNW84WWZ5bUsvMmtLUlRXVXdENDZXd1M3T0N5bWtLOGJD?= =?utf-8?B?bFR3L2E0U3NoUjRFSFRRb1ZIdjM2SkNDYU5PblFDUGF0LzUrYXBZUVlPSUNN?= =?utf-8?B?VFk3KzFFekF1U2kxSm1UM1N3cnJDQTlVUS9Ud2xhdGhicFNKK2o5ajJPZWdJ?= =?utf-8?B?Z3VMc1Vzd0VKcGw0RVpza0hPL1FKbTFud3BNOUNwYTZpSUhJaFRDcnVBY2o5?= =?utf-8?B?Um1PQkF0azdUc1JjazgyZE5jTVJTQjFPU1RrOExaK2VLL2s5ajhZdVQ2ZUxk?= =?utf-8?B?VUQzSXIrNnFTSHg1ei9TNml5VllVNzlBUTBoWnBzVWVtaXBVVVU3TzJrYnhL?= =?utf-8?B?ZVo3VG5hYjEvZkhyOFBvMTNPdkV2bVMzWEE4UlRUcVpIM3RyRzVtZDh5WHhZ?= =?utf-8?B?VWhpbWJsVys3bUJHWDRPekRwSFRiVlRlU0QvOUVYb0NWNmo1eGpqVXhDZTEz?= =?utf-8?B?SzN1NmV0QVJKY1Bjank4MmlpRUZmcWYwamlySUkyMlNxK3pwMmxacXJtcGRU?= =?utf-8?B?Q0Uvd2NuMVB5VTJ1cVFFMGVoUjdvU0NvV2VscUdNTGVMU0FHNzJwanlsaDVi?= =?utf-8?B?cXUwRlR3S1htUFJRMlBqbTNCQTlWL2ZzSks1UWRXQkxKdDBTNzBFeVlhL0h0?= =?utf-8?B?bVArVEFkdWk0VUxHZ2xvNHd4cm0xRHJpR0JKYytxdFJ5N3AvZHI0QVJrR1By?= =?utf-8?B?Rkg3cnlFSzZlUjBDbEgzM05zYmtkY3pYR0JzTU9teDhrYkNtYlpXR2l6UGQ1?= =?utf-8?B?MkNpQnB4djZXWVkzSUtOY1dWeGEzMnNqck5ubDdpenhoTllscXlxSk15MWV4?= =?utf-8?B?d2pSb05vWlVHbTQ2bGMrWGhUNGY2bGhFQ0poREZsWjVyMkhJZFE2WGdJZ2RQ?= =?utf-8?B?R0tmSWxMM1pnSnVpMjNlWnpSVmdVdklCQ2ZJTUFSc0VYQlRERUpVOWRDajQw?= =?utf-8?B?ZkQrem92TDlNdERYS2RLS2NwU1ZuUm44aDFVVTRHTy9xL3Y0R2lINmJyWC8z?= =?utf-8?B?bTNsaDJSeGU0R2s5c0tQV3ptMmFsNG0wRjRJUENDd2V2bTZLTzNvaE1wN1kz?= =?utf-8?B?Um55WDU5RkVmZkh1YVlSNUErdXJka25xSGtpWjM3c2RXWkdYZk1mMEFSN3Mz?= =?utf-8?B?SDE2bEFnajVVZnV1aWg3NnIzSnV1dHRHTzN6S0NiTWJzNTduVGdSRW04SGdy?= =?utf-8?B?VzY1SktZZGFjRkJZU0JubzJCcnc5eG0vLy84Z082MTVjR3kzdlVaeWhVaXRI?= =?utf-8?B?OElvY290YmhNQjlDL1IxbnVQNnFXdzRseEx3Z1NxZEtJNWlUbVp6TjFmdmdO?= =?utf-8?B?a3JDQVRWYVBVcittaXlrNFE3VXd5c2NDNDAvVVRJY0t5c2U3cE93eGptQVl4?= =?utf-8?B?VHRmOVJsb3RpRUdWZFNKWC9zOFI5QXJGamJmZWVqZklvUzFZUnJLbXV4Q2V5?= =?utf-8?B?RDlTdjhFU3FLc28yREJpSXJ3bXRLS3NFMGRncVJzQmFyM1o1N2VsUFVWdDNG?= =?utf-8?B?bjlxaklBWVFXbjFDYjdINFVUQ1R1dlFCZWJIdXZxSXdJanpnQ3NySHIrNUZB?= =?utf-8?B?QnRqbWgvSTNpM04xYjJjQmRaU1JwbGtZa3YrZFF2a1gwUDI3QmZvUDRwdlRS?= =?utf-8?B?dnRKZ09TdlJqWkJERHhoZGNCME0vbk8wMlM4RTNkcE9yYjJQa0VXbnRlZlJJ?= =?utf-8?Q?cO00MZhZlZ/0IBo7uh+lYcVXg?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2dff1644-d9e9-4dad-7fdc-08dcbdb31403 X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB6048.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Aug 2024 05:20:01.5266 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5P/Oi6kkskYqzNG5uiR9C/Xy1B1+DY/dE92NkP1iex0W+enY5ehFeKaRWMACMs8xqJwZRTkr/YWPVe8P4ApXxQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB6413 Yi, On 8/16/2024 6:49 AM, Yi Liu wrote: > On 2024/8/16 01:49, Vasant Hegde wrote: >> Hi All, >> >> On 6/28/2024 2:25 PM, Yi Liu wrote: >>> This splits the preparation works of the iommu and the Intel iommu driver >>> out from the iommufd pasid attach/replace series. [1] >>> >>> To support domain replacement, the definition of the set_dev_pasid op >>> needs to be enhanced. Meanwhile, the existing set_dev_pasid callbacks >>> should be extended as well to suit the new definition. >> >> IIUC this will remove PASID from old SVA domain and attaches to new SVA domain. >> (basically attaching same dev/PASID to different process). Is that the correct? > > In brief, yes. But it's not only for SVA domain. Remember that SIOVr1 > extends the usage of PASID. At least on Intel side, a PASID may be > attached to paging domains. Right. I missed SIOV case. > >> So the expectation is replace existing PASID from PASID table only if old_domain >> is passed. Otherwise sev_dev_pasid() should throw an error right? >> > > yes. If no old_domain passed in, then it is just a normal attachment. As > you are working on AMD iommu, it would be great if you can have a patch to > make the AMD set_dev_pasid() op suit this expectation. Then it can be > incorporated in this series. :)' Sure. It should be simple. I will try to get the patch next week. -Vasant