From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DD69C282CE for ; Mon, 3 Jun 2019 13:07:43 +0000 (UTC) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E39F427FF7 for ; Mon, 3 Jun 2019 13:07:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E39F427FF7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 80A2ADD4; Mon, 3 Jun 2019 13:07:42 +0000 (UTC) Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 451E7DC1 for ; Mon, 3 Jun 2019 13:07:41 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from foss.arm.com (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by smtp1.linuxfoundation.org (Postfix) with ESMTP id E246083A for ; Mon, 3 Jun 2019 13:07:40 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 885F815A2; Mon, 3 Jun 2019 06:07:40 -0700 (PDT) Received: from [10.1.196.75] (e110467-lin.cambridge.arm.com [10.1.196.75]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 995BC3F5AF; Mon, 3 Jun 2019 06:07:39 -0700 (PDT) Subject: Re: [PATCH] iommu: replace single-char identifiers in macros To: Qian Cai , jroedel@suse.de References: <1559566783-13627-1-git-send-email-cai@lca.pw> From: Robin Murphy Message-ID: Date: Mon, 3 Jun 2019 14:07:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <1559566783-13627-1-git-send-email-cai@lca.pw> Content-Language: en-GB Cc: akpm@linux-foundation.org, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: iommu-bounces@lists.linux-foundation.org Errors-To: iommu-bounces@lists.linux-foundation.org On 03/06/2019 13:59, Qian Cai wrote: > There are a few macros in IOMMU have single-char identifiers make the > code hard to read and debug. Replace them with meaningful names. > > Suggested-by: Andrew Morton > Signed-off-by: Qian Cai > --- > include/linux/dmar.h | 14 ++++++++------ > 1 file changed, 8 insertions(+), 6 deletions(-) > > diff --git a/include/linux/dmar.h b/include/linux/dmar.h > index f8af1d770520..eb634912f475 100644 > --- a/include/linux/dmar.h > +++ b/include/linux/dmar.h > @@ -104,12 +104,14 @@ static inline bool dmar_rcu_check(void) > > #define dmar_rcu_dereference(p) rcu_dereference_check((p), dmar_rcu_check()) > > -#define for_each_dev_scope(a, c, p, d) \ > - for ((p) = 0; ((d) = (p) < (c) ? dmar_rcu_dereference((a)[(p)].dev) : \ > - NULL, (p) < (c)); (p)++) > - > -#define for_each_active_dev_scope(a, c, p, d) \ > - for_each_dev_scope((a), (c), (p), (d)) if (!(d)) { continue; } else > +#define for_each_dev_scope(devs, cnt, i, tmp) \ > + for ((i) = 0; ((tmp) = (i) < (cnt) ? \ Given that "tmp" actually appears to be some sort of device cursor, I'm not sure that that naming really achieves the stated goal of clarity :/ Robin. > + dmar_rcu_dereference((devs)[(i)].dev) : NULL, (i) < (cnt)); \ > + (i)++) > + > +#define for_each_active_dev_scope(devs, cnt, i, tmp) \ > + for_each_dev_scope((devs), (cnt), (i), (tmp)) \ > + if (!(tmp)) { continue; } else > > extern int dmar_table_init(void); > extern int dmar_dev_scope_init(void); > _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu