Linux IOMMU Development
 help / color / mirror / Atom feed
From: "Nan Xiao" <xiaonan19830818-9uewiaClKEY@public.gmane.org>
To: dwmw2 <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
	joro <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
Cc: iommu
	<iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>,
	linux-kernel
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: [PATCH] Fix bug in iommu_context_addr: Always get pointer to lower extended-context-table
Date: Fri, 21 Aug 2015 18:32:17 +0800	[thread overview]
Message-ID: <tencent_662442777F92AABA3F0927FE@qq.com> (raw)

Hi David & Joerg,

In iommu_context_addr() function, we always use lower extended-context-table
even though upper-half of the extended root-entry is present.

Signed-off-by: Nan Xiao <nan-IAhD+5PxXTI3bvoXafbxaA@public.gmane.org>
---
 drivers/iommu/intel-iommu.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c
index 0649b94..4213598 100644
--- a/drivers/iommu/intel-iommu.c
+++ b/drivers/iommu/intel-iommu.c
@@ -759,10 +759,11 @@ static inline struct context_entry *iommu_context_addr(struct intel_iommu *iommu
 		if (devfn >= 0x80) {
 			devfn -= 0x80;
 			entry = &root->hi;
-		}
+		} else
+			entry = &root->lo;
 		devfn *= 2;
-	}
-	entry = &root->lo;
+	} else
+		entry = &root->lo;
 	if (*entry & 1)
 		context = phys_to_virt(*entry & VTD_PAGE_MASK);
 	else {
-- 
2.4.3

Best Regards
Nan Xiao

             reply	other threads:[~2015-08-21 10:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-21 10:32 Nan Xiao [this message]
  -- strict thread matches above, loose matches on Subject: below --
2015-08-24  6:26 [PATCH] Fix bug in iommu_context_addr: Always get pointer to lower extended-context-table Xiao, Nan (Nan@HPS Performance, Beijing)
     [not found] ` <F9D82F0D71C0024FA18FE771EDDAF149081FAC8F-qhK1pdpzgV8SZAcGdq5asR6epYMZPwEe5NbjCUgZEJk@public.gmane.org>
2015-08-25  8:42   ` joro-zLv9SwRftAIdnm+yROfE0A
     [not found]     ` <20150825084208.GB32055-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2015-08-25  8:46       ` Xiao, Nan (Nan@HPservers-Core-OE-PSC)
     [not found]         ` <F9D82F0D71C0024FA18FE771EDDAF149082020ED-aJCdeS5/g6oSZAcGdq5asR6epYMZPwEe5NbjCUgZEJk@public.gmane.org>
2015-08-25  8:59           ` joro-zLv9SwRftAIdnm+yROfE0A
     [not found]             ` <20150825085937.GD32055-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2015-08-25  9:15               ` Xiao, Nan (Nan@HPservers-Core-OE-PSC)
2015-08-25  9:42                 ` joro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tencent_662442777F92AABA3F0927FE@qq.com \
    --to=xiaonan19830818-9uewiaclkey@public.gmane.org \
    --cc=dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
    --cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox