From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mitchel Humpherys Subject: Re: [PATCH v3 1/2] iopoll: Introduce memory-mapped IO polling macros Date: Mon, 29 Sep 2014 09:47:34 -0700 Message-ID: References: <1411874849-343-1-git-send-email-mitchelh@codeaurora.org> <1411874849-343-2-git-send-email-mitchelh@codeaurora.org> <20140929083136.GG12506@ulmo> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20140929083136.GG12506@ulmo> (Thierry Reding's message of "Mon, 29 Sep 2014 10:31:37 +0200") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Thierry Reding Cc: Will Deacon , iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Matt Wagantall , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: iommu@lists.linux-foundation.org On Mon, Sep 29 2014 at 01:31:37 AM, Thierry Reding wrote: > On Sat, Sep 27, 2014 at 08:27:28PM -0700, Mitchel Humpherys wrote: >> From: Matt Wagantall >> >> It is sometimes necessary to poll a memory-mapped register until its >> value satisfies some condition. Introduce a family of convenience macros >> that do this. Tight-loop and sleeping versions are provided with and >> without timeouts. >> >> Cc: Thierry Reding >> Cc: Will Deacon >> Signed-off-by: Matt Wagantall >> Signed-off-by: Mitchel Humpherys >> --- >> include/linux/iopoll.h | 77 ++++++++++++++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 77 insertions(+) >> create mode 100644 include/linux/iopoll.h > > It would be good to provide a changelog with each new version of the > patch. As it is I now have v2 and v3 of this patch in my inbox and I > have no idea what the differences are, so I'd need to download both > and run them through interdiff to find out. Yeah I put the changelog in the cover letter. There were no changes on this patch, though I admit that wasn't entirely clear now re-reading the cover letter text. I also didn't account for the fact that you probably aren't reading the whole series since I only Cc'd you on this patch, not the whole series. In any case, I probably shouldn't have re-sent the whole series after one minor modification to one patch in the series. -Mitch -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation