* [RESEND] kernel version build number in .deb to low by 1. [REGRESSION][BISECTED]
@ 2018-11-05 14:24 Doug Smythies
2018-11-06 4:19 ` Masahiro Yamada
2018-11-08 5:10 ` Doug Smythies
0 siblings, 2 replies; 3+ messages in thread
From: Doug Smythies @ 2018-11-05 14:24 UTC (permalink / raw)
To: 'Masahiro Yamada', 'Riku Voipio', linux-kbuild
Cc: 'Doug Smythies'
On 2018.08.27 23:06 Doug Smythies wrote:
> Hi,
>
> For my kernel compiles the build number included in resulting .deb files is too low by 1.
> Example:
>
> $ uname -a
> Linux s15 4.19.0-rc1-stock #488 SMP PREEMPT Mon Aug 27 12:09:05 PDT 2018 x86_64 x86_64 x86_64 GNU/Linux
>
> Observe build number 488 (this is the correct build number, or so I think).
>
> $ dpkg -l | grep 4.19.0-rc1
> ii linux-headers-4.19.0-rc1-stock 4.19.0-rc1-stock-487 amd64 Linux kernel headers for 4.19.0-rc1-stock on amd64
> ii linux-image-4.19.0-rc1-stock 4.19.0-rc1-stock-487 amd64 Linux kernel, version 4.19.0-rc1-stock
>
> $ ls -l ../*4.19.0-rc1*
> -rw-rw-r-- 1 doug doug 1907 Aug 27 12:18 ../linux-4.19.0-rc1-stock_4.19.0-rc1-stock-487_amd64.changes
> -rw-r--r-- 1 doug doug 11484822 Aug 27 12:16 ../linux-headers-4.19.0-rc1-stock_4.19.0-rc1-stock-487_amd64.deb
> -rw-r--r-- 1 doug doug 54224118 Aug 27 12:18 ../linux-image-4.19.0-rc1-stock_4.19.0-rc1-stock-487_amd64.deb
> -rw-r--r-- 1 doug doug 1019908 Aug 27 12:16 ../linux-libc-dev_4.19.0-rc1-stock-487_amd64.deb
>
> Observe build number 487.
>
> I bisected the kernel, and the result was:
>
> b41d920acff8305b8a25a183a8e4d41b8975097d is the first bad commit
> commit b41d920acff8305b8a25a183a8e4d41b8975097d
> Author: Riku Voipio <riku.voipio@linaro.org>
> Date: Thu Apr 5 14:22:29 2018 +0300
>
> kbuild: deb-pkg: split generating packaging and build>
>
> Move debian/ directory generation out of builddeb to a new script,
> mkdebian. The package build commands are kept in builddeb, which
> is now an internal command called from debian/rules.
>
> With these changes in place, we can now use dpkg-buildpackage from
> deb-pkg and bindeb-pkg removing need for handrolled source/changes
> generation.
>
> This patch is based on the criticism of the current state of builddeb
> discussed on:
>
> https://patchwork.kernel.org/patch/9656403/
>
> Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>
> I am not familiar with this stuff and was not able to figure out
> a solution to propose a patch to correct it.
>
> In case it is relevant, my compile command was:
>
> time make -j9 olddefconfig bindeb-pkg LOCALVERSION=-stock
This issue is still present in kernel 4.20-rc1.
$ uname -a
Linux s15 4.20.0-rc1-stock #514 SMP PREEMPT Sun Nov 4 20:24:42 PST 2018 x86_64 x86_64 x86_64 GNU/Linux
$ ls -l ../*4.20.0-rc1-stock*
-rw-rw-r-- 1 doug doug 1907 Nov 4 20:34 ../linux-4.20.0-rc1-stock_4.20.0-rc1-stock-513_amd64.changes
-rw-r--r-- 1 doug doug 11604134 Nov 4 20:32 ../linux-headers-4.20.0-rc1-stock_4.20.0-rc1-stock-513_amd64.deb
-rw-r--r-- 1 doug doug 54504040 Nov 4 20:34 ../linux-image-4.20.0-rc1-stock_4.20.0-rc1-stock-513_amd64.deb
-rw-r--r-- 1 doug doug 1028788 Nov 4 20:32 ../linux-libc-dev_4.20.0-rc1-stock-513_amd64.deb
... Doug
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RESEND] kernel version build number in .deb to low by 1. [REGRESSION][BISECTED]
2018-11-05 14:24 [RESEND] kernel version build number in .deb to low by 1. [REGRESSION][BISECTED] Doug Smythies
@ 2018-11-06 4:19 ` Masahiro Yamada
2018-11-08 5:10 ` Doug Smythies
1 sibling, 0 replies; 3+ messages in thread
From: Masahiro Yamada @ 2018-11-06 4:19 UTC (permalink / raw)
To: dsmythies; +Cc: Riku Voipio, Linux Kbuild mailing list
Hi,
On Mon, Nov 5, 2018 at 11:32 PM Doug Smythies <dsmythies@telus.net> wrote:
>
> On 2018.08.27 23:06 Doug Smythies wrote:
>
> > Hi,
> >
> > For my kernel compiles the build number included in resulting .deb files is too low by 1.
> > Example:
> >
> > $ uname -a
> > Linux s15 4.19.0-rc1-stock #488 SMP PREEMPT Mon Aug 27 12:09:05 PDT 2018 x86_64 x86_64 x86_64 GNU/Linux
> >
> > Observe build number 488 (this is the correct build number, or so I think).
> >
> > $ dpkg -l | grep 4.19.0-rc1
> > ii linux-headers-4.19.0-rc1-stock 4.19.0-rc1-stock-487 amd64 Linux kernel headers for 4.19.0-rc1-stock on amd64
> > ii linux-image-4.19.0-rc1-stock 4.19.0-rc1-stock-487 amd64 Linux kernel, version 4.19.0-rc1-stock
> >
> > $ ls -l ../*4.19.0-rc1*
> > -rw-rw-r-- 1 doug doug 1907 Aug 27 12:18 ../linux-4.19.0-rc1-stock_4.19.0-rc1-stock-487_amd64.changes
> > -rw-r--r-- 1 doug doug 11484822 Aug 27 12:16 ../linux-headers-4.19.0-rc1-stock_4.19.0-rc1-stock-487_amd64.deb
> > -rw-r--r-- 1 doug doug 54224118 Aug 27 12:18 ../linux-image-4.19.0-rc1-stock_4.19.0-rc1-stock-487_amd64.deb
> > -rw-r--r-- 1 doug doug 1019908 Aug 27 12:16 ../linux-libc-dev_4.19.0-rc1-stock-487_amd64.deb
> >
> > Observe build number 487.
> >
> > I bisected the kernel, and the result was:
> >
> > b41d920acff8305b8a25a183a8e4d41b8975097d is the first bad commit
> > commit b41d920acff8305b8a25a183a8e4d41b8975097d
> > Author: Riku Voipio <riku.voipio@linaro.org>
> > Date: Thu Apr 5 14:22:29 2018 +0300
> >
> > kbuild: deb-pkg: split generating packaging and build>
> >
> > Move debian/ directory generation out of builddeb to a new script,
> > mkdebian. The package build commands are kept in builddeb, which
> > is now an internal command called from debian/rules.
> >
> > With these changes in place, we can now use dpkg-buildpackage from
> > deb-pkg and bindeb-pkg removing need for handrolled source/changes
> > generation.
> >
> > This patch is based on the criticism of the current state of builddeb
> > discussed on:
> >
> > https://patchwork.kernel.org/patch/9656403/
> >
> > Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
> > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> >
> > I am not familiar with this stuff and was not able to figure out
> > a solution to propose a patch to correct it.
> >
> > In case it is relevant, my compile command was:
> >
> > time make -j9 olddefconfig bindeb-pkg LOCALVERSION=-stock
>
> This issue is still present in kernel 4.20-rc1.
>
> $ uname -a
> Linux s15 4.20.0-rc1-stock #514 SMP PREEMPT Sun Nov 4 20:24:42 PST 2018 x86_64 x86_64 x86_64 GNU/Linux
> $ ls -l ../*4.20.0-rc1-stock*
> -rw-rw-r-- 1 doug doug 1907 Nov 4 20:34 ../linux-4.20.0-rc1-stock_4.20.0-rc1-stock-513_amd64.changes
> -rw-r--r-- 1 doug doug 11604134 Nov 4 20:32 ../linux-headers-4.20.0-rc1-stock_4.20.0-rc1-stock-513_amd64.deb
> -rw-r--r-- 1 doug doug 54504040 Nov 4 20:34 ../linux-image-4.20.0-rc1-stock_4.20.0-rc1-stock-513_amd64.deb
> -rw-r--r-- 1 doug doug 1028788 Nov 4 20:32 ../linux-libc-dev_4.20.0-rc1-stock-513_amd64.deb
>
> ... Doug
>
>
Sorry for the delay.
I just sent a fix-up.
https://patchwork.kernel.org/patch/10669601/
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [RESEND] kernel version build number in .deb to low by 1. [REGRESSION][BISECTED]
2018-11-05 14:24 [RESEND] kernel version build number in .deb to low by 1. [REGRESSION][BISECTED] Doug Smythies
2018-11-06 4:19 ` Masahiro Yamada
@ 2018-11-08 5:10 ` Doug Smythies
1 sibling, 0 replies; 3+ messages in thread
From: Doug Smythies @ 2018-11-08 5:10 UTC (permalink / raw)
To: 'Masahiro Yamada'
Cc: 'Riku Voipio', 'Linux Kbuild mailing list',
Doug Smythies
On 2018.11.05 20:20 Masahiro Yamada wrote:
...[snip]...
> Sorry for the delay.
>
> I just sent a fix-up.
>
> https://patchwork.kernel.org/patch/10669601/
Thank you. I tried your patch and it has fixed the issue.
... Doug
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-11-08 14:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-05 14:24 [RESEND] kernel version build number in .deb to low by 1. [REGRESSION][BISECTED] Doug Smythies
2018-11-06 4:19 ` Masahiro Yamada
2018-11-08 5:10 ` Doug Smythies
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox