Re: [PATCH v2] Kconfig: Added compare capabilities for mconf Ver. 2

[Franco Martelli <martellif67@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1805 bytes --]

On 05/06/25 at 17:05, Miguel Ojeda wrote:
> On Wed, Jun 4, 2025 at 8:37 PM Franco Martelli <martellif67@gmail.com> wrote:
>>
>> Signed-off-by: Franco Martelli <martellif67@gmail.com>
> 
> The commit message is empty -- please see how patches are normally
> structured, for instance by looking at the Git log or, even better, at
> lore.kernel.org.

The commit message is the subject of the email, I used git to send the 
email, this is the command:

$ git send-email --annotate -v2 HEAD^ --to masahiroy@kernel.org --cc 
linux-kbuild@vger.kernel.org

> 
> For instance, what you wrote in "Changelog" is what would go in the
> commit message (typically "changelog" refers to the changes between
> versions of a given patch series).
> 
> In addition, we normally don't describe changes file by file. Instead
> we try to describe changes as logical units. This may also suggest
> possible ways of splitting the patch into smaller pieces.

This is a pain for me, English isn't my native language so I'm not 
fluent with it :( sure that the patch can't be accepted?

> 
> Finally, I would suggest passing the `--base` flag to `git
> format-patch` so that it is clear where this applies (i.e. I am not
> sure why the text mentions it was originally done for 6.1 --
> development should be done in mainline, and re-tested etc. there).

I did it, before to send the email with "git" I gave this command:

$ git format-patch --base HEAD^

As a test now I send as attachment the file patch generated with the 
command:

$ git format-patch --cover-letter --base HEAD^ -o /media/data/

Does the attachment file satisfy your requirement?

> 
> (This is not a review on the contents or the idea/proposal itself, but
> I hope this helps you.)

Thank you very much for your feedback (and patience) :)

-- 
Franco Martelli

[-- Attachment #2: 0001-Kconfig-Added-compare-capabilities-for-mconf-Ver.-2.patch.xz --]
[-- Type: application/x-xz, Size: 5764 bytes --]