From: Xin Li <xin@zytor.com>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
nathan@kernel.org, nicolas@fjasle.eu, bp@alien8.de,
hpa@zytor.com, sraithal@amd.com
Subject: Re: [PATCH v1 1/1] kbuild: Add "make headers" to "make help" output
Date: Mon, 10 Mar 2025 19:19:05 -0700 [thread overview]
Message-ID: <08bbfff0-4aef-4d9e-bbeb-661aedaf3737@zytor.com> (raw)
In-Reply-To: <CAK7LNATGToVHEfZ-hmJ=3xbQCdHmBZf7x9w2QtQVGV-nMiP2Ag@mail.gmail.com>
On 3/10/2025 6:52 PM, Masahiro Yamada wrote:
> On Mon, Mar 10, 2025 at 3:23 PM Xin Li <xin@zytor.com> wrote:
>>
>> On 3/8/2025 7:12 AM, Masahiro Yamada wrote:
>>> On Sat, Mar 8, 2025 at 1:05 PM Xin Li (Intel) <xin@zytor.com> wrote:
>>>>
>>>> Meanwhile explicitly state that the headers are uapi headers.
>>>
>>> There are many internal-use targets, which are not documented in the
>>> help message.
>>> I assume this one is the case.
>>>
>>> If users want to install UAPI headers, 'headers_install' is
>>> the user-visible interface and it is already documented.
>>>
>>>
>>
>> hpa and Boris prefer to add it, which I also agree. But ofc it's your
>> call :)
>>
>> If you don't want to add help for "headers", it probably still makes
>> sense to explicitly state that the headers are uapi headers, no?
>>
>> Thanks!
>> Xin
>
>
> If a help message for "headers" is desired, how about this?
>
> headers - Build read-to-install uapi headers in usr/include
>
LGTM.
I guess you will make the change right now?
Thanks!
Xin
next prev parent reply other threads:[~2025-03-11 2:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-08 4:04 [PATCH v1 1/1] kbuild: Add "make headers" to "make help" output Xin Li (Intel)
2025-03-08 10:34 ` Borislav Petkov
2025-03-08 15:15 ` Masahiro Yamada
2025-03-08 16:34 ` Borislav Petkov
2025-03-08 15:12 ` Masahiro Yamada
2025-03-08 16:01 ` H. Peter Anvin
2025-03-08 16:41 ` Borislav Petkov
2025-03-08 16:47 ` H. Peter Anvin
2025-03-08 16:49 ` Borislav Petkov
2025-03-10 6:22 ` Xin Li
2025-03-11 1:52 ` Masahiro Yamada
2025-03-11 2:13 ` Masahiro Yamada
2025-03-11 2:17 ` Xin Li
2025-03-11 2:19 ` Xin Li [this message]
2025-03-11 2:40 ` Masahiro Yamada
2025-03-11 2:43 ` Xin Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08bbfff0-4aef-4d9e-bbeb-661aedaf3737@zytor.com \
--to=xin@zytor.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=nathan@kernel.org \
--cc=nicolas@fjasle.eu \
--cc=sraithal@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox