From: "Joey Jiao (QUIC)" <quic_jiangenj@quicinc.com>
To: Masahiro Yamada <masahiroy@kernel.org>,
Alexander Potapenko <glider@google.com>
Cc: "kasan-dev@googlegroups.com" <kasan-dev@googlegroups.com>,
"Kevin Ding (QUIC)" <quic_likaid@quicinc.com>,
Andrey Ryabinin <ryabinin.a.a@gmail.com>,
Andrey Konovalov <andreyknvl@gmail.com>,
Dmitry Vyukov <dvyukov@google.com>,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
"Nicolas Schier" <nicolas@fjasle.eu>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-kbuild@vger.kernel.org" <linux-kbuild@vger.kernel.org>,
"Changmin Liu (QUIC)" <quic_changmil@quicinc.com>
Subject: RE: [PATCH] kasan: Add CONFIG_KASAN_WHITELIST_ONLY mode
Date: Mon, 9 Oct 2023 01:14:31 +0000 [thread overview]
Message-ID: <11e5eafbf8ac42fd90491e09e96d8eea@quicinc.com> (raw)
In-Reply-To: <CAK7LNASfdQYy7ON011jQxqd4Bz98CJuvDNCUp2NRrHcK29x3zA@mail.gmail.com>
Right, it will be only useful for low memory kernel where 'KASAN_SANITIZE :=y' has to be added explicitly in local as hotfix.
-----Original Message-----
From: Masahiro Yamada <masahiroy@kernel.org>
Sent: Saturday, September 30, 2023 6:12 PM
To: Alexander Potapenko <glider@google.com>
Cc: Joey Jiao (QUIC) <quic_jiangenj@quicinc.com>; kasan-dev@googlegroups.com; Kevin Ding (QUIC) <quic_likaid@quicinc.com>; Andrey Ryabinin <ryabinin.a.a@gmail.com>; Andrey Konovalov <andreyknvl@gmail.com>; Dmitry Vyukov <dvyukov@google.com>; Vincenzo Frascino <vincenzo.frascino@arm.com>; Nathan Chancellor <nathan@kernel.org>; Nick Desaulniers <ndesaulniers@google.com>; Nicolas Schier <nicolas@fjasle.eu>; linux-kernel@vger.kernel.org; linux-kbuild@vger.kernel.org
Subject: Re: [PATCH] kasan: Add CONFIG_KASAN_WHITELIST_ONLY mode
On Fri, Sep 29, 2023 at 11:06 PM Alexander Potapenko <glider@google.com> wrote:
>
> (CC Masahiro Yamada)
>
> On Thu, Sep 28, 2023 at 6:16 AM Joey Jiao <quic_jiangenj@quicinc.com> wrote:
> >
> > Fow low memory device, full enabled kasan just not work.
> > Set KASAN_SANITIZE to n when CONFIG_KASAN_WHITELIST_ONLY=y.
> > So we can enable kasan for single file or module.
>
> I don't have technical objections here, but it bothers me a bit that
> we are adding support for KASAN_SANITIZE:=y, although nobody will be
> adding KASAN_SANITIZE:=y to upstream Makefiles - only development
> kernels when debugging on low-end devices.
>
> Masahiro, is this something worth having in upstream Kconfig code?
Even if we apply this patch to the upstream, you will end up with adding 'KASAN_SANITIZE :=y'
to the single file/Makefile.
I am not convinced with this patch
since this nod is not so useful standalone.
> > Signed-off-by: Joey Jiao <quic_jiangenj@quicinc.com>
> Reviewed-by: Alexander Potapenko <glider@google.com>
--
Best Regards
Masahiro Yamada
prev parent reply other threads:[~2023-10-09 1:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-28 4:15 [PATCH] kasan: Add CONFIG_KASAN_WHITELIST_ONLY mode Joey Jiao
2023-09-29 14:05 ` Alexander Potapenko
2023-09-30 10:12 ` Masahiro Yamada
2023-10-01 6:58 ` Andrey Konovalov
2023-10-09 1:14 ` Joey Jiao (QUIC) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11e5eafbf8ac42fd90491e09e96d8eea@quicinc.com \
--to=quic_jiangenj@quicinc.com \
--cc=andreyknvl@gmail.com \
--cc=dvyukov@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=nicolas@fjasle.eu \
--cc=quic_changmil@quicinc.com \
--cc=quic_likaid@quicinc.com \
--cc=ryabinin.a.a@gmail.com \
--cc=vincenzo.frascino@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox