public inbox for linux-kbuild@vger.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: kbuild <linux-kbuild@vger.kernel.org>
Cc: Sam Ravnborg <sam@ravnborg.org>
Subject: [PATCH] kconfig: ignore select of unknown symbol
Date: Sat,  2 Feb 2008 21:46:39 +0100	[thread overview]
Message-ID: <1201985204-26589-5-git-send-email-sam@ravnborg.org> (raw)
In-Reply-To: <20080202203503.GA26415@uranus.ravnborg.org>

We have had warnings for a long time about select of unknow symbol
but the warnings does not really makes sense since we may
select a symbol that is relevant and defined in one
arch but not in another arch.
And as long as we do not use a common set of Kconfig files
for all archs lets just ignore this case.

Previously we have used this to find bad uses of
select but we need a more relaible method to do so.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Roman Zippel <zippel@linux-m68k.org>
---
 scripts/kconfig/menu.c |    9 +++------
 1 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c
index fdad173..606ceb9 100644
--- a/scripts/kconfig/menu.c
+++ b/scripts/kconfig/menu.c
@@ -203,12 +203,9 @@ void sym_check_prop(struct symbol *sym)
 				prop_warn(prop,
 				    "config symbol '%s' uses select, but is "
 				    "not boolean or tristate", sym->name);
-			else if (sym2->type == S_UNKNOWN)
-				prop_warn(prop,
-				    "'select' used by config symbol '%s' "
-				    "refers to undefined symbol '%s'",
-				    sym->name, sym2->name);
-			else if (sym2->type != S_BOOLEAN && sym2->type != S_TRISTATE)
+			else if (sym2->type != S_UNKNOWN &&
+			         sym2->type != S_BOOLEAN &&
+			         sym2->type != S_TRISTATE)
 				prop_warn(prop,
 				    "'%s' has wrong type. 'select' only "
 				    "accept arguments of boolean and "
-- 
1.5.4.rc3.14.g44397


  parent reply	other threads:[~2008-02-02 20:46 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-02 20:35 [REVIEW for merge] kbuild updates including silence of section mismatch check Sam Ravnborg
2008-02-02 20:46 ` [PATCH] Remove __INIT_REFOK and __INITDATA_REFOK Sam Ravnborg
2008-02-02 20:46 ` [PATCH] kbuild: Spelling/grammar fixes for config DEBUG_SECTION_MISMATCH Sam Ravnborg
2008-02-02 20:46 ` [PATCH] kbuild: add svn revision information to setlocalversion Sam Ravnborg
2008-02-02 20:46 ` [PATCH] kconfig: mark config as changed when loading an alternate config Sam Ravnborg
2008-02-02 20:46 ` Sam Ravnborg [this message]
2008-02-02 20:46 ` [PATCH] Fix ARM to play nicely with generic Instrumentation menu Sam Ravnborg
2008-02-02 20:46 ` [PATCH] Create arch/Kconfig Sam Ravnborg
2008-02-02 20:46 ` [PATCH] Add HAVE_OPROFILE Sam Ravnborg
2008-02-02 20:46 ` [PATCH] Add HAVE_KPROBES Sam Ravnborg
2008-02-02 20:46 ` [PATCH] Move Kconfig.instrumentation to arch/Kconfig and init/Kconfig Sam Ravnborg
2008-02-02 21:25 ` [REVIEW for merge] kbuild updates including silence of section mismatch check Frans Pop
2008-02-02 21:30   ` Sam Ravnborg
2008-02-03  3:30     ` Bryan Wu
2008-02-03  6:13     ` [PATCH try#2 ] kbuild: add svn revision information to setlocalversion Bryan Wu
2008-02-03 10:04       ` Sam Ravnborg
2008-02-02 22:37 ` [Additional PATCH] kbuild: do not warn about __*init/__*exit symbols being exported Sam Ravnborg
2008-02-05 10:38 ` [REVIEW for merge] kbuild updates including silence of section mismatch check Geert Uytterhoeven
2008-02-06 20:58   ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1201985204-26589-5-git-send-email-sam@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=linux-kbuild@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox