From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org ([18.85.46.34]:39862 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755494AbYFHKtG (ORCPT ); Sun, 8 Jun 2008 06:49:06 -0400 Subject: Re: [PATCH] Speed up "make headers_*" From: David Woodhouse In-Reply-To: <20080608104122.GA10545@uranus.ravnborg.org> References: <20080608094730.GA30098@uranus.ravnborg.org> <19f34abd0806080312j2b09179cpa384a0460af5874e@mail.gmail.com> <20080608104122.GA10545@uranus.ravnborg.org> Content-Type: text/plain Date: Sun, 08 Jun 2008 11:49:01 +0100 Message-Id: <1212922141.32207.495.camel@pmac.infradead.org> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: Sam Ravnborg Cc: Vegard Nossum , linux-kbuild , LKML , Linus Torvalds , Jan Engelhardt On Sun, 2008-06-08 at 12:41 +0200, Sam Ravnborg wrote: > headers_install.pl looks like this now. > I am not happy about the way I call unifdef - can it be > done better? Possibly. unifdef only actually handles "#ifdef __KERNEL__" and "#ifndef __KERNEL__", doesn't it? It shouldn't be too hard to recreate at least that much functionality in perl, surely? Bonus points for making it handle more interesting constructs like "#if defined (KERNEL) || defined (FOO)", and for warning/erroring whenever any ifdefs on CONFIG_xxx would be visible in userspace. But those can come later; we don't have those yet anyway. -- dwmw2