From: Sam Ravnborg <sam@ravnborg.org>
To: lkml <linux-kernel@vger.kernel.org>,
kbuild <linux-kbuild@vger.kernel.org>
Cc: Mike Frysinger <vapier@gentoo.org>, Sam Ravnborg <sam@ravnborg.org>
Subject: [PATCH 3/8] kbuild: introduce $(kecho) convenience echo
Date: Mon, 24 Nov 2008 21:54:50 +0100 [thread overview]
Message-ID: <1227560095-32597-3-git-send-email-sam@ravnborg.org> (raw)
In-Reply-To: <20081124205150.GA32497@uranus.ravnborg.org>
From: Mike Frysinger <vapier@gentoo.org>
There is a bunch of places in the build system where we do 'echo' to show
some nice status lines. This means we still get output when running in
silent mode. So declare a new KECHO variable that only does 'echo' when we
are in a suitable verbose build mode.
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
[sam: added Documentation]
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
Documentation/kbuild/makefiles.txt | 14 ++++++++++++++
scripts/Kbuild.include | 7 +++++++
2 files changed, 21 insertions(+), 0 deletions(-)
diff --git a/Documentation/kbuild/makefiles.txt b/Documentation/kbuild/makefiles.txt
index 7a77533..51104f9 100644
--- a/Documentation/kbuild/makefiles.txt
+++ b/Documentation/kbuild/makefiles.txt
@@ -383,6 +383,20 @@ more details, with real examples.
to prerequisites are referenced with $(src) (because they are not
generated files).
+ $(kecho)
+ echoing information to user in a rule is often a good practice
+ but when execution "make -s" one does not expect to see any output
+ except for warnings/errors.
+ To support this kbuild define $(kecho) which will echo out the
+ text following $(kecho) to stdout except if "make -s" is used.
+
+ Example:
+ #arch/blackfin/boot/Makefile
+ $(obj)/vmImage: $(obj)/vmlinux.gz
+ $(call if_changed,uimage)
+ @$(kecho) 'Kernel: $@ is ready'
+
+
--- 3.11 $(CC) support functions
The kernel may be built with several different versions of
diff --git a/scripts/Kbuild.include b/scripts/Kbuild.include
index 982dcae..e637e28 100644
--- a/scripts/Kbuild.include
+++ b/scripts/Kbuild.include
@@ -25,6 +25,13 @@ basetarget = $(basename $(notdir $@))
escsq = $(subst $(squote),'\$(squote)',$1)
###
+# Easy method for doing a status message
+ kecho := :
+ quiet_kecho := echo
+silent_kecho := :
+kecho := $($(quiet)kecho)
+
+###
# filechk is used to check if the content of a generated file is updated.
# Sample usage:
# define filechk_sample
--
1.5.6.GIT
next prev parent reply other threads:[~2008-11-24 20:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-24 20:51 [GIT] kbuild patches Sam Ravnborg
2008-11-24 20:54 ` [PATCH 1/8] kbuild: expand -I in KBUILD_CPPFLAGS Sam Ravnborg
2008-11-24 20:54 ` [PATCH 2/8] kbuild: kill output in silent mode of mkcompile_h Sam Ravnborg
2008-11-24 20:54 ` Sam Ravnborg [this message]
2008-11-24 20:54 ` [PATCH 4/8] kbuild: use KECHO convenience echo Sam Ravnborg
2008-11-24 20:54 ` [PATCH 5/8] kbuild: teach mkmakfile to be silent Sam Ravnborg
2008-11-24 20:54 ` [PATCH 6/8] remove bashisms from scripts/extract-ikconfig Sam Ravnborg
2008-11-24 20:54 ` [PATCH 7/8] kbuild: gen_init_cpio expands shell variables in file names Sam Ravnborg
2008-11-24 20:54 ` [PATCH 8/8] kbuild: move tags support to a shell script Sam Ravnborg
2008-11-24 22:07 ` Ian Campbell
2008-11-24 23:16 ` Jeff Dike
2008-11-25 9:46 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1227560095-32597-3-git-send-email-sam@ravnborg.org \
--to=sam@ravnborg.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox