From: Sam Ravnborg <sam@ravnborg.org>
To: linux-kbuild <linux-kbuild@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Cc: Sam Ravnborg <sam@ravnborg.org>, Roman Zippel <zippel@linux-m68k.org>
Subject: [PATCH 07/13] kconfig: improve error messages for bad source statements
Date: Mon, 29 Dec 2008 14:53:17 +0100 [thread overview]
Message-ID: <1230558803-7168-7-git-send-email-sam@ravnborg.org> (raw)
In-Reply-To: <20081229134402.GA7069@uranus.ravnborg.org>
We now say where we detect the second source of a file,
and where we detect a recursively source of the same file.
This makes it easier to fix such errors.
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Roman Zippel <zippel@linux-m68k.org>
---
scripts/kconfig/lex.zconf.c_shipped | 7 +++++--
scripts/kconfig/zconf.l | 7 +++++--
2 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/scripts/kconfig/lex.zconf.c_shipped b/scripts/kconfig/lex.zconf.c_shipped
index 7342ce0..dc3e818 100644
--- a/scripts/kconfig/lex.zconf.c_shipped
+++ b/scripts/kconfig/lex.zconf.c_shipped
@@ -2370,11 +2370,14 @@ void zconf_nextfile(const char *name)
current_buf = buf;
if (file->flags & FILE_BUSY) {
- printf("recursive scan (%s)?\n", name);
+ printf("%s:%d: do not source '%s' from itself\n",
+ zconf_curname(), zconf_lineno(), name);
exit(1);
}
if (file->flags & FILE_SCANNED) {
- printf("file %s already scanned?\n", name);
+ printf("%s:%d: file '%s' is already sourced from '%s'\n",
+ zconf_curname(), zconf_lineno(), name,
+ file->parent->name);
exit(1);
}
file->flags |= FILE_BUSY;
diff --git a/scripts/kconfig/zconf.l b/scripts/kconfig/zconf.l
index 5164ef7..21ff69c 100644
--- a/scripts/kconfig/zconf.l
+++ b/scripts/kconfig/zconf.l
@@ -314,11 +314,14 @@ void zconf_nextfile(const char *name)
current_buf = buf;
if (file->flags & FILE_BUSY) {
- printf("recursive scan (%s)?\n", name);
+ printf("%s:%d: do not source '%s' from itself\n",
+ zconf_curname(), zconf_lineno(), name);
exit(1);
}
if (file->flags & FILE_SCANNED) {
- printf("file %s already scanned?\n", name);
+ printf("%s:%d: file '%s' is already sourced from '%s'\n",
+ zconf_curname(), zconf_lineno(), name,
+ file->parent->name);
exit(1);
}
file->flags |= FILE_BUSY;
--
1.6.0.2.GIT
next prev parent reply other threads:[~2008-12-29 13:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-29 13:44 pending kbuild updates Sam Ravnborg
2008-12-29 13:53 ` [PATCH 01/13] m68k: fix recursive dependency in Kconfig Sam Ravnborg
2008-12-29 13:53 ` [PATCH 02/13] kconfig: explain symbol value defaults Sam Ravnborg
2008-12-29 13:53 ` [PATCH 03/13] kconfig: add comments to symbol flags Sam Ravnborg
2008-12-29 13:53 ` [PATCH 04/13] kconfig: struct property commented Sam Ravnborg
2008-12-29 13:53 ` [PATCH 05/13] kconfig: improve readout when we hit recursive dependencies Sam Ravnborg
2008-12-29 13:53 ` [PATCH 06/13] kconfig: print all locations when we see a recursive dependency Sam Ravnborg
2008-12-31 2:55 ` Roman Zippel
2008-12-31 9:05 ` Sam Ravnborg
2009-01-18 20:54 ` Sam Ravnborg
2008-12-29 13:53 ` Sam Ravnborg [this message]
2008-12-29 13:53 ` [PATCH 08/13] headers_check.pl: disallow extern's Sam Ravnborg
2008-12-29 13:53 ` [PATCH 09/13] kbuild: check for leaked CONFIG_ symbols to userspace Sam Ravnborg
2008-12-29 13:53 ` [PATCH 10/13] kbuild: in headers_install autoconvert asm/inline/volatile to __xxx__ Sam Ravnborg
2008-12-29 13:53 ` [PATCH 11/13] kbuild: disable sparse warning "returning void-valued expression" Sam Ravnborg
2008-12-29 13:53 ` [PATCH 12/13] kbuild: make *config usage docs Sam Ravnborg
2008-12-29 13:53 ` [PATCH 13/13] kbuild: document environment variables Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1230558803-7168-7-git-send-email-sam@ravnborg.org \
--to=sam@ravnborg.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox