Re: [PATCH v2] kconfig: check for select dependency errors on config load

Steven Rostedt
2009-02-21T21:54:01Z

On Sat, 21 Feb 2009, Sam Ravnborg wrote:
>
> We do not want to have such hardcoded information
> about the Kconfig structure in the backend.
> Rather we should fix the configuration once and for all so EMBEDDED
> get split into the sensible options is actually is.
>
> Options that come to my mind is:
> OPTIMIZE_FOR_TEXT_SIZE
> OPTIMIZE_FOR_DATA_SIZE
> KERNEL_EXPERT
>
> And we should them make their use of select conform
> like the rest of the kernel configuration.
>
> So the first version of your patch is IMO better - but
> it could use some comments so others better follows what is
> going on. The current level of comments in the kconfig
> source base is not an example to follw

Sounds good. Yeah, the first patch was an RFC mainly because I want
someone to look at the code and tell me "yeah that works" or "No! you
can't do that". Because I spent several hours staring at the kconfig code
trying to figure out WTF it was doing. Luckily, I did have a compiler
writing course and the flex and bison code was fine for me.

I will definitely update the code with comments when I'm more comfortable
with the code.

-- Steve