From: Jaswinder Singh Rajput <jaswinder@kernel.org>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Amerigo Wang <amwang@redhat.com>,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
linux-kbuild@vger.kernel.org,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [Patch 1/2] kbuild: two trivial fixes for check headers
Date: Fri, 05 Jun 2009 07:53:44 +0530 [thread overview]
Message-ID: <1244168624.2522.11.camel@ht.satnam> (raw)
In-Reply-To: <20090604103909.GA10102@uranus.ravnborg.org>
On Thu, 2009-06-04 at 12:39 +0200, Sam Ravnborg wrote:
> So if you touch this I would ask you not to consider a single line
> in jffs-user.h - but rather take a critiacal look at the whole
> file and fix any issues there is.
> And then to send it to the mtd people (dwmw2).
> I did not look at the file but just looking at yout patch
> the "undef jemode_to_cpu" looks fishy in an exported header.
>
David already have patches to remove whole jffs-user.h file and AFAIK he
already queued it. So no point of touching this file.
Thanks,
--
JSR
next prev parent reply other threads:[~2009-06-05 2:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-04 8:01 [Patch 1/2] kbuild: two trivial fixes for check headers Amerigo Wang
2009-06-04 8:02 ` [Patch 2/2] kbuild: clean up scripts/headers.sh Amerigo Wang
2009-06-04 9:15 ` [Patch 1/2] kbuild: two trivial fixes for check headers Sam Ravnborg
2009-06-04 9:23 ` Amerigo Wang
2009-06-04 10:39 ` Sam Ravnborg
2009-06-05 2:05 ` Amerigo Wang
2009-06-05 2:23 ` Jaswinder Singh Rajput [this message]
2009-06-04 9:56 ` Amerigo Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1244168624.2522.11.camel@ht.satnam \
--to=jaswinder@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=amwang@redhat.com \
--cc=dwmw2@infradead.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox